From: Boqun Feng <boqun.feng@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Qingsong Chen" <changxian.cqs@antgroup.com>,
linux-kernel@vger.kernel.org, 田洪亮 <tate.thl@antgroup.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
"Asahi Lina" <lina@asahilina.net>,
"Sven Van Asbroeck" <thesven73@gmail.com>,
"Viktor Garske" <viktor@v-gar.de>, "Finn Behrens" <me@kloenk.dev>,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests
Date: Tue, 30 May 2023 11:33:13 -0700 [thread overview]
Message-ID: <ZHZBacreRpd0D/FV@boqun-archlinux> (raw)
In-Reply-To: <2023053003-antitoxic-popcorn-b1ab@gregkh>
On Tue, May 30, 2023 at 08:31:26AM +0100, Greg KH wrote:
> On Tue, May 30, 2023 at 02:48:21PM +0800, Qingsong Chen wrote:
> > Add a selftest module to provide a temporary place to put "pure tests"
> > for Rust funtionality and wrappers.
>
> Is this for in-kernel tests, or userspace tests? If userspace, you
> should follow the proper test reporting protocol the rest of the kernel
> uses. If in-kernel, it should follow the format that the in-kernel test
> currently has to be consistent. From what I could tell here, you aren't
> following either, but I might be totally wrong.
>
It is for in-kernel tests, and you're right, we should follow the other
in-kernel test format.
Some explanation about the background: when I was working on this little
"test framework", the Github CI of Rust-for-Linux (ab)used sample/rust/
for testing, that's why it was put there.
Now my understanding is that Rust KUnit support is coming, so we should
use kunit tests if possible.
Despite where the tests are put, I'm personally happy that this patchset
comes up with some tests, which help the review ;-)
Regards,
Boqun
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-05-30 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 6:48 [PATCH 0/2] Rust scatterlist abstractions Qingsong Chen
2023-05-30 6:48 ` [PATCH 1/2] rust: kernel: add scatterlist wrapper Qingsong Chen
2023-05-30 20:15 ` Martin Rodriguez Reboredo
2023-05-30 6:48 ` [PATCH 2/2] samples: rust: add `SgTable` and `ScatterList` selftests Qingsong Chen
2023-05-30 7:31 ` Greg KH
2023-05-30 18:33 ` Boqun Feng [this message]
2023-05-31 5:30 ` Qingsong Chen
2023-05-31 10:17 ` Miguel Ojeda
2023-05-30 14:21 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHZBacreRpd0D/FV@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=changxian.cqs@antgroup.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tate.thl@antgroup.com \
--cc=thesven73@gmail.com \
--cc=viktor@v-gar.de \
--cc=wedsonaf@gmail.com \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.