From: Alan Tull <atull@kernel.org> To: Nava kishore Manne <nava.manne@xilinx.com> Cc: Moritz Fischer <mdf@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Michal Simek <michal.simek@xilinx.com>, rajanv@xilinx.com, jollys@xilinx.com, linux-fpga@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, kishore m <chinnikishore369@gmail.com> Subject: Re: [PATCH 2/3] dt-bindings: fpga: Add bindings for ZynqMP fpga driver Date: Mon, 22 Oct 2018 12:41:56 -0500 [thread overview] Message-ID: <CANk1AXQ_AFGX9_80YM7-GYncfZ8pOhaYdSb=O-ZpYCWuHx71vA@mail.gmail.com> (raw) In-Reply-To: <20181020084805.29103-3-nava.manne@xilinx.com> On Fri, Oct 19, 2018 at 3:49 AM Nava kishore Manne <nava.manne@xilinx.com> wrote: Hi Nava, Just some nits, below. > > Add documentation to describe Xilinx ZynqMP fpga driver > bindings. > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > --- > Changes for v1: > Created a Seperate(New) DT binding file as > suggested by Rob. > > Changes for RFC-V2: > -Moved pcap node as a child to firwmare > node as suggested by Rob. > > .../bindings/fpga/xlnx,zynqmp-pcap-fpga.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > > diff --git a/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > new file mode 100644 > index 000000000000..248ff0ee60a8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > @@ -0,0 +1,17 @@ > +-------------------------------------------------------------------------- Please get rid of all these '----' separators (in 4 places). > +Device Tree zynqmp-fpga bindings for the Zynq Ultrascale+ MPSoC controlled > +using ZynqMP SoC firmware interface > +-------------------------------------------------------------------------- > +For Bitstream configuration on ZynqMp Soc uses processor configuration > +port(PCAP) to configure the programmable logic(PL) through PS by using > +FW interface. > + > +Required properties: > +- compatible: should contain "xlnx,zynqmp-pcap-fpga" > + > +------- > +Example Nit: please add a colon so 'Example:' > +------- > + zynqmp_pcap: pcap { > + compatible = "xlnx,zynqmp-pcap-fpga"; > + }; > -- > 2.18.0 > Thanks, Alan
WARNING: multiple messages have this Message-ID (diff)
From: atull@kernel.org (Alan Tull) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] dt-bindings: fpga: Add bindings for ZynqMP fpga driver Date: Mon, 22 Oct 2018 12:41:56 -0500 [thread overview] Message-ID: <CANk1AXQ_AFGX9_80YM7-GYncfZ8pOhaYdSb=O-ZpYCWuHx71vA@mail.gmail.com> (raw) In-Reply-To: <20181020084805.29103-3-nava.manne@xilinx.com> On Fri, Oct 19, 2018 at 3:49 AM Nava kishore Manne <nava.manne@xilinx.com> wrote: Hi Nava, Just some nits, below. > > Add documentation to describe Xilinx ZynqMP fpga driver > bindings. > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > --- > Changes for v1: > Created a Seperate(New) DT binding file as > suggested by Rob. > > Changes for RFC-V2: > -Moved pcap node as a child to firwmare > node as suggested by Rob. > > .../bindings/fpga/xlnx,zynqmp-pcap-fpga.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > > diff --git a/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > new file mode 100644 > index 000000000000..248ff0ee60a8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > @@ -0,0 +1,17 @@ > +-------------------------------------------------------------------------- Please get rid of all these '----' separators (in 4 places). > +Device Tree zynqmp-fpga bindings for the Zynq Ultrascale+ MPSoC controlled > +using ZynqMP SoC firmware interface > +-------------------------------------------------------------------------- > +For Bitstream configuration on ZynqMp Soc uses processor configuration > +port(PCAP) to configure the programmable logic(PL) through PS by using > +FW interface. > + > +Required properties: > +- compatible: should contain "xlnx,zynqmp-pcap-fpga" > + > +------- > +Example Nit: please add a colon so 'Example:' > +------- > + zynqmp_pcap: pcap { > + compatible = "xlnx,zynqmp-pcap-fpga"; > + }; > -- > 2.18.0 > Thanks, Alan
next prev parent reply other threads:[~2018-10-22 17:42 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-19 8:47 [PATCH 0/3] Add Bitstream configuration support for ZynqMP Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-19 8:47 ` [PATCH 1/3] firmware: xilinx: Add fpga API's Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-19 8:47 ` [PATCH 2/3] dt-bindings: fpga: Add bindings for ZynqMP fpga driver Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-22 17:41 ` Alan Tull [this message] 2018-10-22 17:41 ` Alan Tull 2018-10-22 17:41 ` Alan Tull 2018-10-24 6:45 ` Nava kishore Manne 2018-10-24 6:45 ` Nava kishore Manne 2018-10-24 6:45 ` Nava kishore Manne 2018-10-19 8:47 ` [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-20 8:48 ` Nava kishore Manne 2018-10-19 21:23 ` Moritz Fischer 2018-10-19 21:23 ` Moritz Fischer 2018-10-20 1:31 ` Moritz Fischer 2018-10-20 1:31 ` Moritz Fischer 2018-10-22 10:03 ` Nava kishore Manne 2018-10-22 10:03 ` Nava kishore Manne 2018-10-22 10:22 ` Moritz Fischer 2018-10-22 10:22 ` Moritz Fischer 2018-10-22 10:31 ` Nava kishore Manne 2018-10-22 10:31 ` Nava kishore Manne 2018-10-22 9:51 ` Nava kishore Manne 2018-10-22 9:51 ` Nava kishore Manne 2018-10-22 15:58 ` [PATCH 0/3] Add Bitstream configuration support for ZynqMP Alan Tull 2018-10-22 15:58 ` Alan Tull 2018-10-22 15:58 ` Alan Tull 2018-10-24 6:32 ` Nava kishore Manne 2018-10-24 6:32 ` Nava kishore Manne 2018-10-24 6:32 ` Nava kishore Manne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANk1AXQ_AFGX9_80YM7-GYncfZ8pOhaYdSb=O-ZpYCWuHx71vA@mail.gmail.com' \ --to=atull@kernel.org \ --cc=chinnikishore369@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=jollys@xilinx.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mdf@kernel.org \ --cc=michal.simek@xilinx.com \ --cc=nava.manne@xilinx.com \ --cc=rajanv@xilinx.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.