From: Alan Tull <atull@kernel.org> To: Moritz Fischer <moritz.fischer@ettus.com> Cc: "Rob Herring" <robh@kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, linux-fpga@vger.kernel.org, "Moritz Fischer" <mdf@kernel.org>, "Michal Simek" <michal.simek@xilinx.com>, "Sören Brinkmann" <soren.brinkmann@xilinx.com>, "Devicetree List" <devicetree@vger.kernel.org> Subject: Re: [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler Date: Wed, 5 Apr 2017 09:24:16 -0500 [thread overview] Message-ID: <CANk1AXQtp_YuVidfkXis_sn_jW4+e0uqPoMBpgcQmT8qwtmpJg@mail.gmail.com> (raw) In-Reply-To: <CAAtXAHe0qnu7Ub6sing4VUgFa-tkdvH767kNbZnu1S5THHS2oQ@mail.gmail.com> On Tue, Apr 4, 2017 at 6:36 PM, Moritz Fischer <moritz.fischer@ettus.com> wrote: > On Thu, Mar 30, 2017 at 05:44:29PM -0500, Rob Herring wrote: >> On Fri, Mar 24, 2017 at 10:33:20AM -0500, Alan Tull wrote: >> > From: Moritz Fischer <mdf@kernel.org> >> >> Please use "dt-bindings: fpga: ..." for the subject. >> >> >> > >> > This adds the binding documentation for the Xilinx LogiCORE PR >> > Decoupler soft core. >> > >> > Signed-off-by: Moritz Fischer <mdf@kernel.org> >> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> > Acked-by: Alan Tull <atull@kernel.org> >> >> I'm confused why you are sending these instead of Moritz? If it goes >> through you, then it should have your S-o-B too. Greg asked me to send patches to him. I should have started adding my signed-of-by at that point. > > Do you want me to resend this Alan (with Rob's suggestions)? I sent a set of patches to Greg on March 24. Looking back on that I realize that it didn't have Rob's ack yet (as well as having my ack where it should have been my signed-of-by). Yes, please resend this patchset with Rob's feedback. Thanks, ALan >> >> > Cc: Sören Brinkmann <soren.brinkmann@xilinx.com> >> > Cc: linux-kernel@vger.kernel.org >> > Cc: devicetree@vger.kernel.org >> > --- >> > .../bindings/fpga/xilinx-pr-decoupler.txt | 35 ++++++++++++++++++++++ >> > 1 file changed, 35 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > >> > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > new file mode 100644 >> > index 000000000000..2c527ac30398 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > @@ -0,0 +1,35 @@ >> > +Xilinx LogiCORE Partial Reconfig Decoupler Softcore >> > + >> > +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more >> > +decouplers / fpga bridges. >> > +The controller can decouple/disable the bridges which prevents signal >> > +changes from passing through the bridge. The controller can also >> > +couple / enable the bridges which allows traffic to pass through the >> > +bridge normally. >> > + >> > +The Driver supports only MMIO handling. A PR region can have multiple >> > +PR Decouplers which can be handled independently or chained via decouple/ >> > +decouple_status signals. >> > + >> > +Required properties: >> > +- compatible : Should contain "xlnx,pr-decoupler-1.00" or "xlnx,pr-decoupler" >> >> I'd drop xlnx,pr-decoupler, but in any case, it should not be OR rather >> "followed by". Plus the example has both. > > Michal wanted to have both, so I put both. Personally I don't care. I > think they have some downstream stuff that relied on it. > >> >> > +- regs : base address and size for decoupler module >> > +- clocks : input clock to IP >> > +- clock-names : should contain "aclk" >> > + >> > +Optional properties: >> > +- bridge-enable : 0 if driver should disable bridge at startup >> > + 1 if driver should enable bridge at startup >> > + Default is to leave bridge in current state. >> > + >> > +See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. >> > + >> > +Example: >> > + fpga-bridge@100000450 { >> > + compatible = "xlnx,pr-decoupler-1.00", >> > + "xlnx-pr-decoupler"; >> > + regs = <0x10000045 0x10>; >> > + clocks = <&clkc 15>; >> > + clock-names = "aclk"; >> > + bridge-enable = <0>; >> > + }; >> > -- >> > 2.11.0 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe devicetree" in >> > the body of a message to majordomo@vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > Moritz
WARNING: multiple messages have this Message-ID (diff)
From: Alan Tull <atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Moritz Fischer <moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org> Cc: "Rob Herring" <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Greg Kroah-Hartman" <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, "Linux Kernel Mailing List" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Moritz Fischer" <mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Michal Simek" <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>, "Sören Brinkmann" <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>, "Devicetree List" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler Date: Wed, 5 Apr 2017 09:24:16 -0500 [thread overview] Message-ID: <CANk1AXQtp_YuVidfkXis_sn_jW4+e0uqPoMBpgcQmT8qwtmpJg@mail.gmail.com> (raw) In-Reply-To: <CAAtXAHe0qnu7Ub6sing4VUgFa-tkdvH767kNbZnu1S5THHS2oQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Tue, Apr 4, 2017 at 6:36 PM, Moritz Fischer <moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org> wrote: > On Thu, Mar 30, 2017 at 05:44:29PM -0500, Rob Herring wrote: >> On Fri, Mar 24, 2017 at 10:33:20AM -0500, Alan Tull wrote: >> > From: Moritz Fischer <mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> >> Please use "dt-bindings: fpga: ..." for the subject. >> >> >> > >> > This adds the binding documentation for the Xilinx LogiCORE PR >> > Decoupler soft core. >> > >> > Signed-off-by: Moritz Fischer <mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> > Signed-off-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> >> > Acked-by: Alan Tull <atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> >> I'm confused why you are sending these instead of Moritz? If it goes >> through you, then it should have your S-o-B too. Greg asked me to send patches to him. I should have started adding my signed-of-by at that point. > > Do you want me to resend this Alan (with Rob's suggestions)? I sent a set of patches to Greg on March 24. Looking back on that I realize that it didn't have Rob's ack yet (as well as having my ack where it should have been my signed-of-by). Yes, please resend this patchset with Rob's feedback. Thanks, ALan >> >> > Cc: Sören Brinkmann <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> >> > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> > --- >> > .../bindings/fpga/xilinx-pr-decoupler.txt | 35 ++++++++++++++++++++++ >> > 1 file changed, 35 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > >> > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > new file mode 100644 >> > index 000000000000..2c527ac30398 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > @@ -0,0 +1,35 @@ >> > +Xilinx LogiCORE Partial Reconfig Decoupler Softcore >> > + >> > +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more >> > +decouplers / fpga bridges. >> > +The controller can decouple/disable the bridges which prevents signal >> > +changes from passing through the bridge. The controller can also >> > +couple / enable the bridges which allows traffic to pass through the >> > +bridge normally. >> > + >> > +The Driver supports only MMIO handling. A PR region can have multiple >> > +PR Decouplers which can be handled independently or chained via decouple/ >> > +decouple_status signals. >> > + >> > +Required properties: >> > +- compatible : Should contain "xlnx,pr-decoupler-1.00" or "xlnx,pr-decoupler" >> >> I'd drop xlnx,pr-decoupler, but in any case, it should not be OR rather >> "followed by". Plus the example has both. > > Michal wanted to have both, so I put both. Personally I don't care. I > think they have some downstream stuff that relied on it. > >> >> > +- regs : base address and size for decoupler module >> > +- clocks : input clock to IP >> > +- clock-names : should contain "aclk" >> > + >> > +Optional properties: >> > +- bridge-enable : 0 if driver should disable bridge at startup >> > + 1 if driver should enable bridge at startup >> > + Default is to leave bridge in current state. >> > + >> > +See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. >> > + >> > +Example: >> > + fpga-bridge@100000450 { >> > + compatible = "xlnx,pr-decoupler-1.00", >> > + "xlnx-pr-decoupler"; >> > + regs = <0x10000045 0x10>; >> > + clocks = <&clkc 15>; >> > + clock-names = "aclk"; >> > + bridge-enable = <0>; >> > + }; >> > -- >> > 2.11.0 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe devicetree" in >> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > Moritz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-05 14:25 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-24 15:33 [PATCH 0/2] fpga: Xilinx LogiCore PR Decoupler Alan Tull 2017-03-24 15:33 ` [PATCH 1/2] doc: Add bindings document for " Alan Tull 2017-03-30 22:44 ` Rob Herring 2017-03-30 22:44 ` Rob Herring 2017-03-30 22:44 ` Rob Herring 2017-04-04 23:36 ` Moritz Fischer 2017-04-04 23:36 ` Moritz Fischer 2017-04-05 6:26 ` Michal Simek 2017-04-05 6:26 ` Michal Simek 2017-04-05 14:24 ` Alan Tull [this message] 2017-04-05 14:24 ` Alan Tull 2017-03-24 15:33 ` [PATCH 2/2] fpga: Add support for Xilinx LogiCORE " Alan Tull 2017-03-24 15:33 ` Alan Tull -- strict thread matches above, loose matches on Subject: below -- 2017-03-10 21:30 [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore " Moritz Fischer 2017-03-10 21:30 ` Moritz Fischer 2017-03-10 21:30 ` Moritz Fischer 2017-03-13 10:29 ` Michal Simek 2017-03-13 10:29 ` Michal Simek 2017-03-13 10:29 ` Michal Simek 2017-03-13 10:29 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANk1AXQtp_YuVidfkXis_sn_jW4+e0uqPoMBpgcQmT8qwtmpJg@mail.gmail.com \ --to=atull@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mdf@kernel.org \ --cc=michal.simek@xilinx.com \ --cc=moritz.fischer@ettus.com \ --cc=robh@kernel.org \ --cc=soren.brinkmann@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.