All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: kernel test robot <oliver.sang@intel.com>
Cc: lkp@lists.01.org, kbuild test robot <lkp@intel.com>,
	"David S. Miller" <davem@davemloft.net>, Doug Porter <dsp@fb.com>,
	Soheil Hassas Yeganeh <soheil@google.com>,
	Neal Cardwell <ncardwell@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [tcp] 4bfe744ff1: packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat_ipv4-mapped-v6.fail
Date: Tue, 20 Sep 2022 08:59:48 -0700	[thread overview]
Message-ID: <CANn89iJn554zCtkG9d556kgC4010yfgc4X+GAnoQQW+5Z_sNpg@mail.gmail.com> (raw)
In-Reply-To: <202209201359.3f33d97f-oliver.sang@intel.com>

On Mon, Sep 19, 2022 at 10:22 PM kernel test robot
<oliver.sang@intel.com> wrote:
>
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-11):
>
> commit: 4bfe744ff1644fbc0a991a2677dc874475dd6776 ("tcp: fix potential xmit stalls caused by TCP_NOTSENT_LOWAT")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> in testcase: packetdrill
> version: packetdrill-x86_64-329d89e-1_20220824
> with following parameters:
>
>
>
> on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (Kaby Lake) with 32G memory
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
>
> If you fix the issue, kindly add following tag
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Link: https://lore.kernel.org/r/202209201359.3f33d97f-oliver.sang@intel.com
>
>
> we actually also observed other tests failed on this commit but pass on parent:
> (more details are in attached dmesg and 'packetdrill' file)
>
> =========================================================================================
> tbox_group/testcase/rootfs/kconfig/compiler:
>   lkp-kbl-d01/packetdrill/debian-11.1-x86_64-20220510.cgz/x86_64-rhel-8.3-func/gcc-11
>
> 1fcb8fb3522f5b0f 4bfe744ff1644fbc0a991a2677d
> ---------------- ---------------------------
>        fail:runs  %reproduction    fail:runs
>            |             |             |
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat_ipv4-mapped-v6.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat_ipv4.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_ipv4-mapped-v6.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_ipv4.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_notsent_lowat_ipv4-mapped-v6.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_notsent_lowat_ipv4.fail
>
>
> stdout:
> stderr:
> FAIL [/lkp/benchmarks/packetdrill/gtests/net/tcp/epoll/epoll_out_edge.pkt (ipv4)]
> stdout:
> stderr:
> FAIL [/lkp/benchmarks/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat.pkt (ipv4-mapped-v6)]
>
>
>
> To reproduce:
>
>         git clone https://github.com/intel/lkp-tests.git
>         cd lkp-tests
>         sudo bin/lkp install job.yaml           # job file is attached in this email
>         bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
>         sudo bin/lkp run generated-yaml-file
>
>         # if come across any failure that blocks the test,
>         # please remove ~/.lkp and /lkp dir to run from a clean state.
>
>
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
>
>

Sure, these (out of tree) packetdrill tests need to account for the
new kernel behavior.

I am not sure who is responsible for these tests, but this is not the
kernel maintainers.

WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <edumazet@google.com>
To: lkp@lists.01.org
Subject: Re: [tcp] 4bfe744ff1: packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat_ipv4-mapped-v6.fail
Date: Tue, 20 Sep 2022 08:59:48 -0700	[thread overview]
Message-ID: <CANn89iJn554zCtkG9d556kgC4010yfgc4X+GAnoQQW+5Z_sNpg@mail.gmail.com> (raw)
In-Reply-To: <202209201359.3f33d97f-oliver.sang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]

On Mon, Sep 19, 2022 at 10:22 PM kernel test robot
<oliver.sang@intel.com> wrote:
>
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-11):
>
> commit: 4bfe744ff1644fbc0a991a2677dc874475dd6776 ("tcp: fix potential xmit stalls caused by TCP_NOTSENT_LOWAT")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> in testcase: packetdrill
> version: packetdrill-x86_64-329d89e-1_20220824
> with following parameters:
>
>
>
> on test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (Kaby Lake) with 32G memory
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
>
> If you fix the issue, kindly add following tag
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Link: https://lore.kernel.org/r/202209201359.3f33d97f-oliver.sang(a)intel.com
>
>
> we actually also observed other tests failed on this commit but pass on parent:
> (more details are in attached dmesg and 'packetdrill' file)
>
> =========================================================================================
> tbox_group/testcase/rootfs/kconfig/compiler:
>   lkp-kbl-d01/packetdrill/debian-11.1-x86_64-20220510.cgz/x86_64-rhel-8.3-func/gcc-11
>
> 1fcb8fb3522f5b0f 4bfe744ff1644fbc0a991a2677d
> ---------------- ---------------------------
>        fail:runs  %reproduction    fail:runs
>            |             |             |
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat_ipv4-mapped-v6.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat_ipv4.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_ipv4-mapped-v6.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_ipv4.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_notsent_lowat_ipv4-mapped-v6.fail
>            :30         100%          30:30    packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_notsent_lowat_ipv4.fail
>
>
> stdout:
> stderr:
> FAIL [/lkp/benchmarks/packetdrill/gtests/net/tcp/epoll/epoll_out_edge.pkt (ipv4)]
> stdout:
> stderr:
> FAIL [/lkp/benchmarks/packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat.pkt (ipv4-mapped-v6)]
>
>
>
> To reproduce:
>
>         git clone https://github.com/intel/lkp-tests.git
>         cd lkp-tests
>         sudo bin/lkp install job.yaml           # job file is attached in this email
>         bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
>         sudo bin/lkp run generated-yaml-file
>
>         # if come across any failure that blocks the test,
>         # please remove ~/.lkp and /lkp dir to run from a clean state.
>
>
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
>
>

Sure, these (out of tree) packetdrill tests need to account for the
new kernel behavior.

I am not sure who is responsible for these tests, but this is not the
kernel maintainers.

  reply	other threads:[~2022-09-20 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  5:22 [tcp] 4bfe744ff1: packetdrill.packetdrill/gtests/net/tcp/epoll/epoll_out_edge_default_notsent_lowat_ipv4-mapped-v6.fail kernel test robot
2022-09-20  5:22 ` kernel test robot
2022-09-20 15:59 ` Eric Dumazet [this message]
2022-09-20 15:59   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANn89iJn554zCtkG9d556kgC4010yfgc4X+GAnoQQW+5Z_sNpg@mail.gmail.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=dsp@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lkp@lists.01.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=oliver.sang@intel.com \
    --cc=soheil@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.