All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Mao Wenan <wenan.mao@linux.alibaba.com>
Cc: David Miller <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net v5] net: Update window_clamp if SOCK_RCVBUF is set
Date: Tue, 10 Nov 2020 08:32:52 +0100	[thread overview]
Message-ID: <CANn89iL6UW9mG6hW7f3Yv+32Pe_i9F-5cQhfo2uV68wdcgSuZA@mail.gmail.com> (raw)
In-Reply-To: <1604967391-123737-1-git-send-email-wenan.mao@linux.alibaba.com>

On Tue, Nov 10, 2020 at 1:16 AM Mao Wenan <wenan.mao@linux.alibaba.com> wrote:
>
> When net.ipv4.tcp_syncookies=1 and syn flood is happened,
> cookie_v4_check or cookie_v6_check tries to redo what
> tcp_v4_send_synack or tcp_v6_send_synack did,
> rsk_window_clamp will be changed if SOCK_RCVBUF is set,
> which will make rcv_wscale is different, the client
> still operates with initial window scale and can overshot
> granted window, the client use the initial scale but local
> server use new scale to advertise window value, and session
> work abnormally.
>
> Fixes: e88c64f0a425 ("tcp: allow effective reduction of TCP's rcv-buffer via setsockopt")
> Signed-off-by: Mao Wenan <wenan.mao@linux.alibaba.com>

Signed-off-by: Eric Dumazet <edumazet@google.com>

Thanks !

WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <edumazet@google.com>
To: Mao Wenan <wenan.mao@linux.alibaba.com>
Cc: David Miller <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net v5] net: Update window_clamp if SOCK_RCVBUF is set
Date: Tue, 10 Nov 2020 07:32:52 +0000	[thread overview]
Message-ID: <CANn89iL6UW9mG6hW7f3Yv+32Pe_i9F-5cQhfo2uV68wdcgSuZA@mail.gmail.com> (raw)
In-Reply-To: <1604967391-123737-1-git-send-email-wenan.mao@linux.alibaba.com>

On Tue, Nov 10, 2020 at 1:16 AM Mao Wenan <wenan.mao@linux.alibaba.com> wrote:
>
> When net.ipv4.tcp_syncookies=1 and syn flood is happened,
> cookie_v4_check or cookie_v6_check tries to redo what
> tcp_v4_send_synack or tcp_v6_send_synack did,
> rsk_window_clamp will be changed if SOCK_RCVBUF is set,
> which will make rcv_wscale is different, the client
> still operates with initial window scale and can overshot
> granted window, the client use the initial scale but local
> server use new scale to advertise window value, and session
> work abnormally.
>
> Fixes: e88c64f0a425 ("tcp: allow effective reduction of TCP's rcv-buffer via setsockopt")
> Signed-off-by: Mao Wenan <wenan.mao@linux.alibaba.com>

Signed-off-by: Eric Dumazet <edumazet@google.com>

Thanks !

  reply	other threads:[~2020-11-10  7:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09  9:20 [PATCH] net: Update window_clamp if SOCK_RCVBUF is set Mao Wenan
2020-11-09  9:20 ` Mao Wenan
2020-11-09  9:33 ` [PATCH net v2] " Mao Wenan
2020-11-09  9:33   ` Mao Wenan
2020-11-09  9:56   ` Eric Dumazet
2020-11-09  9:56     ` Eric Dumazet
2020-11-09 10:12     ` Mao Wenan
2020-11-09 10:12       ` Mao Wenan
2020-11-09 10:19       ` Mao Wenan
2020-11-09 10:19         ` Mao Wenan
2020-11-09 11:02       ` Eric Dumazet
2020-11-09 11:02         ` Eric Dumazet
2020-11-09 11:41         ` Eric Dumazet
2020-11-09 11:41           ` Eric Dumazet
2020-11-09 14:01           ` Eric Dumazet
2020-11-09 14:01             ` Eric Dumazet
2020-11-09 16:26             ` Mao Wenan
2020-11-09 16:26               ` Mao Wenan
2020-11-09 16:53             ` [PATCH net v3] " Mao Wenan
2020-11-09 16:53               ` Mao Wenan
2020-11-09 16:59               ` Eric Dumazet
2020-11-09 16:59                 ` Eric Dumazet
2020-11-09 17:17                 ` [PATCH net v4] " Mao Wenan
2020-11-09 17:17                   ` Mao Wenan
2020-11-09 17:28                   ` Eric Dumazet
2020-11-09 17:28                     ` Eric Dumazet
2020-11-10  0:16                     ` [PATCH net v5] " Mao Wenan
2020-11-10  0:16                       ` Mao Wenan
2020-11-10  7:32                       ` Eric Dumazet [this message]
2020-11-10  7:32                         ` Eric Dumazet
2020-11-11  1:45                         ` Jakub Kicinski
2020-11-11  1:45                           ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANn89iL6UW9mG6hW7f3Yv+32Pe_i9F-5cQhfo2uV68wdcgSuZA@mail.gmail.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wenan.mao@linux.alibaba.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.