* [PATCH net] net: unexport skb_gro_receive()
@ 2020-05-19 22:50 Eric Dumazet
2020-05-19 22:53 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2020-05-19 22:50 UTC (permalink / raw)
To: David S . Miller; +Cc: netdev, Eric Dumazet, Eric Dumazet
skb_gro_receive() used to be used by SCTP, it is no longer the case.
skb_gro_receive_list() is in the same category : never used from modules.
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
net/core/skbuff.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 7e29590482ce509ea1d3b2306f4796f697b76d4f..4dd13e9b92d61e44ec4cda95fa64f72dcc5f6a71 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -3727,7 +3727,6 @@ int skb_gro_receive_list(struct sk_buff *p, struct sk_buff *skb)
return 0;
}
-EXPORT_SYMBOL_GPL(skb_gro_receive_list);
/**
* skb_segment - Perform protocol segmentation on skb.
@@ -4191,7 +4190,6 @@ int skb_gro_receive(struct sk_buff *p, struct sk_buff *skb)
NAPI_GRO_CB(skb)->same_flow = 1;
return 0;
}
-EXPORT_SYMBOL_GPL(skb_gro_receive);
#ifdef CONFIG_SKB_EXTENSIONS
#define SKB_EXT_ALIGN_VALUE 8
--
2.26.2.761.g0e0b3e54be-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: unexport skb_gro_receive()
2020-05-19 22:50 [PATCH net] net: unexport skb_gro_receive() Eric Dumazet
@ 2020-05-19 22:53 ` David Miller
2020-05-19 22:53 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2020-05-19 22:53 UTC (permalink / raw)
To: edumazet; +Cc: netdev, eric.dumazet
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 19 May 2020 15:50:12 -0700
> skb_gro_receive() used to be used by SCTP, it is no longer the case.
>
> skb_gro_receive_list() is in the same category : never used from modules.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Maybe this is net-next material instead?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: unexport skb_gro_receive()
2020-05-19 22:53 ` David Miller
@ 2020-05-19 22:53 ` Eric Dumazet
2020-05-20 2:55 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2020-05-19 22:53 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Eric Dumazet
On Tue, May 19, 2020 at 3:53 PM David Miller <davem@davemloft.net> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
> Date: Tue, 19 May 2020 15:50:12 -0700
>
> > skb_gro_receive() used to be used by SCTP, it is no longer the case.
> >
> > skb_gro_receive_list() is in the same category : never used from modules.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Maybe this is net-next material instead?
Sure thing !
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: unexport skb_gro_receive()
2020-05-19 22:53 ` Eric Dumazet
@ 2020-05-20 2:55 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-05-20 2:55 UTC (permalink / raw)
To: edumazet; +Cc: netdev, eric.dumazet
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 19 May 2020 15:53:51 -0700
> On Tue, May 19, 2020 at 3:53 PM David Miller <davem@davemloft.net> wrote:
>>
>> From: Eric Dumazet <edumazet@google.com>
>> Date: Tue, 19 May 2020 15:50:12 -0700
>>
>> > skb_gro_receive() used to be used by SCTP, it is no longer the case.
>> >
>> > skb_gro_receive_list() is in the same category : never used from modules.
>> >
>> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>>
>> Maybe this is net-next material instead?
>
> Sure thing !
Great, applied :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-20 2:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 22:50 [PATCH net] net: unexport skb_gro_receive() Eric Dumazet
2020-05-19 22:53 ` David Miller
2020-05-19 22:53 ` Eric Dumazet
2020-05-20 2:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.