From: Eric Dumazet <edumazet@google.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
netdev <netdev@vger.kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Daniel Vetter <daniel@ffwll.ch>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Chris Wilson <chris.p.wilson@intel.com>,
Dmitry Vyukov <dvyukov@google.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing
Date: Fri, 18 Feb 2022 05:01:04 -0800 [thread overview]
Message-ID: <CANn89iLS5oqOvafFy9SW0CDiyv9GGJYsE8MpE200K5NaA8h0xw@mail.gmail.com> (raw)
In-Reply-To: <199aebfb-f364-cd9b-5d2b-dbe42b779a41@intel.com>
On Fri, Feb 18, 2022 at 2:55 AM Andrzej Hajda <andrzej.hajda@intel.com> wrote:
>
> OK, could be faster and less invasive.
> Other solution would be keeping the array in dir and update in every
> tracker alloc/free, this way we avoid iteration over potentially big
> list, but it would cost memory and since printing is rather rare I am
> not sure if it is worth.
printing is extremely rare [1]
We want to use ref_tracker in production, we need to keep the fast
path as fast as possible ;)
[1] If you think about providing access to the traces from sysfs, we
might need to make sure we do not hold the dir spinlock
during the expensive generation of the output data.
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <edumazet@google.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Chris Wilson <chris.p.wilson@intel.com>,
netdev <netdev@vger.kernel.org>,
intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, Jakub Kicinski <kuba@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing
Date: Fri, 18 Feb 2022 05:01:04 -0800 [thread overview]
Message-ID: <CANn89iLS5oqOvafFy9SW0CDiyv9GGJYsE8MpE200K5NaA8h0xw@mail.gmail.com> (raw)
In-Reply-To: <199aebfb-f364-cd9b-5d2b-dbe42b779a41@intel.com>
On Fri, Feb 18, 2022 at 2:55 AM Andrzej Hajda <andrzej.hajda@intel.com> wrote:
>
> OK, could be faster and less invasive.
> Other solution would be keeping the array in dir and update in every
> tracker alloc/free, this way we avoid iteration over potentially big
> list, but it would cost memory and since printing is rather rare I am
> not sure if it is worth.
printing is extremely rare [1]
We want to use ref_tracker in production, we need to keep the fast
path as fast as possible ;)
[1] If you think about providing access to the traces from sysfs, we
might need to make sure we do not hold the dir spinlock
during the expensive generation of the output data.
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <edumazet@google.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Chris Wilson <chris.p.wilson@intel.com>,
netdev <netdev@vger.kernel.org>,
intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, Jakub Kicinski <kuba@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Intel-gfx] [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing
Date: Fri, 18 Feb 2022 05:01:04 -0800 [thread overview]
Message-ID: <CANn89iLS5oqOvafFy9SW0CDiyv9GGJYsE8MpE200K5NaA8h0xw@mail.gmail.com> (raw)
In-Reply-To: <199aebfb-f364-cd9b-5d2b-dbe42b779a41@intel.com>
On Fri, Feb 18, 2022 at 2:55 AM Andrzej Hajda <andrzej.hajda@intel.com> wrote:
>
> OK, could be faster and less invasive.
> Other solution would be keeping the array in dir and update in every
> tracker alloc/free, this way we avoid iteration over potentially big
> list, but it would cost memory and since printing is rather rare I am
> not sure if it is worth.
printing is extremely rare [1]
We want to use ref_tracker in production, we need to keep the fast
path as fast as possible ;)
[1] If you think about providing access to the traces from sysfs, we
might need to make sure we do not hold the dir spinlock
during the expensive generation of the output data.
next prev parent reply other threads:[~2022-02-18 13:01 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:04 [PATCH 0/9] drm/i915: use ref_tracker library for tracking wakerefs Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 14:04 ` [PATCH 1/9] lib/ref_tracker: add unlocked leak print helper Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 14:04 ` [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 15:23 ` Eric Dumazet
2022-02-17 15:23 ` Eric Dumazet
2022-02-17 15:23 ` [Intel-gfx] " Eric Dumazet
2022-02-17 15:25 ` Eric Dumazet
2022-02-17 15:25 ` Eric Dumazet
2022-02-17 15:25 ` [Intel-gfx] " Eric Dumazet
2022-02-18 10:54 ` Andrzej Hajda
2022-02-18 10:54 ` [Intel-gfx] " Andrzej Hajda
2022-02-18 10:54 ` Andrzej Hajda
2022-02-18 13:01 ` Eric Dumazet [this message]
2022-02-18 13:01 ` [Intel-gfx] " Eric Dumazet
2022-02-18 13:01 ` Eric Dumazet
2022-02-17 14:04 ` [PATCH 3/9] lib/ref_tracker: __ref_tracker_dir_print improve printing Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 15:38 ` Eric Dumazet
2022-02-17 15:38 ` Eric Dumazet
2022-02-17 15:38 ` [Intel-gfx] " Eric Dumazet
2022-02-18 10:11 ` Andrzej Hajda
2022-02-18 10:11 ` [Intel-gfx] " Andrzej Hajda
2022-02-18 10:11 ` Andrzej Hajda
2022-02-17 14:04 ` [PATCH 4/9] lib/ref_tracker: add printing to memory buffer Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 14:04 ` [PATCH 5/9] lib/ref_tracker: improve allocation flags Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 15:13 ` Eric Dumazet
2022-02-17 15:13 ` Eric Dumazet
2022-02-17 15:13 ` [Intel-gfx] " Eric Dumazet
2022-02-18 10:28 ` Andrzej Hajda
2022-02-18 10:28 ` [Intel-gfx] " Andrzej Hajda
2022-02-18 10:28 ` Andrzej Hajda
2022-02-18 13:05 ` Eric Dumazet
2022-02-18 13:05 ` [Intel-gfx] " Eric Dumazet
2022-02-18 13:05 ` Eric Dumazet
2022-02-17 14:04 ` [PATCH 6/9] drm/i915: Separate wakeref tracking Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 14:48 ` [Intel-gfx] " Ville Syrjälä
2022-02-17 14:48 ` Ville Syrjälä
2022-02-18 10:32 ` Andrzej Hajda
2022-02-18 10:32 ` Andrzej Hajda
2022-02-17 14:04 ` [PATCH 7/9] drm/i915: Track leaked gt->wakerefs Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 14:04 ` [PATCH 8/9] drm/i915: Correct type of wakeref variable Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 14:04 ` [PATCH 9/9] drm/i915: replace Intel internal tracker with kernel core ref_tracker Andrzej Hajda
2022-02-17 14:04 ` [Intel-gfx] " Andrzej Hajda
2022-02-17 14:04 ` Andrzej Hajda
2022-02-17 21:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use ref_tracker library for tracking wakerefs Patchwork
2022-02-17 21:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-17 22:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iLS5oqOvafFy9SW0CDiyv9GGJYsE8MpE200K5NaA8h0xw@mail.gmail.com \
--to=edumazet@google.com \
--cc=andrzej.hajda@intel.com \
--cc=chris.p.wilson@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvyukov@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.