From: Eric Dumazet <edumazet@google.com>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev <netdev@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: remove redundant check on tskb
Date: Fri, 5 Apr 2019 00:46:39 -0700 [thread overview]
Message-ID: <CANn89iLsp+Nii7Y-ppBnLbinR7e=vVJ6QsMjBVLjcAKs9zQaRA@mail.gmail.com> (raw)
In-Reply-To: <20190404144603.27682-1-colin.king@canonical.com>
On Thu, Apr 4, 2019 at 7:46 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The non-null check on tskb is always false because it is in an else
> path of a check on tskb and hence tskb is null in this code block.
> This is check is therefore redundant and can be removed as well
> as the label coalesc.
>...
> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
SGTM, thanks.
Signed-off-by: Eric Dumazet <edumazet@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <edumazet@google.com>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev <netdev@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: remove redundant check on tskb
Date: Fri, 05 Apr 2019 07:46:39 +0000 [thread overview]
Message-ID: <CANn89iLsp+Nii7Y-ppBnLbinR7e=vVJ6QsMjBVLjcAKs9zQaRA@mail.gmail.com> (raw)
In-Reply-To: <20190404144603.27682-1-colin.king@canonical.com>
On Thu, Apr 4, 2019 at 7:46 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The non-null check on tskb is always false because it is in an else
> path of a check on tskb and hence tskb is null in this code block.
> This is check is therefore redundant and can be removed as well
> as the label coalesc.
>...
> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
SGTM, thanks.
Signed-off-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2019-04-05 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 14:46 [PATCH] tcp: remove redundant check on tskb Colin King
2019-04-04 14:46 ` Colin King
2019-04-04 15:05 ` Dan Carpenter
2019-04-04 15:05 ` Dan Carpenter
2019-04-05 6:47 ` Mukesh Ojha
2019-04-05 6:59 ` Mukesh Ojha
2019-04-05 7:46 ` Eric Dumazet [this message]
2019-04-05 7:46 ` Eric Dumazet
2019-04-07 1:18 ` David Miller
2019-04-07 1:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLsp+Nii7Y-ppBnLbinR7e=vVJ6QsMjBVLjcAKs9zQaRA@mail.gmail.com' \
--to=edumazet@google.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.