* [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5).
@ 2022-07-20 16:50 Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 01/15] tcp: Fix data-races around sysctl_tcp_dsack Kuniyuki Iwashima
` (16 more replies)
0 siblings, 17 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
This series fixes data-races around 15 knobs after tcp_dsack in
ipv4_net_table.
tcp_tso_win_divisor was skipped because it already uses READ_ONCE().
So, the final round for ipv4_net_table will start with tcp_pacing_ss_ratio.
Kuniyuki Iwashima (15):
tcp: Fix data-races around sysctl_tcp_dsack.
tcp: Fix a data-race around sysctl_tcp_app_win.
tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
tcp: Fix a data-race around sysctl_tcp_frto.
tcp: Fix a data-race around sysctl_tcp_nometrics_save.
tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.
tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.
tcp: Fix data-races around sysctl_tcp_workaround_signed_windows.
tcp: Fix a data-race around sysctl_tcp_limit_output_bytes.
tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit.
tcp: Fix a data-race around sysctl_tcp_min_tso_segs.
tcp: Fix a data-race around sysctl_tcp_tso_rtt_log.
tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen.
tcp: Fix a data-race around sysctl_tcp_autocorking.
tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.
include/net/tcp.h | 2 +-
net/ipv4/tcp.c | 2 +-
net/ipv4/tcp_input.c | 17 +++++++++--------
net/ipv4/tcp_metrics.c | 10 +++++-----
net/ipv4/tcp_output.c | 10 +++++-----
net/mptcp/options.c | 2 +-
net/mptcp/protocol.c | 2 +-
7 files changed, 23 insertions(+), 22 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v1 net 01/15] tcp: Fix data-races around sysctl_tcp_dsack.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 02/15] tcp: Fix a data-race around sysctl_tcp_app_win Kuniyuki Iwashima
` (15 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_dsack, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_input.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 07dbcbae7782..6fdad9505396 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -4426,7 +4426,7 @@ static void tcp_dsack_set(struct sock *sk, u32 seq, u32 end_seq)
{
struct tcp_sock *tp = tcp_sk(sk);
- if (tcp_is_sack(tp) && sock_net(sk)->ipv4.sysctl_tcp_dsack) {
+ if (tcp_is_sack(tp) && READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_dsack)) {
int mib_idx;
if (before(seq, tp->rcv_nxt))
@@ -4473,7 +4473,7 @@ static void tcp_send_dupack(struct sock *sk, const struct sk_buff *skb)
NET_INC_STATS(sock_net(sk), LINUX_MIB_DELAYEDACKLOST);
tcp_enter_quickack_mode(sk, TCP_MAX_QUICKACKS);
- if (tcp_is_sack(tp) && sock_net(sk)->ipv4.sysctl_tcp_dsack) {
+ if (tcp_is_sack(tp) && READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_dsack)) {
u32 end_seq = TCP_SKB_CB(skb)->end_seq;
tcp_rcv_spurious_retrans(sk, skb);
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 02/15] tcp: Fix a data-race around sysctl_tcp_app_win.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 01/15] tcp: Fix data-races around sysctl_tcp_dsack Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 03/15] tcp: Fix a data-race around sysctl_tcp_adv_win_scale Kuniyuki Iwashima
` (14 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_app_win, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 6fdad9505396..8cf4fbd349ab 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -534,7 +534,7 @@ static void tcp_grow_window(struct sock *sk, const struct sk_buff *skb,
*/
static void tcp_init_buffer_space(struct sock *sk)
{
- int tcp_app_win = sock_net(sk)->ipv4.sysctl_tcp_app_win;
+ int tcp_app_win = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_app_win);
struct tcp_sock *tp = tcp_sk(sk);
int maxwin;
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 03/15] tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 01/15] tcp: Fix data-races around sysctl_tcp_dsack Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 02/15] tcp: Fix a data-race around sysctl_tcp_app_win Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 04/15] tcp: Fix a data-race around sysctl_tcp_frto Kuniyuki Iwashima
` (13 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_adv_win_scale, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
include/net/tcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 071735e10872..78a64e1b33a7 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1419,7 +1419,7 @@ void tcp_select_initial_window(const struct sock *sk, int __space,
static inline int tcp_win_from_space(const struct sock *sk, int space)
{
- int tcp_adv_win_scale = sock_net(sk)->ipv4.sysctl_tcp_adv_win_scale;
+ int tcp_adv_win_scale = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_adv_win_scale);
return tcp_adv_win_scale <= 0 ?
(space>>(-tcp_adv_win_scale)) :
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 04/15] tcp: Fix a data-race around sysctl_tcp_frto.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (2 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 03/15] tcp: Fix a data-race around sysctl_tcp_adv_win_scale Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 05/15] tcp: Fix a data-race around sysctl_tcp_nometrics_save Kuniyuki Iwashima
` (12 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_frto, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 8cf4fbd349ab..af376d7423d1 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -2175,7 +2175,7 @@ void tcp_enter_loss(struct sock *sk)
* loss recovery is underway except recurring timeout(s) on
* the same SND.UNA (sec 3.2). Disable F-RTO on path MTU probing
*/
- tp->frto = net->ipv4.sysctl_tcp_frto &&
+ tp->frto = READ_ONCE(net->ipv4.sysctl_tcp_frto) &&
(new_recovery || icsk->icsk_retransmits) &&
!inet_csk(sk)->icsk_mtup.probe_size;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 05/15] tcp: Fix a data-race around sysctl_tcp_nometrics_save.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (3 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 04/15] tcp: Fix a data-race around sysctl_tcp_frto Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 06/15] tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save Kuniyuki Iwashima
` (11 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_nometrics_save, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_metrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c
index a501150deaa3..9dcc418a26f2 100644
--- a/net/ipv4/tcp_metrics.c
+++ b/net/ipv4/tcp_metrics.c
@@ -329,7 +329,7 @@ void tcp_update_metrics(struct sock *sk)
int m;
sk_dst_confirm(sk);
- if (net->ipv4.sysctl_tcp_nometrics_save || !dst)
+ if (READ_ONCE(net->ipv4.sysctl_tcp_nometrics_save) || !dst)
return;
rcu_read_lock();
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 06/15] tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (4 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 05/15] tcp: Fix a data-race around sysctl_tcp_nometrics_save Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 07/15] tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf Kuniyuki Iwashima
` (10 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev, Kevin Yang
While reading sysctl_tcp_no_ssthresh_metrics_save, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its readers.
Fixes: 65e6d90168f3 ("net-tcp: Disable TCP ssthresh metrics cache by default")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
CC: Kevin(Yudong) Yang <yyd@google.com>
---
net/ipv4/tcp_metrics.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c
index 9dcc418a26f2..d58e672be31c 100644
--- a/net/ipv4/tcp_metrics.c
+++ b/net/ipv4/tcp_metrics.c
@@ -385,7 +385,7 @@ void tcp_update_metrics(struct sock *sk)
if (tcp_in_initial_slowstart(tp)) {
/* Slow start still did not finish. */
- if (!net->ipv4.sysctl_tcp_no_ssthresh_metrics_save &&
+ if (!READ_ONCE(net->ipv4.sysctl_tcp_no_ssthresh_metrics_save) &&
!tcp_metric_locked(tm, TCP_METRIC_SSTHRESH)) {
val = tcp_metric_get(tm, TCP_METRIC_SSTHRESH);
if (val && (tcp_snd_cwnd(tp) >> 1) > val)
@@ -401,7 +401,7 @@ void tcp_update_metrics(struct sock *sk)
} else if (!tcp_in_slow_start(tp) &&
icsk->icsk_ca_state == TCP_CA_Open) {
/* Cong. avoidance phase, cwnd is reliable. */
- if (!net->ipv4.sysctl_tcp_no_ssthresh_metrics_save &&
+ if (!READ_ONCE(net->ipv4.sysctl_tcp_no_ssthresh_metrics_save) &&
!tcp_metric_locked(tm, TCP_METRIC_SSTHRESH))
tcp_metric_set(tm, TCP_METRIC_SSTHRESH,
max(tcp_snd_cwnd(tp) >> 1, tp->snd_ssthresh));
@@ -418,7 +418,7 @@ void tcp_update_metrics(struct sock *sk)
tcp_metric_set(tm, TCP_METRIC_CWND,
(val + tp->snd_ssthresh) >> 1);
}
- if (!net->ipv4.sysctl_tcp_no_ssthresh_metrics_save &&
+ if (!READ_ONCE(net->ipv4.sysctl_tcp_no_ssthresh_metrics_save) &&
!tcp_metric_locked(tm, TCP_METRIC_SSTHRESH)) {
val = tcp_metric_get(tm, TCP_METRIC_SSTHRESH);
if (val && tp->snd_ssthresh > val)
@@ -463,7 +463,7 @@ void tcp_init_metrics(struct sock *sk)
if (tcp_metric_locked(tm, TCP_METRIC_CWND))
tp->snd_cwnd_clamp = tcp_metric_get(tm, TCP_METRIC_CWND);
- val = net->ipv4.sysctl_tcp_no_ssthresh_metrics_save ?
+ val = READ_ONCE(net->ipv4.sysctl_tcp_no_ssthresh_metrics_save) ?
0 : tcp_metric_get(tm, TCP_METRIC_SSTHRESH);
if (val) {
tp->snd_ssthresh = val;
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 07/15] tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (5 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 06/15] tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 08/15] tcp: Fix data-races around sysctl_tcp_workaround_signed_windows Kuniyuki Iwashima
` (9 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_moderate_rcvbuf, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_input.c | 2 +-
net/mptcp/protocol.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index af376d7423d1..debfff94f3af 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -724,7 +724,7 @@ void tcp_rcv_space_adjust(struct sock *sk)
* <prev RTT . ><current RTT .. ><next RTT .... >
*/
- if (sock_net(sk)->ipv4.sysctl_tcp_moderate_rcvbuf &&
+ if (READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_moderate_rcvbuf) &&
!(sk->sk_userlocks & SOCK_RCVBUF_LOCK)) {
int rcvmem, rcvbuf;
u64 rcvwin, grow;
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 21a3ed64226e..9bbd8cbe0acb 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -1908,7 +1908,7 @@ static void mptcp_rcv_space_adjust(struct mptcp_sock *msk, int copied)
if (msk->rcvq_space.copied <= msk->rcvq_space.space)
goto new_measure;
- if (sock_net(sk)->ipv4.sysctl_tcp_moderate_rcvbuf &&
+ if (READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_moderate_rcvbuf) &&
!(sk->sk_userlocks & SOCK_RCVBUF_LOCK)) {
int rcvmem, rcvbuf;
u64 rcvwin, grow;
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 08/15] tcp: Fix data-races around sysctl_tcp_workaround_signed_windows.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (6 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 07/15] tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 09/15] tcp: Fix a data-race around sysctl_tcp_limit_output_bytes Kuniyuki Iwashima
` (8 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev, Rick Jones
While reading sysctl_tcp_workaround_signed_windows, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its readers.
Fixes: 15d99e02baba ("[TCP]: sysctl to allow TCP window > 32767 sans wscale")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
CC: Rick Jones <rick.jones2@hp.com>
---
net/ipv4/tcp_output.c | 4 ++--
net/mptcp/options.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index c38e07b50639..88f7d51e6691 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -230,7 +230,7 @@ void tcp_select_initial_window(const struct sock *sk, int __space, __u32 mss,
* which we interpret as a sign the remote TCP is not
* misinterpreting the window field as a signed quantity.
*/
- if (sock_net(sk)->ipv4.sysctl_tcp_workaround_signed_windows)
+ if (READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_workaround_signed_windows))
(*rcv_wnd) = min(space, MAX_TCP_WINDOW);
else
(*rcv_wnd) = min_t(u32, space, U16_MAX);
@@ -285,7 +285,7 @@ static u16 tcp_select_window(struct sock *sk)
* scaled window.
*/
if (!tp->rx_opt.rcv_wscale &&
- sock_net(sk)->ipv4.sysctl_tcp_workaround_signed_windows)
+ READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_workaround_signed_windows))
new_win = min(new_win, MAX_TCP_WINDOW);
else
new_win = min(new_win, (65535U << tp->rx_opt.rcv_wscale));
diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index bd8f0f425be4..30d289044e71 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -1271,7 +1271,7 @@ static void mptcp_set_rwin(struct tcp_sock *tp, struct tcphdr *th)
if (unlikely(th->syn))
new_win = min(new_win, 65535U) << tp->rx_opt.rcv_wscale;
if (!tp->rx_opt.rcv_wscale &&
- sock_net(ssk)->ipv4.sysctl_tcp_workaround_signed_windows)
+ READ_ONCE(sock_net(ssk)->ipv4.sysctl_tcp_workaround_signed_windows))
new_win = min(new_win, MAX_TCP_WINDOW);
else
new_win = min(new_win, (65535U << tp->rx_opt.rcv_wscale));
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 09/15] tcp: Fix a data-race around sysctl_tcp_limit_output_bytes.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (7 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 08/15] tcp: Fix data-races around sysctl_tcp_workaround_signed_windows Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 10/15] tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit Kuniyuki Iwashima
` (7 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_limit_output_bytes, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its reader.
Fixes: 46d3ceabd8d9 ("tcp: TCP Small Queues")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 88f7d51e6691..80c9bed73337 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2507,7 +2507,7 @@ static bool tcp_small_queue_check(struct sock *sk, const struct sk_buff *skb,
sk->sk_pacing_rate >> READ_ONCE(sk->sk_pacing_shift));
if (sk->sk_pacing_status == SK_PACING_NONE)
limit = min_t(unsigned long, limit,
- sock_net(sk)->ipv4.sysctl_tcp_limit_output_bytes);
+ READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_limit_output_bytes));
limit <<= factor;
if (static_branch_unlikely(&tcp_tx_delay_enabled) &&
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 10/15] tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (8 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 09/15] tcp: Fix a data-race around sysctl_tcp_limit_output_bytes Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 11/15] tcp: Fix a data-race around sysctl_tcp_min_tso_segs Kuniyuki Iwashima
` (6 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_challenge_ack_limit, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its reader.
Fixes: 282f23c6ee34 ("tcp: implement RFC 5961 3.2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index debfff94f3af..d386a69b1c05 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3629,7 +3629,7 @@ static void tcp_send_challenge_ack(struct sock *sk)
/* Then check host-wide RFC 5961 rate limit. */
now = jiffies / HZ;
if (now != challenge_timestamp) {
- u32 ack_limit = net->ipv4.sysctl_tcp_challenge_ack_limit;
+ u32 ack_limit = READ_ONCE(net->ipv4.sysctl_tcp_challenge_ack_limit);
u32 half = (ack_limit + 1) >> 1;
challenge_timestamp = now;
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 11/15] tcp: Fix a data-race around sysctl_tcp_min_tso_segs.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (9 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 10/15] tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 12/15] tcp: Fix a data-race around sysctl_tcp_tso_rtt_log Kuniyuki Iwashima
` (5 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_min_tso_segs, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 95bd09eb2750 ("tcp: TSO packets automatic sizing")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 80c9bed73337..6e29cf391a64 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -1995,7 +1995,7 @@ static u32 tcp_tso_segs(struct sock *sk, unsigned int mss_now)
min_tso = ca_ops->min_tso_segs ?
ca_ops->min_tso_segs(sk) :
- sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs;
+ READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs);
tso_segs = tcp_tso_autosize(sk, mss_now, min_tso);
return min_t(u32, tso_segs, sk->sk_gso_max_segs);
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 12/15] tcp: Fix a data-race around sysctl_tcp_tso_rtt_log.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (10 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 11/15] tcp: Fix a data-race around sysctl_tcp_min_tso_segs Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 13/15] tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen Kuniyuki Iwashima
` (4 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_tso_rtt_log, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 65466904b015 ("tcp: adjust TSO packet sizes based on min_rtt")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp_output.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 6e29cf391a64..cf6713c9567e 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -1976,7 +1976,7 @@ static u32 tcp_tso_autosize(const struct sock *sk, unsigned int mss_now,
bytes = sk->sk_pacing_rate >> READ_ONCE(sk->sk_pacing_shift);
- r = tcp_min_rtt(tcp_sk(sk)) >> sock_net(sk)->ipv4.sysctl_tcp_tso_rtt_log;
+ r = tcp_min_rtt(tcp_sk(sk)) >> READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_tso_rtt_log);
if (r < BITS_PER_TYPE(sk->sk_gso_max_size))
bytes += sk->sk_gso_max_size >> r;
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 13/15] tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (11 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 12/15] tcp: Fix a data-race around sysctl_tcp_tso_rtt_log Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 14/15] tcp: Fix a data-race around sysctl_tcp_autocorking Kuniyuki Iwashima
` (3 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev, Yuchung Cheng
While reading sysctl_tcp_min_rtt_wlen, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: f672258391b4 ("tcp: track min RTT using windowed min-filter")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
CC: Yuchung Cheng <ycheng@google.com>
---
net/ipv4/tcp_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index d386a69b1c05..96d11f8ab729 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3058,7 +3058,7 @@ static void tcp_fastretrans_alert(struct sock *sk, const u32 prior_snd_una,
static void tcp_update_rtt_min(struct sock *sk, u32 rtt_us, const int flag)
{
- u32 wlen = sock_net(sk)->ipv4.sysctl_tcp_min_rtt_wlen * HZ;
+ u32 wlen = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_min_rtt_wlen) * HZ;
struct tcp_sock *tp = tcp_sk(sk);
if ((flag & FLAG_ACK_MAYBE_DELAYED) && rtt_us > tcp_min_rtt(tp)) {
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 14/15] tcp: Fix a data-race around sysctl_tcp_autocorking.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (12 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 13/15] tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 15/15] tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit Kuniyuki Iwashima
` (2 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev
While reading sysctl_tcp_autocorking, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: f54b311142a9 ("tcp: auto corking")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 2faaaaf540ac..a11e5de3a4c3 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -686,7 +686,7 @@ static bool tcp_should_autocork(struct sock *sk, struct sk_buff *skb,
int size_goal)
{
return skb->len < size_goal &&
- sock_net(sk)->ipv4.sysctl_tcp_autocorking &&
+ READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_autocorking) &&
!tcp_rtx_queue_empty(sk) &&
refcount_read(&sk->sk_wmem_alloc) > skb->truesize &&
tcp_skb_can_collapse_to(skb);
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v1 net 15/15] tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (13 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 14/15] tcp: Fix a data-race around sysctl_tcp_autocorking Kuniyuki Iwashima
@ 2022-07-20 16:50 ` Kuniyuki Iwashima
2022-07-20 17:17 ` [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Eric Dumazet
2022-07-22 11:10 ` patchwork-bot+netdevbpf
16 siblings, 0 replies; 18+ messages in thread
From: Kuniyuki Iwashima @ 2022-07-20 16:50 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, David Ahern
Cc: Kuniyuki Iwashima, Kuniyuki Iwashima, netdev, Neal Cardwell
While reading sysctl_tcp_invalid_ratelimit, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its reader.
Fixes: 032ee4236954 ("tcp: helpers to mitigate ACK loops by rate-limiting out-of-window dupacks")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
CC: Neal Cardwell <ncardwell@google.com>
---
net/ipv4/tcp_input.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 96d11f8ab729..c799f39cb774 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3581,7 +3581,8 @@ static bool __tcp_oow_rate_limited(struct net *net, int mib_idx,
if (*last_oow_ack_time) {
s32 elapsed = (s32)(tcp_jiffies32 - *last_oow_ack_time);
- if (0 <= elapsed && elapsed < net->ipv4.sysctl_tcp_invalid_ratelimit) {
+ if (0 <= elapsed &&
+ elapsed < READ_ONCE(net->ipv4.sysctl_tcp_invalid_ratelimit)) {
NET_INC_STATS(net, mib_idx);
return true; /* rate-limited: don't send yet! */
}
--
2.30.2
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5).
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (14 preceding siblings ...)
2022-07-20 16:50 ` [PATCH v1 net 15/15] tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit Kuniyuki Iwashima
@ 2022-07-20 17:17 ` Eric Dumazet
2022-07-22 11:10 ` patchwork-bot+netdevbpf
16 siblings, 0 replies; 18+ messages in thread
From: Eric Dumazet @ 2022-07-20 17:17 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, David Ahern,
Kuniyuki Iwashima, netdev
On Wed, Jul 20, 2022 at 6:53 PM Kuniyuki Iwashima <kuniyu@amazon.com> wrote:
>
> This series fixes data-races around 15 knobs after tcp_dsack in
> ipv4_net_table.
>
> tcp_tso_win_divisor was skipped because it already uses READ_ONCE().
>
> So, the final round for ipv4_net_table will start with tcp_pacing_ss_ratio.
>
>
For the series:
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5).
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
` (15 preceding siblings ...)
2022-07-20 17:17 ` [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Eric Dumazet
@ 2022-07-22 11:10 ` patchwork-bot+netdevbpf
16 siblings, 0 replies; 18+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-22 11:10 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: davem, edumazet, kuba, pabeni, dsahern, kuni1840, netdev
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 20 Jul 2022 09:50:11 -0700 you wrote:
> This series fixes data-races around 15 knobs after tcp_dsack in
> ipv4_net_table.
>
> tcp_tso_win_divisor was skipped because it already uses READ_ONCE().
>
> So, the final round for ipv4_net_table will start with tcp_pacing_ss_ratio.
>
> [...]
Here is the summary with links:
- [v1,net,01/15] tcp: Fix data-races around sysctl_tcp_dsack.
https://git.kernel.org/netdev/net/c/58ebb1c8b35a
- [v1,net,02/15] tcp: Fix a data-race around sysctl_tcp_app_win.
https://git.kernel.org/netdev/net/c/02ca527ac558
- [v1,net,03/15] tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
https://git.kernel.org/netdev/net/c/36eeee75ef01
- [v1,net,04/15] tcp: Fix a data-race around sysctl_tcp_frto.
https://git.kernel.org/netdev/net/c/706c6202a358
- [v1,net,05/15] tcp: Fix a data-race around sysctl_tcp_nometrics_save.
https://git.kernel.org/netdev/net/c/8499a2454d9e
- [v1,net,06/15] tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.
https://git.kernel.org/netdev/net/c/ab1ba21b523a
- [v1,net,07/15] tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.
https://git.kernel.org/netdev/net/c/780476488844
- [v1,net,08/15] tcp: Fix data-races around sysctl_tcp_workaround_signed_windows.
https://git.kernel.org/netdev/net/c/0f1e4d06591d
- [v1,net,09/15] tcp: Fix a data-race around sysctl_tcp_limit_output_bytes.
https://git.kernel.org/netdev/net/c/9fb90193fbd6
- [v1,net,10/15] tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit.
https://git.kernel.org/netdev/net/c/db3815a2fa69
- [v1,net,11/15] tcp: Fix a data-race around sysctl_tcp_min_tso_segs.
https://git.kernel.org/netdev/net/c/e0bb4ab9dfdd
- [v1,net,12/15] tcp: Fix a data-race around sysctl_tcp_tso_rtt_log.
https://git.kernel.org/netdev/net/c/2455e61b85e9
- [v1,net,13/15] tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen.
https://git.kernel.org/netdev/net/c/1330ffacd05f
- [v1,net,14/15] tcp: Fix a data-race around sysctl_tcp_autocorking.
https://git.kernel.org/netdev/net/c/85225e6f0a76
- [v1,net,15/15] tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.
https://git.kernel.org/netdev/net/c/2afdbe7b8de8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2022-07-22 11:10 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 16:50 [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 01/15] tcp: Fix data-races around sysctl_tcp_dsack Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 02/15] tcp: Fix a data-race around sysctl_tcp_app_win Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 03/15] tcp: Fix a data-race around sysctl_tcp_adv_win_scale Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 04/15] tcp: Fix a data-race around sysctl_tcp_frto Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 05/15] tcp: Fix a data-race around sysctl_tcp_nometrics_save Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 06/15] tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 07/15] tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 08/15] tcp: Fix data-races around sysctl_tcp_workaround_signed_windows Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 09/15] tcp: Fix a data-race around sysctl_tcp_limit_output_bytes Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 10/15] tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 11/15] tcp: Fix a data-race around sysctl_tcp_min_tso_segs Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 12/15] tcp: Fix a data-race around sysctl_tcp_tso_rtt_log Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 13/15] tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 14/15] tcp: Fix a data-race around sysctl_tcp_autocorking Kuniyuki Iwashima
2022-07-20 16:50 ` [PATCH v1 net 15/15] tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit Kuniyuki Iwashima
2022-07-20 17:17 ` [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5) Eric Dumazet
2022-07-22 11:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.