wifi breakage due to commit "wifi: brcmfmac: add support for vendor-specific firmware api"

[Michael Stapelberg <michael+lkml@stapelberg.ch>]

Hey Arend

I recently bisected a user-reported WiFi breakage on the Raspberry Pi
3B+ to your commit
https://github.com/torvalds/linux/commit/d6a5c562214f26e442c8ec3ff1e28e16675d1bcf
https://lore.kernel.org/r/20221129135446.151065-4-arend.vanspriel@broadcom.com

On our end, the issue was reported here:
https://github.com/gokrazy/wifi/issues/3

As of Linux 6.2.6, this seems to still be unfixed, so I wanted to
check in and see if you could take a look please?

Thank you.

Here’s a dmesg diff between the previous commit (da6d9c8ecd00) and the
broken commit (d6a5c562214f):

--- /proc/self/fd/11 2023-03-14 20:28:20.167241380 +0100
+++ /proc/self/fd/12 2023-03-14 20:28:20.167241380 +0100
@@ -1,5 +1,5 @@
  Booting Linux on physical CPU 0x0000000000 [0x410fd034]
- Linux version 6.1.0-rc7-01766-gda6d9c8ecd00 (gokrazy@docker)
(aarch64-linux-gnu-gcc (GCC) 12.2.0, GNU ld (GNU Binutils) 2.39) #81
SMP PREEMPT Wed Mar  1 20:57:29 UTC 2017
+ Linux version 6.1.0-rc7-01767-gd6a5c562214f (gokrazy@docker)
(aarch64-linux-gnu-gcc (GCC) 12.2.0, GNU ld (GNU Binutils) 2.39) #82
SMP PREEMPT Wed Mar  1 20:57:29 UTC 2017
  random: crng init done
  Machine model: Raspberry Pi 3 Model B Plus Rev 1.3
  efi: UEFI not found.
@@ -29,7 +29,7 @@
  Fallback order for Node 0: 0
  Built 1 zonelists, mobility grouping on.  Total pages: 238896
  Policy zone: DMA
- Kernel command line:
video=Composite-1:720x480@60i,margin_left=32,margin_right=32,margin_top=32,margin_bottom=32
dma.dmachans=0x7ff5 bcm2709.boardrev=0xa020d3
bcm2709.serial=0xe33b7b2a bcm2709.uart_clock=48000000
bcm2709.disk_led_gpio=29 bcm2709.disk_led_active_low=0
smsc95xx.macaddr=B8:27:EB:3B:7B:2A vc_mem.mem_base=0x3ec00000
vc_mem.mem_size=0x40000000  console=tty1 console=ttyS0,115200
root=PARTUUID=60c24cc1-f3f9-427a-8199-2e18c40c0001/PARTNROFF=2
init=/gokrazy/init rootwait panic=10 oops=panic
+ Kernel command line:
video=Composite-1:720x480@60i,margin_left=32,margin_right=32,margin_top=32,margin_bottom=32
dma.dmachans=0x7ff5 bcm2709.boardrev=0xa020d3
bcm2709.serial=0xe33b7b2a bcm2709.uart_clock=48000000
bcm2709.disk_led_gpio=29 bcm2709.disk_led_active_low=0
smsc95xx.macaddr=B8:27:EB:3B:7B:2A vc_mem.mem_base=0x3ec00000
vc_mem.mem_size=0x40000000  console=tty1 console=ttyS0,115200
root=PARTUUID=60c24cc1-f3f9-427a-8199-2e18c40c0001/PARTNROFF=1
init=/gokrazy/init rootwait panic=10 oops=panic
  Dentry cache hash table entries: 131072 (order: 8, 1048576 bytes, linear)
  Inode-cache hash table entries: 65536 (order: 7, 524288 bytes, linear)
  mem auto-init: stack:all(zero), heap alloc:off, heap free:off
@@ -245,13 +245,13 @@
  Console: switching to colour dummy device 80x25
  vc4-drm soc:gpu: bound 3f400000.hvs (ops vc4_hvs_ops)
  mmc0: host does not support reading read-only switch, assuming write-enable
- vc4-drm soc:gpu: bound 3f902000.hdmi (ops vc4_hdmi_ops)
  mmc0: new high speed SDHC card at address aaaa
- vc4-drm soc:gpu: bound 3f806000.vec (ops vc4_vec_ops)
+ vc4-drm soc:gpu: bound 3f902000.hdmi (ops vc4_hdmi_ops)
  mmcblk0: mmc0:aaaa SC16G 14.8 GiB
+ vc4-drm soc:gpu: bound 3f806000.vec (ops vc4_vec_ops)
  vc4-drm soc:gpu: bound 3f004000.txp (ops vc4_txp_ops)
- vc4-drm soc:gpu: bound 3f206000.pixelvalve (ops vc4_crtc_ops)
   mmcblk0: p1 p2 p3 p4
+ vc4-drm soc:gpu: bound 3f206000.pixelvalve (ops vc4_crtc_ops)
  vc4-drm soc:gpu: bound 3f207000.pixelvalve (ops vc4_crtc_ops)
  vc4-drm soc:gpu: bound 3f807000.pixelvalve (ops vc4_crtc_ops)
  vc4-drm soc:gpu: bound 3fc00000.v3d (ops vc4_v3d_ops)
@@ -269,11 +269,11 @@
  cfg80211: Loading compiled-in X.509 certificates for regulatory database
  cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
  platform regulatory.0: Direct firmware load for regulatory.db failed
with error -2
- ALSA device list:
  cfg80211: failed to load regulatory.db
-   #0: vc4-hdmi
  mmc1: SDHCI controller on 3f300000.mmc [3f300000.mmc] using PIO
- VFS: Mounted root (squashfs filesystem) readonly on device 179:3.
+ ALSA device list:
+   #0: vc4-hdmi
+ VFS: Mounted root (squashfs filesystem) readonly on device 179:2.
  devtmpfs: mounted
  Freeing unused kernel memory: 9216K
  Run /gokrazy/init as init process
@@ -284,6 +284,7 @@
      TERM=linux
  mmc1: new high speed SDIO card at address 0001
  usb 1-1: new high-speed USB device number 2 using dwc2
+ EXT4-fs (mmcblk0p4): recovery complete
  EXT4-fs (mmcblk0p4): mounted filesystem with ordered data mode.
Quota mode: none.
  hub 1-1:1.0: USB hub found
  hub 1-1:1.0: 4 ports detected
@@ -300,12 +301,14 @@
  Bluetooth: HCI socket layer initialized
  Bluetooth: L2CAP socket layer initialized
  Bluetooth: SCO socket layer initialized
+ brcmfmac: brcmf_fwvid_request_module: mod=wcc: failed -2
+ ieee80211 phy0: brcmf_attach: brcmf_fwvid_attach failed
  Bluetooth: HCI UART driver ver 2.3
+ brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
  Bluetooth: HCI UART protocol H4 registered
  Bluetooth: HCI UART protocol Broadcom registered
  hci_uart_bcm serial0-0: supply vbat not found, using dummy regulator
  hci_uart_bcm serial0-0: supply vddio not found, using dummy regulator
- brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4345/6 wl0: Mar  2
2020 23:30:41 version 7.45.202 (r724630 CY) FWID 01-72f6ece2
  uart-pl011 3f201000.serial: no DMA platform data
  Bluetooth: hci0: BCM: chip id 107
  Bluetooth: hci0: BCM: features 0x2f
@@ -316,7 +319,4 @@
  Bluetooth: hci0: BCM: 'brcm/BCM4345C0.hcd'
  Bluetooth: hci0: BCM: 'brcm/BCM.raspberrypi,3-model-b-plus.hcd'
  Bluetooth: hci0: BCM: 'brcm/BCM.hcd'
- Bluetooth: hci0: unexpected cc 0x1003 length: 1 < 9
- Bluetooth: hci0: Opcode 0x1003 failed: -38
  IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
- IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready