Re: wifi breakage due to commit "wifi: brcmfmac: add support for vendor-specific firmware api"

From: Michael Stapelberg <michael+lkml@stapelberg.ch>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Kalle Valo <kvalo@kernel.org>,
	Franky Lin <franky.lin@broadcom.com>,
	Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	linux-wireless@vger.kernel.org
Subject: Re: wifi breakage due to commit "wifi: brcmfmac: add support for vendor-specific firmware api"
Date: Wed, 15 Mar 2023 08:58:26 +0100	[thread overview]
Message-ID: <CANnVG6n-eqKUQnX_6wncmjG1kyVfhxqs2L82xYQpDmGq89eVAQ@mail.gmail.com> (raw)
In-Reply-To: <186e26dc0a8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>

Hey Arend

Thanks for taking a look.

The brcmfmac-wcc module is present on my installation, but I’m not
currently loading it.
(I only load brcmutil, then brcmfmac.)

But, even if I load it, the wlan0 interface still doesn’t show up.

In the modules.dep, I see that brcmfmac-wcc should be loaded after
brcmutil and brcmfmac.
Is that accurate?

My installation is somewhat unusual in that I use a custom userland
(see https://gokrazy.org/).

Thanks
Best regards
Michael

On Wed, 15 Mar 2023 at 00:21, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
> On March 14, 2023 11:49:05 PM Michael Stapelberg
> <michael+lkml@stapelberg.ch> wrote:
>
> > Of course, find it attached. Thanks.
>
> Strange. Could it be there is some build config needed to install the
> additional kernel modules (brcmfmac-wcc.ko, etc.) on RPi image?
>
> Regards,
> Arend
>
> >
> > On Tue, 14 Mar 2023 at 23:26, Arend Van Spriel
> > <arend.vanspriel@broadcom.com> wrote:
> >>
> >> On March 14, 2023 8:39:05 PM Michael Stapelberg
> >> <michael+lkml@stapelberg.ch> wrote:
> >>
> >>> Hey Arend
> >>>
> >>> I recently bisected a user-reported WiFi breakage on the Raspberry Pi
> >>> 3B+ to your commit
> >>> https://github.com/torvalds/linux/commit/d6a5c562214f26e442c8ec3ff1e28e16675d1bcf
> >>> https://lore.kernel.org/r/20221129135446.151065-4-arend.vanspriel@broadcom.com
> >>>
> >>> On our end, the issue was reported here:
> >>> https://github.com/gokrazy/wifi/issues/3
> >>>
> >>> As of Linux 6.2.6, this seems to still be unfixed, so I wanted to
> >>> check in and see if you could take a look please?
> >>
> >> I have a suspicion, but can you provide the kernel .config file so I can
> >> see if I am on the right track.
> >>
> >>> + brcmfmac: brcmf_fwvid_request_module: mod=wcc: failed -2
> >>> + ieee80211 phy0: brcmf_attach: brcmf_fwvid_attach failed
> >>> + brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
> >>
> >> Regards,
> >> Arend
>
>
>