* arch/riscv/net/bpf_jit_comp64.c build error
@ 2023-04-18 10:17 ` Aleksandr Nogikh
0 siblings, 0 replies; 4+ messages in thread
From: Aleksandr Nogikh @ 2023-04-18 10:17 UTC (permalink / raw)
To: pulehui; +Cc: linux-riscv, LKML, syzkaller, Dmitry Vyukov
Hi Pu Lehui,
I'm writing to you regarding your following patch.
Author: Pu Lehui <pulehui@huawei.com>
Date: Wed Feb 15 21:52:04 2023 +0800
riscv, bpf: Add bpf_arch_text_poke support for RV64
When trying to compile the "fixes" branch of the
"git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git" tree,
syzbot gets the following error:
arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
arch/riscv/net/bpf_jit_comp64.c:691:9: error: implicit declaration of
function 'patch_text'; did you mean 'path_get'?
[-Werror=implicit-function-declaration]
691 | ret = patch_text(ip, new_insns, ninsns);
| ^~~~~~~~~~
| path_get
FWIW the compiler is riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1
20210110, GNU ld (GNU Binutils for Debian) 2.35.2.
Could you please take a look?
Best Regards,
Aleksandr
^ permalink raw reply [flat|nested] 4+ messages in thread
* arch/riscv/net/bpf_jit_comp64.c build error
@ 2023-04-18 10:17 ` Aleksandr Nogikh
0 siblings, 0 replies; 4+ messages in thread
From: Aleksandr Nogikh @ 2023-04-18 10:17 UTC (permalink / raw)
To: pulehui; +Cc: linux-riscv, LKML, syzkaller, Dmitry Vyukov
Hi Pu Lehui,
I'm writing to you regarding your following patch.
Author: Pu Lehui <pulehui@huawei.com>
Date: Wed Feb 15 21:52:04 2023 +0800
riscv, bpf: Add bpf_arch_text_poke support for RV64
When trying to compile the "fixes" branch of the
"git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git" tree,
syzbot gets the following error:
arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
arch/riscv/net/bpf_jit_comp64.c:691:9: error: implicit declaration of
function 'patch_text'; did you mean 'path_get'?
[-Werror=implicit-function-declaration]
691 | ret = patch_text(ip, new_insns, ninsns);
| ^~~~~~~~~~
| path_get
FWIW the compiler is riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1
20210110, GNU ld (GNU Binutils for Debian) 2.35.2.
Could you please take a look?
Best Regards,
Aleksandr
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: arch/riscv/net/bpf_jit_comp64.c build error
2023-04-18 10:17 ` Aleksandr Nogikh
@ 2023-04-18 11:54 ` Björn Töpel
-1 siblings, 0 replies; 4+ messages in thread
From: Björn Töpel @ 2023-04-18 11:54 UTC (permalink / raw)
To: Aleksandr Nogikh, pulehui, bpf
Cc: linux-riscv, LKML, syzkaller, Dmitry Vyukov, Daniel Borkmann,
Alexei Starovoitov
Aleksandr Nogikh <nogikh@google.com> writes:
> Hi Pu Lehui,
>
> I'm writing to you regarding your following patch.
>
> Author: Pu Lehui <pulehui@huawei.com>
> Date: Wed Feb 15 21:52:04 2023 +0800
>
> riscv, bpf: Add bpf_arch_text_poke support for RV64
>
> When trying to compile the "fixes" branch of the
> "git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git" tree,
> syzbot gets the following error:
>
> arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
> arch/riscv/net/bpf_jit_comp64.c:691:9: error: implicit declaration of
> function 'patch_text'; did you mean 'path_get'?
> [-Werror=implicit-function-declaration]
> 691 | ret = patch_text(ip, new_insns, ninsns);
> | ^~~~~~~~~~
> | path_get
>
> FWIW the compiler is riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1
> 20210110, GNU ld (GNU Binutils for Debian) 2.35.2.
>
> Could you please take a look?
Randy sent a fix for this [1], which went in via the BPF tree. Pull in
commit 2d311f480b52 ("riscv, bpf: Fix patch_text implicit declaration").
Björn
[1] https://lore.kernel.org/linux-riscv/20230227072016.14618-1-rdunlap@infradead.org/
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: arch/riscv/net/bpf_jit_comp64.c build error
@ 2023-04-18 11:54 ` Björn Töpel
0 siblings, 0 replies; 4+ messages in thread
From: Björn Töpel @ 2023-04-18 11:54 UTC (permalink / raw)
To: Aleksandr Nogikh, pulehui, bpf
Cc: linux-riscv, LKML, syzkaller, Dmitry Vyukov, Daniel Borkmann,
Alexei Starovoitov
Aleksandr Nogikh <nogikh@google.com> writes:
> Hi Pu Lehui,
>
> I'm writing to you regarding your following patch.
>
> Author: Pu Lehui <pulehui@huawei.com>
> Date: Wed Feb 15 21:52:04 2023 +0800
>
> riscv, bpf: Add bpf_arch_text_poke support for RV64
>
> When trying to compile the "fixes" branch of the
> "git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git" tree,
> syzbot gets the following error:
>
> arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
> arch/riscv/net/bpf_jit_comp64.c:691:9: error: implicit declaration of
> function 'patch_text'; did you mean 'path_get'?
> [-Werror=implicit-function-declaration]
> 691 | ret = patch_text(ip, new_insns, ninsns);
> | ^~~~~~~~~~
> | path_get
>
> FWIW the compiler is riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1
> 20210110, GNU ld (GNU Binutils for Debian) 2.35.2.
>
> Could you please take a look?
Randy sent a fix for this [1], which went in via the BPF tree. Pull in
commit 2d311f480b52 ("riscv, bpf: Fix patch_text implicit declaration").
Björn
[1] https://lore.kernel.org/linux-riscv/20230227072016.14618-1-rdunlap@infradead.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-18 11:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-18 10:17 arch/riscv/net/bpf_jit_comp64.c build error Aleksandr Nogikh
2023-04-18 10:17 ` Aleksandr Nogikh
2023-04-18 11:54 ` Björn Töpel
2023-04-18 11:54 ` Björn Töpel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.