From: Marco Elver <elver@google.com> To: Will Deacon <will@kernel.org>, Alexander Potapenko <glider@google.com>, Andrew Morton <akpm@linux-foundation.org> Cc: "H. Peter Anvin" <hpa@zytor.com>, "Paul E. McKenney" <paulmck@kernel.org>, Andrey Konovalov <andreyknvl@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>, Catalin Marinas <catalin.marinas@arm.com>, Christoph Lameter <cl@linux.com>, Dave Hansen <dave.hansen@linux.intel.com>, David Rientjes <rientjes@google.com>, Dmitry Vyukov <dvyukov@google.com>, Eric Dumazet <edumazet@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Hillf Danton <hdanton@sina.com>, Ingo Molnar <mingo@redhat.com>, Jann Horn <jannh@google.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Jonathan Corbet <corbet@lwn.net>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Kees Cook <keescook@chromium.org>, Mark Rutland <mark.rutland@arm.com>, Pekka Enberg <penberg@kernel.org>, Peter Zijlstra <peterz@infradead.org>, SeongJae Park <sjpark@amazon.com>, Thomas Gleixner <tglx@linutronix.de>, Vlastimil Babka <vbabka@suse.cz>, "the arch/x86 maintainers" <x86@kernel.org>, "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Memory Management List <linux-mm@kvack.org> Subject: Re: [PATCH v3 03/10] arm64, kfence: enable KFENCE for ARM64 Date: Mon, 28 Sep 2020 13:53:55 +0200 [thread overview] Message-ID: <CANpmjNMS-6mfDF6o31yiejP0wmgpEeuoh0PP9QJa-qt0OpiRBg@mail.gmail.com> (raw) In-Reply-To: <20200921143059.GO2139@willie-the-truck> On Mon, 21 Sep 2020 at 16:31, Will Deacon <will@kernel.org> wrote: > On Mon, Sep 21, 2020 at 03:26:04PM +0200, Marco Elver wrote: > > Add architecture specific implementation details for KFENCE and enable > > KFENCE for the arm64 architecture. In particular, this implements the > > required interface in <asm/kfence.h>. Currently, the arm64 version does > > not yet use a statically allocated memory pool, at the cost of a pointer > > load for each is_kfence_address(). [...] > > For ARM64, we would like to solicit feedback on what the best option is > > to obtain a constant address for __kfence_pool. One option is to declare > > a memory range in the memory layout to be dedicated to KFENCE (like is > > done for KASAN), however, it is unclear if this is the best available > > option. We would like to avoid touching the memory layout. > Given that the pool is relatively small (i.e. when compared with our virtual > address space), dedicating an area of virtual space sounds like it makes > the most sense here. How early do you need it to be available? Note: we're going to send a v4 this or next week with a few other minor fixes in it. But I think we just don't want to block the entire series on figuring out what the static-pool arm64 version should do, especially if we'll have a few iterations with only this patch here changing. So the plan will be: 1. Send v4, which could from our point-of-view be picked up for merging. Unless of course there are more comments. 2. Work out the details for the static-pool arm64 version, since it doesn't seem trivial to do the same thing as we do for x86. In preparation for that, v4 will allow the __kfence_pool's attributes to be defined entirely by <asm/kfence.h>, so that we can fiddle with sections etc. 3. Send patch switching out the simpler arm64 version here for one that places __kfence_pool at a static location. Hopefully that plan is reasonable. Thanks, -- Marco
WARNING: multiple messages have this Message-ID (diff)
From: Marco Elver <elver@google.com> To: Will Deacon <will@kernel.org>, Alexander Potapenko <glider@google.com>, Andrew Morton <akpm@linux-foundation.org> Cc: Mark Rutland <mark.rutland@arm.com>, Hillf Danton <hdanton@sina.com>, "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>, Catalin Marinas <catalin.marinas@arm.com>, Dave Hansen <dave.hansen@linux.intel.com>, Linux Memory Management List <linux-mm@kvack.org>, Eric Dumazet <edumazet@google.com>, "H. Peter Anvin" <hpa@zytor.com>, Christoph Lameter <cl@linux.com>, SeongJae Park <sjpark@amazon.com>, Jonathan Corbet <corbet@lwn.net>, the arch/x86 maintainers <x86@kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, Ingo Molnar <mingo@redhat.com>, Vlastimil Babka <vbabka@suse.cz>, David Rientjes <rientjes@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Kees Cook <keescook@chromium.org>, "Paul E. McKenney" <paulmck@kernel.org>, Jann Horn <jannh@google.com>, Andrey Konovalov <andreyknvl@google.com>, Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Thomas Gleixner <tglx@linutronix.de>, Dmitry Vyukov <dvyukov@google.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, LKML <linux-kernel@vger.kernel.org>, Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com> Subject: Re: [PATCH v3 03/10] arm64, kfence: enable KFENCE for ARM64 Date: Mon, 28 Sep 2020 13:53:55 +0200 [thread overview] Message-ID: <CANpmjNMS-6mfDF6o31yiejP0wmgpEeuoh0PP9QJa-qt0OpiRBg@mail.gmail.com> (raw) In-Reply-To: <20200921143059.GO2139@willie-the-truck> On Mon, 21 Sep 2020 at 16:31, Will Deacon <will@kernel.org> wrote: > On Mon, Sep 21, 2020 at 03:26:04PM +0200, Marco Elver wrote: > > Add architecture specific implementation details for KFENCE and enable > > KFENCE for the arm64 architecture. In particular, this implements the > > required interface in <asm/kfence.h>. Currently, the arm64 version does > > not yet use a statically allocated memory pool, at the cost of a pointer > > load for each is_kfence_address(). [...] > > For ARM64, we would like to solicit feedback on what the best option is > > to obtain a constant address for __kfence_pool. One option is to declare > > a memory range in the memory layout to be dedicated to KFENCE (like is > > done for KASAN), however, it is unclear if this is the best available > > option. We would like to avoid touching the memory layout. > Given that the pool is relatively small (i.e. when compared with our virtual > address space), dedicating an area of virtual space sounds like it makes > the most sense here. How early do you need it to be available? Note: we're going to send a v4 this or next week with a few other minor fixes in it. But I think we just don't want to block the entire series on figuring out what the static-pool arm64 version should do, especially if we'll have a few iterations with only this patch here changing. So the plan will be: 1. Send v4, which could from our point-of-view be picked up for merging. Unless of course there are more comments. 2. Work out the details for the static-pool arm64 version, since it doesn't seem trivial to do the same thing as we do for x86. In preparation for that, v4 will allow the __kfence_pool's attributes to be defined entirely by <asm/kfence.h>, so that we can fiddle with sections etc. 3. Send patch switching out the simpler arm64 version here for one that places __kfence_pool at a static location. Hopefully that plan is reasonable. Thanks, -- Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-28 11:54 UTC|newest] Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-21 13:26 [PATCH v3 00/10] KFENCE: A low-overhead sampling-based memory safety error detector Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` [PATCH v3 01/10] mm: add Kernel Electric-Fence infrastructure Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-25 11:23 ` SeongJae Park 2020-09-25 11:23 ` SeongJae Park 2020-09-25 11:31 ` Marco Elver 2020-09-25 11:31 ` Marco Elver 2020-09-25 11:31 ` Marco Elver 2020-09-29 12:42 ` Andrey Konovalov 2020-09-29 12:42 ` Andrey Konovalov 2020-09-29 12:42 ` Andrey Konovalov 2020-09-29 13:11 ` Marco Elver 2020-09-29 13:11 ` Marco Elver 2020-09-29 13:48 ` Andrey Konovalov 2020-09-29 13:48 ` Andrey Konovalov 2020-09-29 13:48 ` Andrey Konovalov 2020-09-29 13:49 ` Marco Elver 2020-09-29 13:49 ` Marco Elver 2020-09-29 13:49 ` Marco Elver 2020-09-29 14:01 ` Andrey Konovalov 2020-09-29 14:01 ` Andrey Konovalov 2020-09-29 14:01 ` Andrey Konovalov 2020-09-29 14:24 ` Mark Rutland 2020-09-29 14:24 ` Mark Rutland 2020-09-29 14:51 ` Marco Elver 2020-09-29 14:51 ` Marco Elver 2020-09-29 14:51 ` Marco Elver 2020-09-29 15:05 ` Mark Rutland 2020-09-29 15:05 ` Mark Rutland 2020-10-05 16:00 ` Alexander Potapenko 2020-10-05 16:00 ` Alexander Potapenko 2020-10-05 16:00 ` Alexander Potapenko 2020-10-05 16:49 ` Jann Horn 2020-10-05 16:49 ` Jann Horn 2020-10-05 16:49 ` Jann Horn 2020-09-29 15:51 ` Alexander Potapenko 2020-09-29 15:51 ` Alexander Potapenko 2020-09-29 15:51 ` Alexander Potapenko 2020-10-01 18:11 ` Mark Rutland 2020-10-01 18:11 ` Mark Rutland 2020-09-21 13:26 ` [PATCH v3 02/10] x86, kfence: enable KFENCE for x86 Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` [PATCH v3 03/10] arm64, kfence: enable KFENCE for ARM64 Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 14:31 ` Will Deacon 2020-09-21 14:31 ` Will Deacon 2020-09-21 14:58 ` Alexander Potapenko 2020-09-21 14:58 ` Alexander Potapenko 2020-09-21 14:58 ` Alexander Potapenko 2020-09-21 15:37 ` Alexander Potapenko 2020-09-21 15:37 ` Alexander Potapenko 2020-09-21 15:37 ` Alexander Potapenko 2020-09-21 17:43 ` Will Deacon 2020-09-21 17:43 ` Will Deacon 2020-09-22 9:56 ` Marco Elver 2020-09-22 9:56 ` Marco Elver 2020-09-22 9:56 ` Marco Elver 2020-09-29 13:53 ` Mark Rutland 2020-09-29 13:53 ` Mark Rutland 2020-09-29 16:52 ` Alexander Potapenko 2020-09-29 16:52 ` Alexander Potapenko 2020-09-29 16:52 ` Alexander Potapenko 2020-09-25 15:25 ` Alexander Potapenko 2020-09-25 15:25 ` Alexander Potapenko 2020-09-25 15:25 ` Alexander Potapenko 2020-09-29 14:02 ` Mark Rutland 2020-09-29 14:02 ` Mark Rutland 2020-10-01 11:24 ` Alexander Potapenko 2020-10-01 11:24 ` Alexander Potapenko 2020-10-01 11:24 ` Alexander Potapenko 2020-10-01 17:57 ` Mark Rutland 2020-10-01 17:57 ` Mark Rutland 2020-10-08 9:40 ` Marco Elver 2020-10-08 9:40 ` Marco Elver 2020-10-08 9:40 ` Marco Elver 2020-10-08 10:45 ` Mark Rutland 2020-10-08 10:45 ` Mark Rutland 2020-10-14 19:12 ` Marco Elver 2020-10-14 19:12 ` Marco Elver 2020-10-14 19:12 ` Marco Elver 2020-10-15 13:39 ` Mark Rutland 2020-10-15 13:39 ` Mark Rutland 2020-10-15 14:15 ` Marco Elver 2020-10-15 14:15 ` Marco Elver 2020-10-15 14:15 ` Marco Elver 2020-09-28 11:53 ` Marco Elver [this message] 2020-09-28 11:53 ` Marco Elver 2020-09-28 11:53 ` Marco Elver 2020-09-29 14:27 ` Mark Rutland 2020-09-29 14:27 ` Mark Rutland 2020-09-29 17:04 ` Alexander Potapenko 2020-09-29 17:04 ` Alexander Potapenko 2020-09-29 17:04 ` Alexander Potapenko 2020-09-21 13:26 ` [PATCH v3 04/10] mm, kfence: insert KFENCE hooks for SLAB Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` [PATCH v3 05/10] mm, kfence: insert KFENCE hooks for SLUB Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` [PATCH v3 06/10] kfence, kasan: make KFENCE compatible with KASAN Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-29 12:20 ` Andrey Konovalov 2020-09-29 12:20 ` Andrey Konovalov 2020-09-29 12:20 ` Andrey Konovalov 2020-09-29 13:13 ` Alexander Potapenko 2020-09-29 13:13 ` Alexander Potapenko 2020-09-29 13:13 ` Alexander Potapenko 2020-09-21 13:26 ` [PATCH v3 07/10] kfence, kmemleak: make KFENCE compatible with KMEMLEAK Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` [PATCH v3 08/10] kfence, lockdep: make KFENCE compatible with lockdep Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` [PATCH v3 09/10] kfence, Documentation: add KFENCE documentation Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` [PATCH v3 10/10] kfence: add test suite Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 13:26 ` Marco Elver 2020-09-21 17:13 ` Paul E. McKenney 2020-09-21 17:13 ` Paul E. McKenney 2020-09-21 17:37 ` Marco Elver 2020-09-21 17:37 ` Marco Elver 2020-09-21 17:37 ` Marco Elver 2020-09-21 17:48 ` Paul E. McKenney 2020-09-21 17:48 ` Paul E. McKenney 2020-09-21 13:38 ` [PATCH v3 00/10] KFENCE: A low-overhead sampling-based memory safety error detector Dmitry Vyukov 2020-09-21 13:38 ` Dmitry Vyukov 2020-09-21 13:38 ` Dmitry Vyukov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANpmjNMS-6mfDF6o31yiejP0wmgpEeuoh0PP9QJa-qt0OpiRBg@mail.gmail.com \ --to=elver@google.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=cl@linux.com \ --cc=corbet@lwn.net \ --cc=dave.hansen@linux.intel.com \ --cc=dvyukov@google.com \ --cc=edumazet@google.com \ --cc=glider@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdanton@sina.com \ --cc=hpa@zytor.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=jannh@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=keescook@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@kernel.org \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=paulmck@kernel.org \ --cc=penberg@kernel.org \ --cc=peterz@infradead.org \ --cc=rientjes@google.com \ --cc=sjpark@amazon.com \ --cc=tglx@linutronix.de \ --cc=vbabka@suse.cz \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.