All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus'
@ 2015-06-02 15:48 Sergei Zviagintsev
  2015-06-03 10:32 ` David Herrmann
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Zviagintsev @ 2015-06-02 15:48 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Daniel Mack, David Herrmann, Djalal Harouni
  Cc: linux-kernel, Sergei Zviagintsev

Local `bus' is already set to `conn->ep->bus'. Use it.

Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
---
 ipc/kdbus/connection.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
index b00872edbbc9..b9f13749a748 100644
--- a/ipc/kdbus/connection.c
+++ b/ipc/kdbus/connection.c
@@ -432,7 +432,7 @@ static int kdbus_conn_connect(struct kdbus_conn *conn, const char *name)
 	 * directly, and won't cause any notifications.
 	 */
 	if (!kdbus_conn_is_monitor(conn)) {
-		ret = kdbus_notify_id_change(conn->ep->bus, KDBUS_ITEM_ID_ADD,
+		ret = kdbus_notify_id_change(bus, KDBUS_ITEM_ID_ADD,
 					     conn->id, conn->flags);
 		if (ret < 0)
 			goto exit_disconnect;
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus'
  2015-06-02 15:48 [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus' Sergei Zviagintsev
@ 2015-06-03 10:32 ` David Herrmann
  0 siblings, 0 replies; 2+ messages in thread
From: David Herrmann @ 2015-06-03 10:32 UTC (permalink / raw)
  To: Sergei Zviagintsev
  Cc: Greg Kroah-Hartman, Daniel Mack, David Herrmann, Djalal Harouni,
	linux-kernel

Hi

On Tue, Jun 2, 2015 at 5:48 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> Local `bus' is already set to `conn->ep->bus'. Use it.
>
> Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> ---
>  ipc/kdbus/connection.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
> index b00872edbbc9..b9f13749a748 100644
> --- a/ipc/kdbus/connection.c
> +++ b/ipc/kdbus/connection.c
> @@ -432,7 +432,7 @@ static int kdbus_conn_connect(struct kdbus_conn *conn, const char *name)
>          * directly, and won't cause any notifications.
>          */
>         if (!kdbus_conn_is_monitor(conn)) {
> -               ret = kdbus_notify_id_change(conn->ep->bus, KDBUS_ITEM_ID_ADD,
> +               ret = kdbus_notify_id_change(bus, KDBUS_ITEM_ID_ADD,
>                                              conn->id, conn->flags);
>                 if (ret < 0)
>                         goto exit_disconnect;
> --
> 1.8.3.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-03 10:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-02 15:48 [PATCH] kdbus: kdbus_conn_connect(): use `bus' instead of `conn->ep->bus' Sergei Zviagintsev
2015-06-03 10:32 ` David Herrmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.