* [PATCH] efifb: BGRT: Add nobgrt option
@ 2018-09-12 9:12 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2018-09-12 9:12 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Hans de Goede, linux-fbdev, dri-devel
In some setups restoring the BGRT logo is undesirable, allow passing
videoïifb:nobgrt on the kernel commandline to disable it.
Cc: David Herrmann <dh.herrmann@gmail.com>
Reported-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/video/fbdev/efifb.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 3946649b85c8..ba906876cc45 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -42,6 +42,7 @@ struct bmp_dib_header {
u32 colors_important;
} __packed;
+static bool use_bgrt = true;
static bool request_mem_succeeded = false;
static u64 mem_flags = EFI_MEMORY_WC | EFI_MEMORY_UC;
@@ -160,6 +161,9 @@ static void efifb_show_boot_graphics(struct fb_info *info)
void *bgrt_image = NULL;
u8 *dst = info->screen_base;
+ if (!use_bgrt)
+ return;
+
if (!bgrt_tab.image_address) {
pr_info("efifb: No BGRT, not showing boot graphics\n");
return;
@@ -290,6 +294,8 @@ static int efifb_setup(char *options)
screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0);
else if (!strcmp(this_opt, "nowc"))
mem_flags &= ~EFI_MEMORY_WC;
+ else if (!strcmp(this_opt, "nobgrt"))
+ use_bgrt = false;
}
}
--
2.19.0.rc0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] efifb: BGRT: Add nobgrt option
@ 2018-09-12 9:12 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2018-09-12 9:12 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Hans de Goede, linux-fbdev, dri-devel
In some setups restoring the BGRT logo is undesirable, allow passing
video=efifb:nobgrt on the kernel commandline to disable it.
Cc: David Herrmann <dh.herrmann@gmail.com>
Reported-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/video/fbdev/efifb.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 3946649b85c8..ba906876cc45 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -42,6 +42,7 @@ struct bmp_dib_header {
u32 colors_important;
} __packed;
+static bool use_bgrt = true;
static bool request_mem_succeeded = false;
static u64 mem_flags = EFI_MEMORY_WC | EFI_MEMORY_UC;
@@ -160,6 +161,9 @@ static void efifb_show_boot_graphics(struct fb_info *info)
void *bgrt_image = NULL;
u8 *dst = info->screen_base;
+ if (!use_bgrt)
+ return;
+
if (!bgrt_tab.image_address) {
pr_info("efifb: No BGRT, not showing boot graphics\n");
return;
@@ -290,6 +294,8 @@ static int efifb_setup(char *options)
screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0);
else if (!strcmp(this_opt, "nowc"))
mem_flags &= ~EFI_MEMORY_WC;
+ else if (!strcmp(this_opt, "nobgrt"))
+ use_bgrt = false;
}
}
--
2.19.0.rc0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] efifb: BGRT: Add nobgrt option
2018-09-12 9:12 ` Hans de Goede
@ 2018-09-13 6:51 ` David Herrmann
-1 siblings, 0 replies; 6+ messages in thread
From: David Herrmann @ 2018-09-13 6:51 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz
Hi
On Wed, Sep 12, 2018 at 11:12 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> In some setups restoring the BGRT logo is undesirable, allow passing
> videoïifb:nobgrt on the kernel commandline to disable it.
>
> Cc: David Herrmann <dh.herrmann@gmail.com>
> Reported-by: David Herrmann <dh.herrmann@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/video/fbdev/efifb.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Thanks a lot!
David
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index 3946649b85c8..ba906876cc45 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -42,6 +42,7 @@ struct bmp_dib_header {
> u32 colors_important;
> } __packed;
>
> +static bool use_bgrt = true;
> static bool request_mem_succeeded = false;
> static u64 mem_flags = EFI_MEMORY_WC | EFI_MEMORY_UC;
>
> @@ -160,6 +161,9 @@ static void efifb_show_boot_graphics(struct fb_info *info)
> void *bgrt_image = NULL;
> u8 *dst = info->screen_base;
>
> + if (!use_bgrt)
> + return;
> +
> if (!bgrt_tab.image_address) {
> pr_info("efifb: No BGRT, not showing boot graphics\n");
> return;
> @@ -290,6 +294,8 @@ static int efifb_setup(char *options)
> screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0);
> else if (!strcmp(this_opt, "nowc"))
> mem_flags &= ~EFI_MEMORY_WC;
> + else if (!strcmp(this_opt, "nobgrt"))
> + use_bgrt = false;
> }
> }
>
> --
> 2.19.0.rc0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] efifb: BGRT: Add nobgrt option
@ 2018-09-13 6:51 ` David Herrmann
0 siblings, 0 replies; 6+ messages in thread
From: David Herrmann @ 2018-09-13 6:51 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz
Hi
On Wed, Sep 12, 2018 at 11:12 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> In some setups restoring the BGRT logo is undesirable, allow passing
> video=efifb:nobgrt on the kernel commandline to disable it.
>
> Cc: David Herrmann <dh.herrmann@gmail.com>
> Reported-by: David Herrmann <dh.herrmann@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/video/fbdev/efifb.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Thanks a lot!
David
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index 3946649b85c8..ba906876cc45 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -42,6 +42,7 @@ struct bmp_dib_header {
> u32 colors_important;
> } __packed;
>
> +static bool use_bgrt = true;
> static bool request_mem_succeeded = false;
> static u64 mem_flags = EFI_MEMORY_WC | EFI_MEMORY_UC;
>
> @@ -160,6 +161,9 @@ static void efifb_show_boot_graphics(struct fb_info *info)
> void *bgrt_image = NULL;
> u8 *dst = info->screen_base;
>
> + if (!use_bgrt)
> + return;
> +
> if (!bgrt_tab.image_address) {
> pr_info("efifb: No BGRT, not showing boot graphics\n");
> return;
> @@ -290,6 +294,8 @@ static int efifb_setup(char *options)
> screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0);
> else if (!strcmp(this_opt, "nowc"))
> mem_flags &= ~EFI_MEMORY_WC;
> + else if (!strcmp(this_opt, "nobgrt"))
> + use_bgrt = false;
> }
> }
>
> --
> 2.19.0.rc0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] efifb: BGRT: Add nobgrt option
2018-09-13 6:51 ` David Herrmann
@ 2018-09-26 15:56 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-09-26 15:56 UTC (permalink / raw)
To: David Herrmann, Hans de Goede; +Cc: linux-fbdev, dri-devel
On 09/13/2018 08:51 AM, David Herrmann wrote:
> Hi
>
> On Wed, Sep 12, 2018 at 11:12 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> In some setups restoring the BGRT logo is undesirable, allow passing
>> videoïifb:nobgrt on the kernel commandline to disable it.
>>
>> Cc: David Herrmann <dh.herrmann@gmail.com>
>> Reported-by: David Herrmann <dh.herrmann@gmail.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> drivers/video/fbdev/efifb.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efifb: BGRT: Add nobgrt option
@ 2018-09-26 15:56 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-09-26 15:56 UTC (permalink / raw)
To: David Herrmann, Hans de Goede; +Cc: linux-fbdev, dri-devel
On 09/13/2018 08:51 AM, David Herrmann wrote:
> Hi
>
> On Wed, Sep 12, 2018 at 11:12 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> In some setups restoring the BGRT logo is undesirable, allow passing
>> video=efifb:nobgrt on the kernel commandline to disable it.
>>
>> Cc: David Herrmann <dh.herrmann@gmail.com>
>> Reported-by: David Herrmann <dh.herrmann@gmail.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> drivers/video/fbdev/efifb.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-26 15:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 9:12 [PATCH] efifb: BGRT: Add nobgrt option Hans de Goede
2018-09-12 9:12 ` Hans de Goede
2018-09-13 6:51 ` David Herrmann
2018-09-13 6:51 ` David Herrmann
2018-09-26 15:56 ` Bartlomiej Zolnierkiewicz
2018-09-26 15:56 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.