[PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Magnus Damm]

From: Magnus Damm <damm@opensource.se>

Fix sizeof() usage in sh-pfc/core.c to allocate space
for the full data structure instead of a pointer.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 Written against -next in renesas.git

 drivers/pinctrl/sh-pfc/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 0001/drivers/pinctrl/sh-pfc/core.c
+++ work/drivers/pinctrl/sh-pfc/core.c	2013-02-14 21:04:20.000000000 +0900
@@ -495,7 +495,7 @@ static int sh_pfc_probe(struct platform_
 	if (info = NULL)
 		return -ENODEV;
 
-	pfc = devm_kzalloc(&pdev->dev, sizeof(pfc), GFP_KERNEL);
+	pfc = devm_kzalloc(&pdev->dev, sizeof(*pfc), GFP_KERNEL);
 	if (pfc = NULL)
 		return -ENOMEM;
 

Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Laurent Pinchart]

Hi Magnus,

Thanks for the patch.

On Thursday 14 February 2013 21:23:47 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Fix sizeof() usage in sh-pfc/core.c to allocate space
> for the full data structure instead of a pointer.

Oops :-)

This is v3.9 material. Simon, could you please take this and push it upstream 
for v3.9 ?

> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  Written against -next in renesas.git
> 
>  drivers/pinctrl/sh-pfc/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 0001/drivers/pinctrl/sh-pfc/core.c
> +++ work/drivers/pinctrl/sh-pfc/core.c	2013-02-14 21:04:20.000000000 +0900
> @@ -495,7 +495,7 @@ static int sh_pfc_probe(struct platform_
>  	if (info = NULL)
>  		return -ENODEV;
> 
> -	pfc = devm_kzalloc(&pdev->dev, sizeof(pfc), GFP_KERNEL);
> +	pfc = devm_kzalloc(&pdev->dev, sizeof(*pfc), GFP_KERNEL);
>  	if (pfc = NULL)
>  		return -ENOMEM;
-- 
Regards,

Laurent Pinchart

Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Magnus Damm]

Hi Laurent,

On Thu, Feb 14, 2013 at 9:26 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Magnus,
>
> Thanks for the patch.
>
> On Thursday 14 February 2013 21:23:47 Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Fix sizeof() usage in sh-pfc/core.c to allocate space
>> for the full data structure instead of a pointer.
>
> Oops :-)

=)

> This is v3.9 material. Simon, could you please take this and push it upstream
> for v3.9 ?

Yes, that would be great!

/ magnus

Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Laurent Pinchart]

On Thursday 14 February 2013 21:23:47 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Fix sizeof() usage in sh-pfc/core.c to allocate space
> for the full data structure instead of a pointer.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>

Forgot to add my

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  Written against -next in renesas.git
> 
>  drivers/pinctrl/sh-pfc/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 0001/drivers/pinctrl/sh-pfc/core.c
> +++ work/drivers/pinctrl/sh-pfc/core.c	2013-02-14 21:04:20.000000000 +0900
> @@ -495,7 +495,7 @@ static int sh_pfc_probe(struct platform_
>  	if (info = NULL)
>  		return -ENODEV;
> 
> -	pfc = devm_kzalloc(&pdev->dev, sizeof(pfc), GFP_KERNEL);
> +	pfc = devm_kzalloc(&pdev->dev, sizeof(*pfc), GFP_KERNEL);
>  	if (pfc = NULL)
>  		return -ENOMEM;
-- 
Regards,

Laurent Pinchart

Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Simon Horman]

On Thu, Feb 14, 2013 at 01:26:42PM +0100, Laurent Pinchart wrote:
> Hi Magnus,
> 
> Thanks for the patch.
> 
> On Thursday 14 February 2013 21:23:47 Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> > 
> > Fix sizeof() usage in sh-pfc/core.c to allocate space
> > for the full data structure instead of a pointer.
> 
> Oops :-)
> 
> This is v3.9 material. Simon, could you please take this and push it upstream 
> for v3.9 ?

Sure, will do.

Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Magnus Damm]

Hi Simon,

On Fri, Feb 15, 2013 at 12:56 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Feb 14, 2013 at 01:26:42PM +0100, Laurent Pinchart wrote:
>> Hi Magnus,
>>
>> Thanks for the patch.
>>
>> On Thursday 14 February 2013 21:23:47 Magnus Damm wrote:
>> > From: Magnus Damm <damm@opensource.se>
>> >
>> > Fix sizeof() usage in sh-pfc/core.c to allocate space
>> > for the full data structure instead of a pointer.
>>
>> Oops :-)
>>
>> This is v3.9 material. Simon, could you please take this and push it upstream
>> for v3.9 ?
>
> Sure, will do.

Thanks.

/ magnus

Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Linus Walleij]

On Thu, Feb 14, 2013 at 1:23 PM, Magnus Damm <magnus.damm@gmail.com> wrote:

> From: Magnus Damm <damm@opensource.se>
>
> Fix sizeof() usage in sh-pfc/core.c to allocate space
> for the full data structure instead of a pointer.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks!
Linus Walleij

Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Simon Horman]

On Thu, Feb 14, 2013 at 01:27:51PM +0100, Laurent Pinchart wrote:
> On Thursday 14 February 2013 21:23:47 Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> > 
> > Fix sizeof() usage in sh-pfc/core.c to allocate space
> > for the full data structure instead of a pointer.
> > 
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> 
> Forgot to add my
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

[snip]

On Fri, Feb 15, 2013 at 08:46:18PM +0100, Linus Walleij wrote:
> On Thu, Feb 14, 2013 at 1:23 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> 
> > From: Magnus Damm <damm@opensource.se>
> >
> > Fix sizeof() usage in sh-pfc/core.c to allocate space
> > for the full data structure instead of a pointer.
> >
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>


Thanks. I have added the Acked-by lines and sent a pull-request
to arm-soc to have it included in 3.9.

GIT PULL] Renesas ARM-based SoC pinmux for v3.9 #2

[Simon Horman]

Hi Olof, Hi Arnd,

The following changes since commit c3323806a67c0c656e27956b7340e37ba6c6968b:

  sh-pfc: Move sh_pfc.h from include/linux/ to driver directory (2013-01-25 09:24:31 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-pinmux2-for-v3.9

for you to fetch changes up to 8c43fcc7804fc4609ccd9fa021e21f5423db9d96:

  sh-pfc: sh_pfc_probe() sizeof() fix (2013-02-16 10:58:50 +0900)

----------------------------------------------------------------
Bug fix from Magnus that resolves a regression introduced in pfc changes
queued up for 3.9.

----------------------------------------------------------------
Magnus Damm (1):
      sh-pfc: sh_pfc_probe() sizeof() fix

 drivers/pinctrl/sh-pfc/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Simon Horman]

From: Magnus Damm <damm@opensource.se>

Fix sizeof() usage in sh-pfc/core.c to allocate space
for the full data structure instead of a pointer.

Signed-off-by: Magnus Damm <damm@opensource.se>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/pinctrl/sh-pfc/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
index d323c24f..970ddff 100644
--- a/drivers/pinctrl/sh-pfc/core.c
+++ b/drivers/pinctrl/sh-pfc/core.c
@@ -495,7 +495,7 @@ static int sh_pfc_probe(struct platform_device *pdev)
 	if (info = NULL)
 		return -ENODEV;
 
-	pfc = devm_kzalloc(&pdev->dev, sizeof(pfc), GFP_KERNEL);
+	pfc = devm_kzalloc(&pdev->dev, sizeof(*pfc), GFP_KERNEL);
 	if (pfc = NULL)
 		return -ENOMEM;
 
-- 
1.7.10.4

[PATCH] sh-pfc: sh_pfc_probe() sizeof() fix

[Simon Horman]

From: Magnus Damm <damm@opensource.se>

Fix sizeof() usage in sh-pfc/core.c to allocate space
for the full data structure instead of a pointer.

Signed-off-by: Magnus Damm <damm@opensource.se>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/pinctrl/sh-pfc/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c
index d323c24f..970ddff 100644
--- a/drivers/pinctrl/sh-pfc/core.c
+++ b/drivers/pinctrl/sh-pfc/core.c
@@ -495,7 +495,7 @@ static int sh_pfc_probe(struct platform_device *pdev)
 	if (info == NULL)
 		return -ENODEV;
 
-	pfc = devm_kzalloc(&pdev->dev, sizeof(pfc), GFP_KERNEL);
+	pfc = devm_kzalloc(&pdev->dev, sizeof(*pfc), GFP_KERNEL);
 	if (pfc == NULL)
 		return -ENOMEM;
 
-- 
1.7.10.4