[PATCH 0/1][RFC] ARM: shmobile: r8a7740: basic PM domain support

[PATCH 0/1][RFC] ARM: shmobile: r8a7740: basic PM domain support

[Kuninori Morimoto]

Hi Rafael, Magnus
Cc Simon

This patch adds very basic PM domain support to Armadillo board.

On my debug, it seems accessed correctly to PM domain register.
(saved PM register value when power up/down. and printed it in safety timing)

I tested it on Armadillo board, and maybe OK from "register value" point of view.
But I can't check from "real voltage" point, since ...
 - I don't have measuring machine
 - Armadillo doesn't have measuring spot (?)

I added [RFC] on this patch, since I'm not good at PM frame work.

I tested it by

echo mem > /sys/power/state

Re: [PATCH 0/1][RFC] ARM: shmobile: r8a7740: basic PM domain support

[Magnus Damm]

Hi Morimoto-san,

On Mon, Jun 25, 2012 at 7:30 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Rafael, Magnus
> Cc Simon
>
> This patch adds very basic PM domain support to Armadillo board.
>
> On my debug, it seems accessed correctly to PM domain register.
> (saved PM register value when power up/down. and printed it in safety timing)
>
> I tested it on Armadillo board, and maybe OK from "register value" point of view.
> But I can't check from "real voltage" point, since ...
>  - I don't have measuring machine
>  - Armadillo doesn't have measuring spot (?)
>
> I added [RFC] on this patch, since I'm not good at PM frame work.
>
> I tested it by
>
> echo mem > /sys/power/state

Thanks for your work on this, Morimoto-san!

In general I think it looks good for a V1, but I wonder about upcoming
patches for PM domain support for board-specific devices on the
Armadillo board. Do you have any other Armadillo-specific patch that
for instance hooks up the board specific LCDC device to the correct
power domain?

I recommend you to test during runtime with subsystem specific
interfaces - not only suspend-to-RAM. As an example, I believe the
LCDC can be powered on and off using some fbdev specific "blanking"
file in sysfs.

Thanks,

/ magnus

Re: [PATCH 0/1][RFC] ARM: shmobile: r8a7740: basic PM domain support

[Kuninori Morimoto]

Hi Rafael, Magnus

> In general I think it looks good for a V1, but I wonder about upcoming
> patches for PM domain support for board-specific devices on the
> Armadillo board. Do you have any other Armadillo-specific patch that
> for instance hooks up the board specific LCDC device to the correct
> power domain?
> 
> I recommend you to test during runtime with subsystem specific
> interfaces - not only suspend-to-RAM. As an example, I believe the
> LCDC can be powered on and off using some fbdev specific "blanking"
> file in sysfs.

OK. now I created the incremental patches which enable USB/LCDC PM domain.
Can I send these patches ? or should I wait until Rafael's tree became update ?

Best regards
---
Kuninori Morimoto

Re: [PATCH 0/1][RFC] ARM: shmobile: r8a7740: basic PM domain support

[Rafael J. Wysocki]

On Thursday, June 28, 2012, Kuninori Morimoto wrote:
> 
> Hi Rafael, Magnus
> 
> > In general I think it looks good for a V1, but I wonder about upcoming
> > patches for PM domain support for board-specific devices on the
> > Armadillo board. Do you have any other Armadillo-specific patch that
> > for instance hooks up the board specific LCDC device to the correct
> > power domain?
> > 
> > I recommend you to test during runtime with subsystem specific
> > interfaces - not only suspend-to-RAM. As an example, I believe the
> > LCDC can be powered on and off using some fbdev specific "blanking"
> > file in sysfs.
> 
> OK. now I created the incremental patches which enable USB/LCDC PM domain.
> Can I send these patches ? or should I wait until Rafael's tree became update ?

Actaully, please drop patch 1 (the RFC), rebase the rest so that they are
not based on this one and repost (preferably organized like I described in
my previous message).

And in the future, please never, _never_ base production patches on RFC ones.

Thanks,
Rafael