* [PATCH 01/06] ARM: shmobile: Consolidate GPIOLIB Kconfig bits
@ 2014-08-20 13:31 Magnus Damm
2014-08-20 13:50 ` Geert Uytterhoeven
2014-08-20 14:39 ` Magnus Damm
0 siblings, 2 replies; 3+ messages in thread
From: Magnus Damm @ 2014-08-20 13:31 UTC (permalink / raw)
To: linux-sh
From: Magnus Damm <damm+renesas@opensource.se>
Consolidate ARCH_WANT_OPTIONAL_GPIOLIB under ARCH_SHMOBILE
so it can be shared by Legacy and Multiplatform.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
arch/arm/mach-shmobile/Kconfig | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
--- 0001/arch/arm/mach-shmobile/Kconfig
+++ work/arch/arm/mach-shmobile/Kconfig 2014-08-19 21:46:43.000000000 +0900
@@ -1,5 +1,6 @@
config ARCH_SHMOBILE
bool
+ select ARCH_WANT_OPTIONAL_GPIOLIB
menuconfig ARCH_SHMOBILE_MULTI
bool "Renesas ARM SoCs" if ARCH_MULTI_V7
@@ -67,7 +68,6 @@ comment "Renesas ARM SoCs System Type"
config ARCH_SH7372
bool "SH-Mobile AP4 (SH7372)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_CPU_SUSPEND if PM || CPU_IDLE
select CPU_V7
select SH_CLK_CPG
@@ -76,7 +76,6 @@ config ARCH_SH7372
config ARCH_SH73A0
bool "SH-Mobile AG5 (R8A73A00)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_GIC
select CPU_V7
select I2C
@@ -87,7 +86,6 @@ config ARCH_SH73A0
config ARCH_R8A73A4
bool "R-Mobile APE6 (R8A73A40)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_GIC
select CPU_V7
select SH_CLK_CPG
@@ -97,7 +95,6 @@ config ARCH_R8A73A4
config ARCH_R8A7740
bool "R-Mobile A1 (R8A77400)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_GIC
select CPU_V7
select SH_CLK_CPG
@@ -107,7 +104,6 @@ config ARCH_R8A7740
config ARCH_R8A7778
bool "R-Car M1A (R8A77781)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select CPU_V7
select SH_CLK_CPG
select ARM_GIC
@@ -116,7 +112,6 @@ config ARCH_R8A7778
config ARCH_R8A7779
bool "R-Car H1 (R8A77790)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_GIC
select CPU_V7
select SH_CLK_CPG
@@ -125,7 +120,6 @@ config ARCH_R8A7779
config ARCH_R8A7790
bool "R-Car H2 (R8A77900)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_GIC
select CPU_V7
select MIGHT_HAVE_PCI
@@ -136,7 +130,6 @@ config ARCH_R8A7790
config ARCH_R8A7791
bool "R-Car M2 (R8A77910)"
- select ARCH_WANT_OPTIONAL_GPIOLIB
select ARM_GIC
select CPU_V7
select MIGHT_HAVE_PCI
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 01/06] ARM: shmobile: Consolidate GPIOLIB Kconfig bits
2014-08-20 13:31 [PATCH 01/06] ARM: shmobile: Consolidate GPIOLIB Kconfig bits Magnus Damm
@ 2014-08-20 13:50 ` Geert Uytterhoeven
2014-08-20 14:39 ` Magnus Damm
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-08-20 13:50 UTC (permalink / raw)
To: linux-sh
Hi Magnus,
On Wed, Aug 20, 2014 at 3:31 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
> Consolidate ARCH_WANT_OPTIONAL_GPIOLIB under ARCH_SHMOBILE
> so it can be shared by Legacy and Multiplatform.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> arch/arm/mach-shmobile/Kconfig | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> --- 0001/arch/arm/mach-shmobile/Kconfig
> +++ work/arch/arm/mach-shmobile/Kconfig 2014-08-19 21:46:43.000000000 +0900
> @@ -1,5 +1,6 @@
> config ARCH_SHMOBILE
> bool
> + select ARCH_WANT_OPTIONAL_GPIOLIB
This is already selected by ARCH_MULTIPLATFORM, so perhaps it's best
to just move it ARCH_SHMOBILE_LEGACY instead?
> menuconfig ARCH_SHMOBILE_MULTI
> bool "Renesas ARM SoCs" if ARCH_MULTI_V7
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 01/06] ARM: shmobile: Consolidate GPIOLIB Kconfig bits
2014-08-20 13:31 [PATCH 01/06] ARM: shmobile: Consolidate GPIOLIB Kconfig bits Magnus Damm
2014-08-20 13:50 ` Geert Uytterhoeven
@ 2014-08-20 14:39 ` Magnus Damm
1 sibling, 0 replies; 3+ messages in thread
From: Magnus Damm @ 2014-08-20 14:39 UTC (permalink / raw)
To: linux-sh
Hi Geert,
On Wed, Aug 20, 2014 at 10:50 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Wed, Aug 20, 2014 at 3:31 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> Consolidate ARCH_WANT_OPTIONAL_GPIOLIB under ARCH_SHMOBILE
>> so it can be shared by Legacy and Multiplatform.
>>
>> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>> ---
>>
>> arch/arm/mach-shmobile/Kconfig | 9 +--------
>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> --- 0001/arch/arm/mach-shmobile/Kconfig
>> +++ work/arch/arm/mach-shmobile/Kconfig 2014-08-19 21:46:43.000000000 +0900
>> @@ -1,5 +1,6 @@
>> config ARCH_SHMOBILE
>> bool
>> + select ARCH_WANT_OPTIONAL_GPIOLIB
>
> This is already selected by ARCH_MULTIPLATFORM, so perhaps it's best
> to just move it ARCH_SHMOBILE_LEGACY instead?
>
>> menuconfig ARCH_SHMOBILE_MULTI
>> bool "Renesas ARM SoCs" if ARCH_MULTI_V7
Uhm, yeah we seem to have some redundancy. Historically with the
legacy code we always started with OPTIONAL_GPIOLIB for SoCs then let
boards opt-in on REQUIRE_GPIOLIB if they actually depend on
programming the PFC/GPIO for normal operation. With Multiplatform it
becomes a more of a system-wide selection, so OPTIONAL indeed seems
something mainly useful for the Legacy case.
To make things more complicated, there are probably more bits under
ARCH_SHMOBILE_LEGACY that wants to be consolidated. Also ARM building
blocks like Cortex-A7, A8, A9, A15 could share common definitions, but
those look like common ARM architecture things to me.
I somehow feel reluctant of poking around in arch/arm/Kconfig and
potentially cause conflicts. But I guess that's the only way.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-20 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-20 13:31 [PATCH 01/06] ARM: shmobile: Consolidate GPIOLIB Kconfig bits Magnus Damm
2014-08-20 13:50 ` Geert Uytterhoeven
2014-08-20 14:39 ` Magnus Damm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.