From: Hans Holmberg <hans.ml.holmberg@owltronix.com> To: "Matias Bjørling" <mb@lightnvm.io> Cc: "Javier González" <javier@javigon.com>, "Christoph Hellwig" <hch@lst.de>, "Jens Axboe" <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH] lightnvm: deprecated OCSSD support and schedule it for removal in Linux 5.15 Date: Mon, 12 Apr 2021 13:20:07 +0200 [thread overview] Message-ID: <CANr-nt0YpZ0CuREDu613LM7yBK_qgPfwg-bNU-T=2me5GJT=Gw@mail.gmail.com> (raw) In-Reply-To: <3bf88f25-d06d-5b95-7eff-dfb8f78bc389@lightnvm.io> On Mon, Apr 12, 2021 at 12:20 PM Matias Bjørling <mb@lightnvm.io> wrote: > > On 12/04/2021 11.49, Javier González wrote: > > On 12.04.2021 11:26, Matias Bjørling wrote: > >> On 12/04/2021 11.21, Matias Bjørling wrote: > >>> On 12/04/2021 10.12, Christoph Hellwig wrote: > >>>> Lightnvm was an innovative idea to expose more low-level control > >>>> over SSDs. > >>>> But it failed to get properly standardized and remains a > >>>> non-standarized > >>>> extension to NVMe that requires vendor specific quirks for a few > >>>> now mostly > >>>> obsolete SSD devices. The standardized ZNS command set for NVMe > >>>> has take > >>>> over a lot of the approaches and allows for fully standardized > >>>> operation. > >>>> > >>>> Remove the Linux code to support open channel SSDs as the few > >>>> production > >>>> deployments of the above mentioned SSDs are using userspace driver > >>>> stacks > >>>> instead of the fairly limited Linux support. > >>>> > >>>> Signed-off-by: Christoph Hellwig <hch@lst.de> > >>>> --- > >>>> drivers/lightnvm/Kconfig | 4 +++- > >>>> drivers/lightnvm/core.c | 2 ++ > >>>> 2 files changed, 5 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig > >>>> index 4c2ce210c1237d..04caa0f2d445c7 100644 > >>>> --- a/drivers/lightnvm/Kconfig > >>>> +++ b/drivers/lightnvm/Kconfig > >>>> @@ -4,7 +4,7 @@ > >>>> # > >>>> menuconfig NVM > >>>> - bool "Open-Channel SSD target support" > >>>> + bool "Open-Channel SSD target support (DEPRECATED)" > >>>> depends on BLOCK > >>>> help > >>>> Say Y here to get to enable Open-channel SSDs. > >>>> @@ -15,6 +15,8 @@ menuconfig NVM > >>>> If you say N, all options in this submenu will be skipped > >>>> and disabled > >>>> only do this if you know what you are doing. > >>>> + This code is deprecated and will be removed in Linux 5.15. > >>>> + > >>>> if NVM > >>>> config NVM_PBLK > >>>> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > >>>> index 28ddcaa5358b14..4394f47c81296a 100644 > >>>> --- a/drivers/lightnvm/core.c > >>>> +++ b/drivers/lightnvm/core.c > >>>> @@ -1174,6 +1174,8 @@ int nvm_register(struct nvm_dev *dev) > >>>> { > >>>> int ret, exp_pool_size; > >>>> + pr_warn_once("lightnvm support is deprecated and will be > >>>> removed in Linux 5.15.\n"); > >>>> + > >>>> if (!dev->q || !dev->ops) { > >>>> kref_put(&dev->ref, nvm_free); > >>>> return -EINVAL; > >>> > >>> Thanks, Christoph. > >>> > >>> I'll send it to Jens with today's lightnvm PR. > >> > >> Javier, can I add your reviewed-by? > >> > > > > Yes, please. > > > > I'll crack a beer and cheer on it tonight. Good times :) All those patches lost in time, like tears in rain.. Cheers to everyone involved! Hans > > > > Javier > > Thank you. >
WARNING: multiple messages have this Message-ID (diff)
From: Hans Holmberg <hans.ml.holmberg@owltronix.com> To: "Matias Bjørling" <mb@lightnvm.io> Cc: "Javier González" <javier@javigon.com>, "Christoph Hellwig" <hch@lst.de>, "Jens Axboe" <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH] lightnvm: deprecated OCSSD support and schedule it for removal in Linux 5.15 Date: Mon, 12 Apr 2021 13:20:07 +0200 [thread overview] Message-ID: <CANr-nt0YpZ0CuREDu613LM7yBK_qgPfwg-bNU-T=2me5GJT=Gw@mail.gmail.com> (raw) In-Reply-To: <3bf88f25-d06d-5b95-7eff-dfb8f78bc389@lightnvm.io> On Mon, Apr 12, 2021 at 12:20 PM Matias Bjørling <mb@lightnvm.io> wrote: > > On 12/04/2021 11.49, Javier González wrote: > > On 12.04.2021 11:26, Matias Bjørling wrote: > >> On 12/04/2021 11.21, Matias Bjørling wrote: > >>> On 12/04/2021 10.12, Christoph Hellwig wrote: > >>>> Lightnvm was an innovative idea to expose more low-level control > >>>> over SSDs. > >>>> But it failed to get properly standardized and remains a > >>>> non-standarized > >>>> extension to NVMe that requires vendor specific quirks for a few > >>>> now mostly > >>>> obsolete SSD devices. The standardized ZNS command set for NVMe > >>>> has take > >>>> over a lot of the approaches and allows for fully standardized > >>>> operation. > >>>> > >>>> Remove the Linux code to support open channel SSDs as the few > >>>> production > >>>> deployments of the above mentioned SSDs are using userspace driver > >>>> stacks > >>>> instead of the fairly limited Linux support. > >>>> > >>>> Signed-off-by: Christoph Hellwig <hch@lst.de> > >>>> --- > >>>> drivers/lightnvm/Kconfig | 4 +++- > >>>> drivers/lightnvm/core.c | 2 ++ > >>>> 2 files changed, 5 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig > >>>> index 4c2ce210c1237d..04caa0f2d445c7 100644 > >>>> --- a/drivers/lightnvm/Kconfig > >>>> +++ b/drivers/lightnvm/Kconfig > >>>> @@ -4,7 +4,7 @@ > >>>> # > >>>> menuconfig NVM > >>>> - bool "Open-Channel SSD target support" > >>>> + bool "Open-Channel SSD target support (DEPRECATED)" > >>>> depends on BLOCK > >>>> help > >>>> Say Y here to get to enable Open-channel SSDs. > >>>> @@ -15,6 +15,8 @@ menuconfig NVM > >>>> If you say N, all options in this submenu will be skipped > >>>> and disabled > >>>> only do this if you know what you are doing. > >>>> + This code is deprecated and will be removed in Linux 5.15. > >>>> + > >>>> if NVM > >>>> config NVM_PBLK > >>>> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > >>>> index 28ddcaa5358b14..4394f47c81296a 100644 > >>>> --- a/drivers/lightnvm/core.c > >>>> +++ b/drivers/lightnvm/core.c > >>>> @@ -1174,6 +1174,8 @@ int nvm_register(struct nvm_dev *dev) > >>>> { > >>>> int ret, exp_pool_size; > >>>> + pr_warn_once("lightnvm support is deprecated and will be > >>>> removed in Linux 5.15.\n"); > >>>> + > >>>> if (!dev->q || !dev->ops) { > >>>> kref_put(&dev->ref, nvm_free); > >>>> return -EINVAL; > >>> > >>> Thanks, Christoph. > >>> > >>> I'll send it to Jens with today's lightnvm PR. > >> > >> Javier, can I add your reviewed-by? > >> > > > > Yes, please. > > > > I'll crack a beer and cheer on it tonight. Good times :) All those patches lost in time, like tears in rain.. Cheers to everyone involved! Hans > > > > Javier > > Thank you. > _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-12 11:20 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-12 8:12 [PATCH] lightnvm: deprecated OCSSD support and schedule it for removal in Linux 5.15 Christoph Hellwig 2021-04-12 8:12 ` Christoph Hellwig 2021-04-12 9:21 ` Matias Bjørling 2021-04-12 9:21 ` Matias Bjørling 2021-04-12 9:26 ` Matias Bjørling 2021-04-12 9:26 ` Matias Bjørling 2021-04-12 9:49 ` Javier González 2021-04-12 9:49 ` Javier González 2021-04-12 10:20 ` Matias Bjørling 2021-04-12 10:20 ` Matias Bjørling 2021-04-12 11:20 ` Hans Holmberg [this message] 2021-04-12 11:20 ` Hans Holmberg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANr-nt0YpZ0CuREDu613LM7yBK_qgPfwg-bNU-T=2me5GJT=Gw@mail.gmail.com' \ --to=hans.ml.holmberg@owltronix.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=javier@javigon.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=mb@lightnvm.io \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.