* [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs
@ 2019-12-18 6:48 Marek Vasut
2019-12-18 12:17 ` Patrick DELAUNAY
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marek Vasut @ 2019-12-18 6:48 UTC (permalink / raw)
To: u-boot
PHY address 0 is a valid PHY address, to scan for all PHYs, pass -1 to
phy_connect(). Passing 0 used to work before be accident, but does no
longer.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: Ramon Fried <rfried.dev@gmail.com>
---
drivers/net/dwc_eth_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index da5b696c9d..4632111635 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -1045,7 +1045,7 @@ static int eqos_start(struct udevice *dev)
* don't need to reconnect/reconfigure again
*/
if (!eqos->phy) {
- eqos->phy = phy_connect(eqos->mii, 0, dev,
+ eqos->phy = phy_connect(eqos->mii, -1, dev,
eqos->config->interface(dev));
if (!eqos->phy) {
pr_err("phy_connect() failed");
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs
2019-12-18 6:48 [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs Marek Vasut
@ 2019-12-18 12:17 ` Patrick DELAUNAY
2019-12-18 15:25 ` Ramon Fried
2019-12-18 15:29 ` Fabio Estevam
2019-12-18 16:16 ` Joe Hershberger
2 siblings, 1 reply; 5+ messages in thread
From: Patrick DELAUNAY @ 2019-12-18 12:17 UTC (permalink / raw)
To: u-boot
Hi,
> From: Marek Vasut <marex@denx.de>
> Sent: mercredi 18 décembre 2019 07:49
>
> PHY address 0 is a valid PHY address, to scan for all PHYs, pass -1 to
> phy_connect(). Passing 0 used to work before be accident, but does no longer.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> drivers/net/dwc_eth_qos.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index
> da5b696c9d..4632111635 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -1045,7 +1045,7 @@ static int eqos_start(struct udevice *dev)
> * don't need to reconnect/reconfigure again
> */
> if (!eqos->phy) {
> - eqos->phy = phy_connect(eqos->mii, 0, dev,
> + eqos->phy = phy_connect(eqos->mii, -1, dev,
> eqos->config->interface(dev));
> if (!eqos->phy) {
> pr_err("phy_connect() failed");
> --
> 2.24.1
Regards
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs
2019-12-18 12:17 ` Patrick DELAUNAY
@ 2019-12-18 15:25 ` Ramon Fried
0 siblings, 0 replies; 5+ messages in thread
From: Ramon Fried @ 2019-12-18 15:25 UTC (permalink / raw)
To: u-boot
On Wed, Dec 18, 2019 at 2:17 PM Patrick DELAUNAY
<patrick.delaunay@st.com> wrote:
>
> Hi,
>
> > From: Marek Vasut <marex@denx.de>
> > Sent: mercredi 18 décembre 2019 07:49
> >
> > PHY address 0 is a valid PHY address, to scan for all PHYs, pass -1 to
> > phy_connect(). Passing 0 used to work before be accident, but does no longer.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Joe Hershberger <joe.hershberger@ni.com>
> > Cc: Patrice Chotard <patrice.chotard@st.com>
> > Cc: Patrick Delaunay <patrick.delaunay@st.com>
> > Cc: Ramon Fried <rfried.dev@gmail.com>
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
>
> > ---
> > drivers/net/dwc_eth_qos.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index
> > da5b696c9d..4632111635 100644
> > --- a/drivers/net/dwc_eth_qos.c
> > +++ b/drivers/net/dwc_eth_qos.c
> > @@ -1045,7 +1045,7 @@ static int eqos_start(struct udevice *dev)
> > * don't need to reconnect/reconfigure again
> > */
> > if (!eqos->phy) {
> > - eqos->phy = phy_connect(eqos->mii, 0, dev,
> > + eqos->phy = phy_connect(eqos->mii, -1, dev,
> > eqos->config->interface(dev));
> > if (!eqos->phy) {
> > pr_err("phy_connect() failed");
> > --
> > 2.24.1
>
> Regards
>
Reviewed-By: Ramon Fried <rfried.dev@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs
2019-12-18 6:48 [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs Marek Vasut
2019-12-18 12:17 ` Patrick DELAUNAY
@ 2019-12-18 15:29 ` Fabio Estevam
2019-12-18 16:16 ` Joe Hershberger
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2019-12-18 15:29 UTC (permalink / raw)
To: u-boot
On Wed, Dec 18, 2019 at 3:49 AM Marek Vasut <marex@denx.de> wrote:
>
> PHY address 0 is a valid PHY address, to scan for all PHYs, pass -1 to
> phy_connect(). Passing 0 used to work before be accident, but does no
s/be/by
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs
2019-12-18 6:48 [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs Marek Vasut
2019-12-18 12:17 ` Patrick DELAUNAY
2019-12-18 15:29 ` Fabio Estevam
@ 2019-12-18 16:16 ` Joe Hershberger
2 siblings, 0 replies; 5+ messages in thread
From: Joe Hershberger @ 2019-12-18 16:16 UTC (permalink / raw)
To: u-boot
On Wed, Dec 18, 2019 at 12:49 AM Marek Vasut <marex@denx.de> wrote:
>
> PHY address 0 is a valid PHY address, to scan for all PHYs, pass -1 to
> phy_connect(). Passing 0 used to work before be accident, but does no
> longer.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: Ramon Fried <rfried.dev@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-18 16:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 6:48 [PATCH] net: dwc_eth_qos: Pass -1 to phy_connect() to scan for all PHYs Marek Vasut
2019-12-18 12:17 ` Patrick DELAUNAY
2019-12-18 15:25 ` Ramon Fried
2019-12-18 15:29 ` Fabio Estevam
2019-12-18 16:16 ` Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.