* [U-Boot] [PATCH] net: ravb: Filter out supported PHY features
@ 2018-06-18 3:48 Marek Vasut
2018-06-18 21:09 ` Joe Hershberger
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2018-06-18 3:48 UTC (permalink / raw)
To: u-boot
The RAVB only supports 100Full and 1000Full operation, it does not support
10Full or any Half-duplex modes. The PHY could still advertise those features
though, so filter out the PHY features accordingly.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: Joe Hershberger <joe.hershberger@ni.com>
---
drivers/net/ravb.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c
index d66fcef4e7..adcbc931e0 100644
--- a/drivers/net/ravb.c
+++ b/drivers/net/ravb.c
@@ -318,12 +318,13 @@ static int ravb_phy_config(struct udevice *dev)
eth->phydev = phydev;
- /* 10BASE is not supported for Ethernet AVB MAC */
- phydev->supported &= ~(SUPPORTED_10baseT_Full
- | SUPPORTED_10baseT_Half);
+ phydev->supported &= SUPPORTED_100baseT_Full |
+ SUPPORTED_1000baseT_Full | SUPPORTED_Autoneg |
+ SUPPORTED_TP | SUPPORTED_MII | SUPPORTED_Pause |
+ SUPPORTED_Asym_Pause;
+
if (pdata->max_speed != 1000) {
- phydev->supported &= ~(SUPPORTED_1000baseT_Half
- | SUPPORTED_1000baseT_Full);
+ phydev->supported &= ~SUPPORTED_1000baseT_Full;
reg = phy_read(phydev, -1, MII_CTRL1000);
reg &= ~(BIT(9) | BIT(8));
phy_write(phydev, -1, MII_CTRL1000, reg);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] net: ravb: Filter out supported PHY features
2018-06-18 3:48 [U-Boot] [PATCH] net: ravb: Filter out supported PHY features Marek Vasut
@ 2018-06-18 21:09 ` Joe Hershberger
0 siblings, 0 replies; 2+ messages in thread
From: Joe Hershberger @ 2018-06-18 21:09 UTC (permalink / raw)
To: u-boot
On Sun, Jun 17, 2018 at 10:48 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> The RAVB only supports 100Full and 1000Full operation, it does not support
> 10Full or any Half-duplex modes. The PHY could still advertise those features
> though, so filter out the PHY features accordingly.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-18 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-18 3:48 [U-Boot] [PATCH] net: ravb: Filter out supported PHY features Marek Vasut
2018-06-18 21:09 ` Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.