* [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> @ 2018-10-14 19:27 Heinrich Schuchardt 2018-10-15 21:52 ` Joe Hershberger 0 siblings, 1 reply; 6+ messages in thread From: Heinrich Schuchardt @ 2018-10-14 19:27 UTC (permalink / raw) To: u-boot The local interface is not usable for many network operations. It has been disabled in all sandbox device trees except sandbox.dts. Let's disable it here too. 'bootefi selftest' tries to do execute DHCP. This fails on the lo device. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- arch/sandbox/dts/sandbox.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts index fb866e8807..e0990352fb 100644 --- a/arch/sandbox/dts/sandbox.dts +++ b/arch/sandbox/dts/sandbox.dts @@ -49,7 +49,7 @@ ethrawbus { compatible = "sandbox,eth-raw-bus"; - skip-localhost = <0>; + skip-localhost = <1>; }; eth at 10002000 { -- 2.19.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> 2018-10-14 19:27 [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> Heinrich Schuchardt @ 2018-10-15 21:52 ` Joe Hershberger 2018-10-16 0:19 ` Heinrich Schuchardt 0 siblings, 1 reply; 6+ messages in thread From: Joe Hershberger @ 2018-10-15 21:52 UTC (permalink / raw) To: u-boot On Sun, Oct 14, 2018 at 2:27 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > The local interface is not usable for many network operations. It has been > disabled in all sandbox device trees except sandbox.dts. Let's disable it > here too. > > 'bootefi selftest' tries to do execute DHCP. This fails on the lo device. Shouldn't the tests be using test.dts? This is for hand testing, where it can be available, and people can use it or not by specifying ethact. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > arch/sandbox/dts/sandbox.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts > index fb866e8807..e0990352fb 100644 > --- a/arch/sandbox/dts/sandbox.dts > +++ b/arch/sandbox/dts/sandbox.dts > @@ -49,7 +49,7 @@ > > ethrawbus { > compatible = "sandbox,eth-raw-bus"; > - skip-localhost = <0>; > + skip-localhost = <1>; > }; > > eth at 10002000 { > -- > 2.19.1 > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> 2018-10-15 21:52 ` Joe Hershberger @ 2018-10-16 0:19 ` Heinrich Schuchardt 2018-10-16 4:36 ` Joe Hershberger 0 siblings, 1 reply; 6+ messages in thread From: Heinrich Schuchardt @ 2018-10-16 0:19 UTC (permalink / raw) To: u-boot On 10/15/2018 11:52 PM, Joe Hershberger wrote: > On Sun, Oct 14, 2018 at 2:27 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: >> >> The local interface is not usable for many network operations. It has been >> disabled in all sandbox device trees except sandbox.dts. Let's disable it >> here too. >> >> 'bootefi selftest' tries to do execute DHCP. This fails on the lo device. > > Shouldn't the tests be using test.dts? bootefi selftest is a command inside U-Boot. It does not choose a device tree. This is for hand testing, where > it can be available, and people can use it or not by specifying > ethact. > make sandbox_defconfig make ./u-boot -D uses sandbox.dts. For all other sandbox*.dts we also set skip-localhost=1. Why should sandbox_dts be inconsistent with those? Why would I want to use the cloned local interface? board/sandbox/README.sandbox does not even mention test.dts. The only reference is in a Python test, see tools/binman/ftest.py. The network devices defined in test.dts do not allow to access the real world. So why should I use it? Best regards Heinrich >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> arch/sandbox/dts/sandbox.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts >> index fb866e8807..e0990352fb 100644 >> --- a/arch/sandbox/dts/sandbox.dts >> +++ b/arch/sandbox/dts/sandbox.dts >> @@ -49,7 +49,7 @@ >> >> ethrawbus { >> compatible = "sandbox,eth-raw-bus"; >> - skip-localhost = <0>; >> + skip-localhost = <1>; >> }; >> >> eth at 10002000 { >> -- >> 2.19.1 >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot at lists.denx.de >> https://lists.denx.de/listinfo/u-boot ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> 2018-10-16 0:19 ` Heinrich Schuchardt @ 2018-10-16 4:36 ` Joe Hershberger 2018-10-16 16:22 ` Heinrich Schuchardt 0 siblings, 1 reply; 6+ messages in thread From: Joe Hershberger @ 2018-10-16 4:36 UTC (permalink / raw) To: u-boot Hi Heinrich, On Mon, Oct 15, 2018 at 7:20 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > On 10/15/2018 11:52 PM, Joe Hershberger wrote: > > On Sun, Oct 14, 2018 at 2:27 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > >> > >> The local interface is not usable for many network operations. It has been > >> disabled in all sandbox device trees except sandbox.dts. Let's disable it > >> here too. > >> > >> 'bootefi selftest' tries to do execute DHCP. This fails on the lo device. > > > > Shouldn't the tests be using test.dts? > > bootefi selftest is a command inside U-Boot. It does not choose a device > tree. > > This is for hand testing, where > > it can be available, and people can use it or not by specifying > > ethact. > > > > make sandbox_defconfig > make > ./u-boot -D > > uses sandbox.dts. Sure... and ./u-boot -d test/dm/test.dtb uses that device tree. Or any other you choose to build. > > For all other sandbox*.dts we also set skip-localhost=1. Why should > sandbox_dts be inconsistent with those? The only one that I may consider inconsistent is sandbox64.dts (I assume that is what you mean when you say "all other", you are talking about this one file, right?), and I'm not sure where it's used. I've never used it that I remember. Unless it's magically picked somehow based on something environmental. You seem to think that if you don't force the local interface to not show up that you have to use it. Instead you can just set the ethact U-Boot environment variable to the appropriate interface you want to use, and off you go. > Why would I want to use the cloned local interface? So that you could test against, for instance, a TFTP server on your host machine. > board/sandbox/README.sandbox does not even mention test.dts. The only > reference is in a Python test, see tools/binman/ftest.py. You'll notice the message in test/dm/test-main.c that claims the requirement to use test.dts. > The network devices defined in test.dts do not allow to access the real > world. So why should I use it? Again, that is for the dm unit tests, not hand testing. Cheers, -Joe > > Best regards > > Heinrich > > >> > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > >> --- > >> arch/sandbox/dts/sandbox.dts | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts > >> index fb866e8807..e0990352fb 100644 > >> --- a/arch/sandbox/dts/sandbox.dts > >> +++ b/arch/sandbox/dts/sandbox.dts > >> @@ -49,7 +49,7 @@ > >> > >> ethrawbus { > >> compatible = "sandbox,eth-raw-bus"; > >> - skip-localhost = <0>; > >> + skip-localhost = <1>; > >> }; > >> > >> eth at 10002000 { > >> -- > >> 2.19.1 > >> > >> _______________________________________________ > >> U-Boot mailing list > >> U-Boot at lists.denx.de > >> https://lists.denx.de/listinfo/u-boot > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> 2018-10-16 4:36 ` Joe Hershberger @ 2018-10-16 16:22 ` Heinrich Schuchardt 2018-10-16 18:27 ` Joe Hershberger 0 siblings, 1 reply; 6+ messages in thread From: Heinrich Schuchardt @ 2018-10-16 16:22 UTC (permalink / raw) To: u-boot On 10/16/2018 06:42 AM, Joe Hershberger wrote: > Hi Heinrich, > > On Mon, Oct 15, 2018 at 7:20 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: >> >> On 10/15/2018 11:52 PM, Joe Hershberger wrote: >>> On Sun, Oct 14, 2018 at 2:27 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: >>>> >>>> The local interface is not usable for many network operations. It has been >>>> disabled in all sandbox device trees except sandbox.dts. Let's disable it >>>> here too. >>>> >>>> 'bootefi selftest' tries to do execute DHCP. This fails on the lo device. >>> >>> Shouldn't the tests be using test.dts? >> >> bootefi selftest is a command inside U-Boot. It does not choose a device >> tree. >> >> This is for hand testing, where >>> it can be available, and people can use it or not by specifying >>> ethact. >>> >> >> make sandbox_defconfig >> make >> ./u-boot -D >> >> uses sandbox.dts. > > Sure... and ./u-boot -d test/dm/test.dtb uses that device tree. Or any > other you choose to build. >> >> For all other sandbox*.dts we also set skip-localhost=1. Why should >> sandbox_dts be inconsistent with those? > > The only one that I may consider inconsistent is sandbox64.dts (I > assume that is what you mean when you say "all other", you are talking > about this one file, right?), and I'm not sure where it's used. I've > never used it that I remember. Unless it's magically picked somehow > based on something environmental. > > You seem to think that if you don't force the local interface to not > show up that you have to use it. Instead you can just set the ethact > U-Boot environment variable to the appropriate interface you want to > use, and off you go. > >> Why would I want to use the cloned local interface? > > So that you could test against, for instance, a TFTP server on your > host machine. > >> board/sandbox/README.sandbox does not even mention test.dts. The only >> reference is in a Python test, see tools/binman/ftest.py. > > You'll notice the message in test/dm/test-main.c that claims the > requirement to use test.dts. > >> The network devices defined in test.dts do not allow to access the real >> world. So why should I use it? > > Again, that is for the dm unit tests, not hand testing. > > Cheers, > -Joe Thanks Joe for your valuable feedback. I have set the patch to rejected. Best regards Heinrich ^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> 2018-10-16 16:22 ` Heinrich Schuchardt @ 2018-10-16 18:27 ` Joe Hershberger 0 siblings, 0 replies; 6+ messages in thread From: Joe Hershberger @ 2018-10-16 18:27 UTC (permalink / raw) To: u-boot On Tue, Oct 16, 2018 at 11:23 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > On 10/16/2018 06:42 AM, Joe Hershberger wrote: > > Hi Heinrich, > > > > On Mon, Oct 15, 2018 at 7:20 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > >> > >> On 10/15/2018 11:52 PM, Joe Hershberger wrote: > >>> On Sun, Oct 14, 2018 at 2:27 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > >>>> > >>>> The local interface is not usable for many network operations. It has been > >>>> disabled in all sandbox device trees except sandbox.dts. Let's disable it > >>>> here too. > >>>> > >>>> 'bootefi selftest' tries to do execute DHCP. This fails on the lo device. > >>> > >>> Shouldn't the tests be using test.dts? > >> > >> bootefi selftest is a command inside U-Boot. It does not choose a device > >> tree. Is this added to be used with sandbox or to be used with a real board or both? I'm guessing this works fine if you set ethact appropriately first, right? > >> > >> This is for hand testing, where > >>> it can be available, and people can use it or not by specifying > >>> ethact. > >>> > >> > >> make sandbox_defconfig > >> make > >> ./u-boot -D > >> > >> uses sandbox.dts. > > > > Sure... and ./u-boot -d test/dm/test.dtb uses that device tree. Or any > > other you choose to build. > >> > >> For all other sandbox*.dts we also set skip-localhost=1. Why should > >> sandbox_dts be inconsistent with those? > > > > The only one that I may consider inconsistent is sandbox64.dts (I > > assume that is what you mean when you say "all other", you are talking > > about this one file, right?), and I'm not sure where it's used. I've > > never used it that I remember. Unless it's magically picked somehow > > based on something environmental. > > > > You seem to think that if you don't force the local interface to not > > show up that you have to use it. Instead you can just set the ethact > > U-Boot environment variable to the appropriate interface you want to > > use, and off you go. > > > >> Why would I want to use the cloned local interface? > > > > So that you could test against, for instance, a TFTP server on your > > host machine. > > > >> board/sandbox/README.sandbox does not even mention test.dts. The only > >> reference is in a Python test, see tools/binman/ftest.py. > > > > You'll notice the message in test/dm/test-main.c that claims the > > requirement to use test.dts. > > > >> The network devices defined in test.dts do not allow to access the real > >> world. So why should I use it? > > > > Again, that is for the dm unit tests, not hand testing. > > > > Cheers, > > -Joe > > Thanks Joe for your valuable feedback. No problem. I hope you're able to make your use-case work. > I have set the patch to rejected. Thanks. -Joe > Best regards > > Heinrich > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-16 18:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-14 19:27 [U-Boot] [PATCH 1/1] sandbox: dt: sandbox.dts set skip-localhost = <1> Heinrich Schuchardt 2018-10-15 21:52 ` Joe Hershberger 2018-10-16 0:19 ` Heinrich Schuchardt 2018-10-16 4:36 ` Joe Hershberger 2018-10-16 16:22 ` Heinrich Schuchardt 2018-10-16 18:27 ` Joe Hershberger
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.