* [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
@ 2019-02-26 15:50 Ioana Ciocoi Radulescu
2019-03-04 19:18 ` Joe Hershberger
0 siblings, 1 reply; 5+ messages in thread
From: Ioana Ciocoi Radulescu @ 2019-02-26 15:50 UTC (permalink / raw)
To: u-boot
If node /board_info/ports does not exist in the DPC file,
function mc_fixup_dpc() will skip not only MAC address fixup,
but also the cache flush at the end. This may cause the other
fixup changes (e.g. ICID relatd ones) to be ignored by MC.
Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
---
drivers/net/fsl-mc/mc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
index a51b8a4..e6cf7f3 100644
--- a/drivers/net/fsl-mc/mc.c
+++ b/drivers/net/fsl-mc/mc.c
@@ -421,9 +421,11 @@ static int mc_fixup_dpc(u64 dpc_addr)
/* fixup MAC addresses for dpmac ports */
nodeoffset = fdt_path_offset(blob, "/board_info/ports");
if (nodeoffset < 0)
- return 0;
+ goto out;
err = mc_fixup_mac_addrs(blob, MC_FIXUP_DPC);
+
+out:
flush_dcache_range(dpc_addr, dpc_addr + fdt_totalsize(blob));
return err;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
2019-02-26 15:50 [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup Ioana Ciocoi Radulescu
@ 2019-03-04 19:18 ` Joe Hershberger
2019-03-15 13:33 ` Prabhakar Kushwaha
0 siblings, 1 reply; 5+ messages in thread
From: Joe Hershberger @ 2019-03-04 19:18 UTC (permalink / raw)
To: u-boot
On Tue, Feb 26, 2019 at 9:51 AM Ioana Ciocoi Radulescu
<ruxandra.radulescu@nxp.com> wrote:
>
> If node /board_info/ports does not exist in the DPC file,
> function mc_fixup_dpc() will skip not only MAC address fixup,
> but also the cache flush at the end. This may cause the other
> fixup changes (e.g. ICID relatd ones) to be ignored by MC.
Typo in commit log.
>
> Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
>
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
2019-03-04 19:18 ` Joe Hershberger
@ 2019-03-15 13:33 ` Prabhakar Kushwaha
0 siblings, 0 replies; 5+ messages in thread
From: Prabhakar Kushwaha @ 2019-03-15 13:33 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Joe Hershberger <joe.hershberger@gmail.com>
> Sent: Tuesday, March 5, 2019 12:48 AM
> To: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Cc: u-boot at lists.denx.de; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>
> Subject: Re: [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
>
> On Tue, Feb 26, 2019 at 9:51 AM Ioana Ciocoi Radulescu
> <ruxandra.radulescu@nxp.com> wrote:
> >
> > If node /board_info/ports does not exist in the DPC file, function
> > mc_fixup_dpc() will skip not only MAC address fixup, but also the
> > cache flush at the end. This may cause the other fixup changes (e.g.
> > ICID relatd ones) to be ignored by MC.
>
> Typo in commit log.
>
> >
> > Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to
> > DPL")
> >
> > Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Applied to u-boot-fsl-qoriq, awaiting upstream
--pk
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
[not found] <1551195703-16270-1-git-send-email-ruxandra.radulescu@nxp.com>
2019-03-02 13:05 ` Prabhakar Kushwaha
@ 2019-03-04 9:19 ` Laurentiu Tudor
1 sibling, 0 replies; 5+ messages in thread
From: Laurentiu Tudor @ 2019-03-04 9:19 UTC (permalink / raw)
To: u-boot
On 26.02.2019 17:41, Ioana Ciocoi Radulescu wrote:
> If node /board_info/ports does not exist in the DPC file,
> function mc_fixup_dpc() will skip not only MAC address fixup,
> but also the cache flush at the end. This may cause the other
> fixup changes (e.g. ICID relatd ones) to be ignored by MC.
>
> Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
>
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
> ---
> drivers/net/fsl-mc/mc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
Best Regards, Laurentiu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
[not found] <1551195703-16270-1-git-send-email-ruxandra.radulescu@nxp.com>
@ 2019-03-02 13:05 ` Prabhakar Kushwaha
2019-03-04 9:19 ` Laurentiu Tudor
1 sibling, 0 replies; 5+ messages in thread
From: Prabhakar Kushwaha @ 2019-03-02 13:05 UTC (permalink / raw)
To: u-boot
Dear Joe
> -----Original Message-----
> From: Ioana Ciocoi Radulescu
> Sent: Tuesday, February 26, 2019 9:12 PM
> To: u-boot at lists.denx.de; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>
> Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Subject: [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup
>
> If node /board_info/ports does not exist in the DPC file, function mc_fixup_dpc()
> will skip not only MAC address fixup, but also the cache flush at the end. This
> may cause the other fixup changes (e.g. ICID relatd ones) to be ignored by MC.
>
> Fixes: 1161dbcc0a36 ("drivers: net: fsl-mc: Include MAC addr fixup to DPL")
>
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
> ---
Please review and ack this patch.
I want to send this via u-boot-fsl-qoriq repo.
--pk
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-15 13:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 15:50 [U-Boot] [PATCH] driver: net: fsl-mc: Fix DPC MAC address fixup Ioana Ciocoi Radulescu
2019-03-04 19:18 ` Joe Hershberger
2019-03-15 13:33 ` Prabhakar Kushwaha
[not found] <1551195703-16270-1-git-send-email-ruxandra.radulescu@nxp.com>
2019-03-02 13:05 ` Prabhakar Kushwaha
2019-03-04 9:19 ` Laurentiu Tudor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.