* Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory
[not found] <20220313105031.1081110-1-gaurijove@gmail.com>
@ 2022-03-15 8:50 ` Christian Couder
2022-03-15 16:11 ` Jayati Shrivastava
0 siblings, 1 reply; 3+ messages in thread
From: Christian Couder @ 2022-03-15 8:50 UTC (permalink / raw)
To: JAYATI SHRIVASTAVA; +Cc: Hariom verma, git
On Sun, Mar 13, 2022 at 11:50 AM JAYATI SHRIVASTAVA <gaurijove@gmail.com> wrote:
>
> From: JAYATI SHRIVASTAVA <gaurijove@gmail.com>
Thanks for this patch! I am curious what tool you used to prepare and
send it. This is not a big deal but when there is only one patch I
think [PATCH] is preferred over [PATCH 1/1]. Also I think the 'From:
JAYATI...' line is not nécessary if you are sending the patch using
the same email address as what's in the 'From: JAYATI...' line.
> To check whether the given path is a directory, use
> the helper function 'test_path_is_dir' defined in the
> test harness library instead of passing the -d flag to the test command
It's nice to say why it's better to use functions like
test_path_is_dir() rather than `test -d`. Also it looks like the last
line could be formatted to be around the same length as previous
lines, instead of being significantly longer.
The sentence should end with a full stop.
> Signed-off-by: JAYATI SHRIVASTAVA <gaurijove@gmail.com>
It's also not a big deal, but, unless it's really a personal
preference, you might not want to use only uppercase letters for your
name, as it's not usual here.
> ---
> t/t7403-submodule-sync.sh | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
The code change looks good to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory
2022-03-15 8:50 ` [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory Christian Couder
@ 2022-03-15 16:11 ` Jayati Shrivastava
2022-03-15 20:00 ` Christian Couder
0 siblings, 1 reply; 3+ messages in thread
From: Jayati Shrivastava @ 2022-03-15 16:11 UTC (permalink / raw)
To: Christian Couder; +Cc: Hariom verma, git
Hi Christian,
Thanks for reviewing.
>On Tue, Mar 15, 2022 at 2:20 PM Christian Couder <christian.couder@gmail.com> wrote:
> Thanks for this patch! I am curious what tool you used to prepare and
> send it.This is not a big deal but when there is only one patch I
> think [PATCH] is preferred over [PATCH 1/1]. Also I think the 'From:
> JAYATI...' line is not nécessary if you are sending the patch using
> the same email address as what's in the 'From: JAYATI...' line.
I am using git format-patch and send-email but had previously made
some unnecessary modifications in the editor which I have now done
away with.
> It's nice to say why it's better to use functions like
> test_path_is_dir() rather than `test -d`. Also it looks like the last
> line could be formatted to be around the same length as previous
> lines, instead of being significantly longer.
> The sentence should end with a full stop.
>
> > Signed-off-by: JAYATI SHRIVASTAVA <gaurijove@gmail.com>
>
> It's also not a big deal, but, unless it's really a personal
> preference, you might not want to use only uppercase letters for your
> name, as it's not usual here.
I have modified the commit message as per your reviews. However,
I am not sure why my patches are still not showing up on the mailing
list despite passing the --to/--cc/--in-reply-to options correctly to
git send-email. What do you think might be the reason?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory
2022-03-15 16:11 ` Jayati Shrivastava
@ 2022-03-15 20:00 ` Christian Couder
0 siblings, 0 replies; 3+ messages in thread
From: Christian Couder @ 2022-03-15 20:00 UTC (permalink / raw)
To: Jayati Shrivastava; +Cc: Hariom verma, git
On Tue, Mar 15, 2022 at 5:11 PM Jayati Shrivastava <gaurijove@gmail.com> wrote:
> I have modified the commit message as per your reviews. However,
> I am not sure why my patches are still not showing up on the mailing
> list despite passing the --to/--cc/--in-reply-to options correctly to
> git send-email. What do you think might be the reason?
I might take a look later, but this one made it through:
https://lore.kernel.org/git/pull.1177.git.1647373314457.gitgitgadget@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-15 20:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220313105031.1081110-1-gaurijove@gmail.com>
2022-03-15 8:50 ` [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory Christian Couder
2022-03-15 16:11 ` Jayati Shrivastava
2022-03-15 20:00 ` Christian Couder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.