Re: [SPDK] https://review.gerrithub.io/c/spdk/spdk/+/432136

* Re: [SPDK] https://review.gerrithub.io/c/spdk/spdk/+/432136
@ 2018-11-15 13:45 Andrey Kuzmin
  0 siblings, 0 replies; 10+ messages in thread
From: Andrey Kuzmin @ 2018-11-15 13:45 UTC (permalink / raw)
  To: spdk

[-- Attachment #1: Type: text/plain, Size: 3192 bytes --]

Resubmitted patch fails the test, presumably due to the unsafe last bdev
grab introduced during review.

While I can restore the original safe traversal, I'm wondering why the
iterator ever gets called on the empty bdev queue and if doesn't point to a
deeper issue.

Regards,
Andrey

On Thu, Nov 15, 2018, 13:43 Andrey Kuzmin <andrey.v.kuzmin(a)gmail.com> wrote:

>
>
> On Thu, Nov 15, 2018, 13:30 Stojaczyk, Dariusz <
> dariusz.stojaczyk(a)intel.com> wrote:
>
>> Hi Andrey,
>> The fix was merged tonight. Paul even sent out an email titled:
>> [SPDK] io_device already registered error in CI - fix is in, you will
>> likely want to rebase
>>
>
> Ok, I'll rebase and resubmit.
>
> Thanks,
> A.
>
>> D.
>>
>> > -----Original Message-----
>> > From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Andrey
>> Kuzmin
>> > Sent: Thursday, November 15, 2018 11:02 AM
>> > To: Storage Performance Development Kit <spdk(a)lists.01.org>
>> > Subject: Re: [SPDK] https://review.gerrithub.io/c/spdk/spdk/+/432136
>> >
>> > I see the test build for the resubmitted patch failing due to the
>> earlier
>> > reported 'io device already registered' issue. Let me know if I should
>> > resubmit when the fix for the issue gets merged.
>> >
>> > Regards,
>> > Andrey
>> >
>> > On Wed, Nov 14, 2018, 21:27 Andrey Kuzmin <andrey.v.kuzmin(a)gmail.com>
>> > wrote:
>> >
>> > >
>> > >
>> > > On Wed, Nov 14, 2018, 21:14 Harris, James R <james.r.harris(a)intel.com
>> >
>> > > wrote:
>> > >
>> > >> Hi Andrey,
>> > >>
>> > >> Thanks for the reminder.  We can definitely get this into 18.10.1 -
>> I've
>> > >> added the 18.10.1 hashtag for it.  I posted some comments on
>> GerritHub
>> > as
>> > >> well - once those are fixed up we can get this merged to master and
>> then
>> > >> cherry-picked back to the 18.10 branch for the upcoming 18.10.1
>> release.
>> > >>
>> > >
>> > > Thanks Jim, I'll take a look and comment.
>> > >
>> > >
>> > >> -Jim
>> > >>
>> > >>
>> > >> On 11/14/18, 8:07 AM, "SPDK on behalf of Andrey Kuzmin" <
>> > >> spdk-bounces(a)lists.01.org on behalf of andrey.v.kuzmin(a)gmail.com>
>> > wrote:
>> > >>
>> > >>     I will appreciate a review and a comment on if this could make
>> it into
>> > >>     18.10.1.
>> > >>
>> > >>     Regards,
>> > >>     Andrey
>> > >>     _______________________________________________
>> > >>     SPDK mailing list
>> > >>     SPDK(a)lists.01.org
>> > >>     https://lists.01.org/mailman/listinfo/spdk
>> > >>
>> > >>
>> > >> _______________________________________________
>> > >> SPDK mailing list
>> > >> SPDK(a)lists.01.org
>> > >> https://lists.01.org/mailman/listinfo/spdk
>> > >>
>> > > --
>> > >
>> > > Regards,
>> > > Andrey
>> > >
>> > --
>> >
>> > Regards,
>> > Andrey
>> > _______________________________________________
>> > SPDK mailing list
>> > SPDK(a)lists.01.org
>> > https://lists.01.org/mailman/listinfo/spdk
>> _______________________________________________
>> SPDK mailing list
>> SPDK(a)lists.01.org
>> https://lists.01.org/mailman/listinfo/spdk
>>
> --
>
> Regards,
> Andrey
>
-- 

Regards,
Andrey

^ permalink raw reply	[flat|nested] 10+ messages in thread