[PATCH 1/2] net/ena: remove redundant variable

[PATCH 1/2] net/ena: remove redundant variable

[Yong Wang]

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 drivers/net/ena/base/ena_com.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index bd6f3c6..39356d2 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -2242,7 +2242,6 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
 {
 	struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;
 	struct ena_rss *rss = &ena_dev->rss;
-	struct ena_admin_feature_rss_hash_control *hash_ctrl = rss->hash_ctrl;
 	struct ena_admin_set_feat_cmd cmd;
 	struct ena_admin_set_feat_resp resp;
 	int ret;
@@ -2269,7 +2268,8 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
 		ena_trc_err("memory address set failed\n");
 		return ret;
 	}
-	cmd.control_buffer.length = sizeof(*hash_ctrl);
+	cmd.control_buffer.length =
+		sizeof(struct ena_admin_feature_rss_hash_control);
 
 	ret = ena_com_execute_admin_command(admin_queue,
 					    (struct ena_admin_aq_entry *)&cmd,
-- 
1.8.3.1

[PATCH 2/2] net/ena: fix return of hash control flushing

[Yong Wang]

In function ena_com_set_hash_ctrl(), the return value is assigned to
"ret" variable, but it is not returned. Fix it by adding the return.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
---
 drivers/net/ena/base/ena_com.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index 39356d2..38a0587 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -2278,7 +2278,7 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)
 					    sizeof(resp));
 	if (unlikely(ret)) {
 		ena_trc_err("Failed to set hash input. error: %d\n", ret);
-		ret = ENA_COM_INVAL;
+		return ENA_COM_INVAL;
 	}
 
 	return 0;
-- 
1.8.3.1

Re: [PATCH 2/2] net/ena: fix return of hash control flushing

[Jan Mędala]

Acked-by: Jan Medala <jan@semihalf.com>

  Jan

2017-02-14 13:37 GMT+01:00 Yong Wang <wang.yong19@zte.com.cn>:

> In function ena_com_set_hash_ctrl(), the return value is assigned to
> "ret" variable, but it is not returned. Fix it by adding the return.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  drivers/net/ena/base/ena_com.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_
> com.c
> index 39356d2..38a0587 100644
> --- a/drivers/net/ena/base/ena_com.c
> +++ b/drivers/net/ena/base/ena_com.c
> @@ -2278,7 +2278,7 @@ int ena_com_set_hash_ctrl(struct ena_com_dev
> *ena_dev)
>                                             sizeof(resp));
>         if (unlikely(ret)) {
>                 ena_trc_err("Failed to set hash input. error: %d\n", ret);
> -               ret = ENA_COM_INVAL;
> +               return ENA_COM_INVAL;
>         }
>
>         return 0;
> --
> 1.8.3.1
>
>
>

Re: [PATCH 1/2] net/ena: remove redundant variable

[Jan Mędala]

Acked-by: Jan Medala <jan@semihalf.com>

  Jan

2017-02-14 13:37 GMT+01:00 Yong Wang <wang.yong19@zte.com.cn>:

> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
> ---
>  drivers/net/ena/base/ena_com.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_
> com.c
> index bd6f3c6..39356d2 100644
> --- a/drivers/net/ena/base/ena_com.c
> +++ b/drivers/net/ena/base/ena_com.c
> @@ -2242,7 +2242,6 @@ int ena_com_set_hash_ctrl(struct ena_com_dev
> *ena_dev)
>  {
>         struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;
>         struct ena_rss *rss = &ena_dev->rss;
> -       struct ena_admin_feature_rss_hash_control *hash_ctrl =
> rss->hash_ctrl;
>         struct ena_admin_set_feat_cmd cmd;
>         struct ena_admin_set_feat_resp resp;
>         int ret;
> @@ -2269,7 +2268,8 @@ int ena_com_set_hash_ctrl(struct ena_com_dev
> *ena_dev)
>                 ena_trc_err("memory address set failed\n");
>                 return ret;
>         }
> -       cmd.control_buffer.length = sizeof(*hash_ctrl);
> +       cmd.control_buffer.length =
> +               sizeof(struct ena_admin_feature_rss_hash_control);
>
>         ret = ena_com_execute_admin_command(admin_queue,
>                                             (struct ena_admin_aq_entry
> *)&cmd,
> --
> 1.8.3.1
>
>
>

Re: [PATCH 2/2] net/ena: fix return of hash control flushing

[Ferruh Yigit]

On 3/14/2017 5:59 PM, Jan Mędala wrote:
<...>
>> In function ena_com_set_hash_ctrl(), the return value is assigned to
>> "ret" variable, but it is not returned. Fix it by adding the return.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>

> Acked-by: Jan Medala <jan@semihalf.com>

    Fixes: 99ecfbf845b3 ("ena: import communication layer")
    Cc: stable@dpdk.org

Series applied to dpdk-next-net/master, thanks.