* [meta-oe][PATCH] samba: remove /var/run from package
@ 2013-07-06 12:03 Jonathan Liu
2013-07-07 16:20 ` Martin Jansa
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Liu @ 2013-07-06 12:03 UTC (permalink / raw)
To: openembedded-devel
The /var/run and /var/run/lock directories are already created by
base-files.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
index a27a28c..6bd6644 100644
--- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
+++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
@@ -57,3 +57,8 @@ do_configure() {
do_compile () {
base_do_compile
}
+
+do_install_append() {
+ rm -rf "${D}${localstatedir}/run"
+ rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
+}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-oe][PATCH] samba: remove /var/run from package
2013-07-06 12:03 [meta-oe][PATCH] samba: remove /var/run from package Jonathan Liu
@ 2013-07-07 16:20 ` Martin Jansa
2013-07-08 5:26 ` Jonathan Liu
0 siblings, 1 reply; 3+ messages in thread
From: Martin Jansa @ 2013-07-07 16:20 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
On Sat, Jul 06, 2013 at 10:03:45PM +1000, Jonathan Liu wrote:
> The /var/run and /var/run/lock directories are already created by
> base-files.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> index a27a28c..6bd6644 100644
> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> @@ -57,3 +57,8 @@ do_configure() {
> do_compile () {
> base_do_compile
> }
> +
> +do_install_append() {
> + rm -rf "${D}${localstatedir}/run"
Seems like lock removal is missing here.
samba-3.6.8: samba: Files/directories were installed but not shipped
/run
/run/lock
Thanks a lot for this patchset, now with libdir and infodir QA checks
we'll see a lot more QA issues in world builds, so it's great to have
this /run gone.
> + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
> +}
> --
> 1.8.3.2
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [meta-oe][PATCH] samba: remove /var/run from package
2013-07-07 16:20 ` Martin Jansa
@ 2013-07-08 5:26 ` Jonathan Liu
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Liu @ 2013-07-08 5:26 UTC (permalink / raw)
To: openembedded-devel
On 8 July 2013 02:20, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sat, Jul 06, 2013 at 10:03:45PM +1000, Jonathan Liu wrote:
>> The /var/run and /var/run/lock directories are already created by
>> base-files.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> index a27a28c..6bd6644 100644
>> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> @@ -57,3 +57,8 @@ do_configure() {
>> do_compile () {
>> base_do_compile
>> }
>> +
>> +do_install_append() {
>> + rm -rf "${D}${localstatedir}/run"
>
> Seems like lock removal is missing here.
>
> samba-3.6.8: samba: Files/directories were installed but not shipped
> /run
> /run/lock
>
> Thanks a lot for this patchset, now with libdir and infodir QA checks
> we'll see a lot more QA issues in world builds, so it's great to have
> this /run gone.
>
I have submitted V2 patch for samba. I haven't got around to fixing
nostromo yet.
Regards,
Jonathan
>
>> + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
>> +}
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-08 5:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-06 12:03 [meta-oe][PATCH] samba: remove /var/run from package Jonathan Liu
2013-07-07 16:20 ` Martin Jansa
2013-07-08 5:26 ` Jonathan Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.