All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tim Orling" <ticotimo@gmail.com>
To: Konrad Weihmann <kweihmann@outlook.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2] pypi.bbclass: mind package suffix on version check
Date: Sat, 9 May 2020 14:12:35 -0700	[thread overview]
Message-ID: <CANx9H-DD+Qw3Zb_u53vnL-10-D5BzP0CCXBC1C7gW98=SRZuQg@mail.gmail.com> (raw)
In-Reply-To: <AM7PR05MB68810C07AC538B986CE47C92A8A30@AM7PR05MB6881.eurprd05.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

This version looks good.

On Sat, May 9, 2020 at 1:33 PM Konrad Weihmann <kweihmann@outlook.com>
wrote:

> Some pypi packages do have suffixes like dev, or a0 or b1.
> When doing a version check on these, the version will get falsely
> identified as major release versions.
> Add a terminating slash to rule out those false positives
>
> Changes v2:
>
> - ignore suffix versions instead of reporting them
>
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
>

Reviewed-by: Tim Orling <ticotimo@gmail.com>

---
>  meta/classes/pypi.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/pypi.bbclass b/meta/classes/pypi.bbclass
> index e5d7ab3ce1..ffa8aa3ff4 100644
> --- a/meta/classes/pypi.bbclass
> +++ b/meta/classes/pypi.bbclass
> @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}"
>  S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}"
>
>  UPSTREAM_CHECK_URI ?= "https://pypi.python.org/pypi/${PYPI_PACKAGE}/"
> -UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)"
> +UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)/"
> --
> 2.20.1
>
> 
>

[-- Attachment #2: Type: text/html, Size: 1934 bytes --]

  reply	other threads:[~2020-05-09 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 20:32 [PATCH v2] pypi.bbclass: mind package suffix on version check Konrad Weihmann
2020-05-09 21:12 ` Tim Orling [this message]
     [not found] ` <160D7887899C970D.32017@lists.openembedded.org>
2020-05-09 21:29   ` [OE-core] " Tim Orling
2020-05-10 18:40     ` Denys Dmytriyenko
2020-05-10 18:43       ` Tim Orling
2020-05-10 18:46         ` Denys Dmytriyenko
2020-05-10 10:40 ` Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANx9H-DD+Qw3Zb_u53vnL-10-D5BzP0CCXBC1C7gW98=SRZuQg@mail.gmail.com' \
    --to=ticotimo@gmail.com \
    --cc=kweihmann@outlook.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.