From: "Tim Orling" <ticotimo@gmail.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: Armin Kuster <akuster808@gmail.com>,
"Mittal, Anuj" <anuj.mittal@intel.com>,
Steve Sakoman <steve@sakoman.com>,
openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2] pypi.bbclass: mind package suffix on version check
Date: Sun, 10 May 2020 11:43:59 -0700 [thread overview]
Message-ID: <CANx9H-DDTDXZQcw0A8JkVNS-4Hdsniybgss77_M+20DW4cXtjQ@mail.gmail.com> (raw)
In-Reply-To: <20200510184055.GF11927@denix.org>
[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]
On Sun, May 10, 2020 at 11:41 AM Denys Dmytriyenko <denis@denix.org> wrote:
> On Sat, May 09, 2020 at 02:29:09PM -0700, Tim Orling wrote:
> > This is a candidate for backport to stable once it lands in master.
>
> How so?
>
It fixes a bug in upgrade check. For users that are on stable releases, who
might be maintaining their own python packages, they will be affected by
this.
>
> > On Sat, May 9, 2020 at 2:12 PM Tim Orling via lists.openembedded.org
> > <ticotimo=gmail.com@lists.openembedded.org> wrote:
> >
> > > This version looks good.
> > >
> > > On Sat, May 9, 2020 at 1:33 PM Konrad Weihmann <kweihmann@outlook.com>
> > > wrote:
> > >
> > >> Some pypi packages do have suffixes like dev, or a0 or b1.
> > >> When doing a version check on these, the version will get falsely
> > >> identified as major release versions.
> > >> Add a terminating slash to rule out those false positives
> > >>
> > >> Changes v2:
> > >>
> > >> - ignore suffix versions instead of reporting them
> > >>
> > >> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> > >>
> > >
> > > Reviewed-by: Tim Orling <ticotimo@gmail.com>
> > >
> > > ---
> > >> meta/classes/pypi.bbclass | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/meta/classes/pypi.bbclass b/meta/classes/pypi.bbclass
> > >> index e5d7ab3ce1..ffa8aa3ff4 100644
> > >> --- a/meta/classes/pypi.bbclass
> > >> +++ b/meta/classes/pypi.bbclass
> > >> @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}"
> > >> S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}"
> > >>
> > >> UPSTREAM_CHECK_URI ?= "https://pypi.python.org/pypi/${PYPI_PACKAGE}/
> "
> > >> -UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)"
> > >> +UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)/"
> > >> --
> > >> 2.20.1
> > >>
> > >>
> > >>
> > >
>
> >
>
>
[-- Attachment #2: Type: text/html, Size: 3287 bytes --]
next prev parent reply other threads:[~2020-05-10 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 20:32 [PATCH v2] pypi.bbclass: mind package suffix on version check Konrad Weihmann
2020-05-09 21:12 ` [OE-core] " Tim Orling
[not found] ` <160D7887899C970D.32017@lists.openembedded.org>
2020-05-09 21:29 ` Tim Orling
2020-05-10 18:40 ` Denys Dmytriyenko
2020-05-10 18:43 ` Tim Orling [this message]
2020-05-10 18:46 ` Denys Dmytriyenko
2020-05-10 10:40 ` Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANx9H-DDTDXZQcw0A8JkVNS-4Hdsniybgss77_M+20DW4cXtjQ@mail.gmail.com \
--to=ticotimo@gmail.com \
--cc=akuster808@gmail.com \
--cc=anuj.mittal@intel.com \
--cc=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.