Re: [Buildroot] call with hooks

[Danomi Manchego <danomimanchego123@gmail.com>]

Hu Arnout,

Thanks for the explanation.  I feel better now :)

Danomi -


On Thu, Jan 6, 2022 at 4:39 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 05/01/2022 17:20, Danomi Manchego wrote:
> >   Hello all,
> >
> > I noticed a possible inconsistency, and thought I should post it.
> > Looking at places where buildroot uses hooks:
> >
> > $ grep -r '$(hook))$(sep)' .
>
> [snip]
> >
> > Notice that the one hit in Makefile uses "$($(hook))$(sep)" while the
> > hits in pkg-generic.mk use "$(call $(hook))$(sep)".  My Make-fu isn't
> > powerful enough to understand if there is an actual problem - should
> > there be a "call" in the Makefile line?  The general syntax for call
> > is "$(call variable,param,param,…)" so I don't follow what the extra
> > call in $(call $(hook) is doing for us.
>
>   Historical accident.
>
>   The person who first introduced the hooks back in the days didn't realize that
> $(call ...) is not for "something that looks like a function", but rather it is
> for "whenever you want to pass arguments". Reviewers also didn't realize this
> and just applied, and when more hooks were added later they copied the pattern.
>
>   Regards,
>   Arnout
>
> >
> > Thanks,
> > Danomi -
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot