All of lore.kernel.org
 help / color / mirror / Atom feed
From: Danomi Manchego <danomimanchego123@gmail.com>
To: buildroot <buildroot@buildroot.org>
Subject: [Buildroot] call with hooks
Date: Wed, 5 Jan 2022 11:20:05 -0500	[thread overview]
Message-ID: <CANxTyt77U8pvGxbjHi5MRL5Y3OgafCs_rWNSb=aAY=2BJ0X7ZA@mail.gmail.com> (raw)

 Hello all,

I noticed a possible inconsistency, and thought I should post it.
Looking at places where buildroot uses hooks:

$ grep -r '$(hook))$(sep)' .
./Makefile: $(foreach hook,$(TARGET_FINALIZE_HOOKS),$($(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_DOWNLOAD_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_DOWNLOAD_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_EXTRACT_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_EXTRACT_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_RSYNC_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_PATCH_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_PATCH_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_PREPARE_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_CONFIGURE_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_CONFIGURE_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_BUILD_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_BUILD_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_INSTALL_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_INSTALL_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_INSTALL_STAGING_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_INSTALL_STAGING_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_PRE_INSTALL_TARGET_HOOKS),$(call $(hook))$(sep))
./package/pkg-generic.mk: $(foreach
hook,$($(PKG)_POST_INSTALL_TARGET_HOOKS),$(call $(hook))$(sep))

Notice that the one hit in Makefile uses "$($(hook))$(sep)" while the
hits in pkg-generic.mk use "$(call $(hook))$(sep)".  My Make-fu isn't
powerful enough to understand if there is an actual problem - should
there be a "call" in the Makefile line?  The general syntax for call
is "$(call variable,param,param,…)" so I don't follow what the extra
call in $(call $(hook) is doing for us.

Thanks,
Danomi -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2022-01-05 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 16:20 Danomi Manchego [this message]
2022-01-06  9:39 ` [Buildroot] call with hooks Arnout Vandecappelle
2022-01-06 14:20   ` Danomi Manchego

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANxTyt77U8pvGxbjHi5MRL5Y3OgafCs_rWNSb=aAY=2BJ0X7ZA@mail.gmail.com' \
    --to=danomimanchego123@gmail.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.