[PATCH] create dpkg-deb compatible ipks/opks again

[PATCH] create dpkg-deb compatible ipks/opks again

[Thilo Cestonaro]

With a change from last august in dpkg-deb, the packages generated by opkg-build will not be accepted by dpkg-deb anymore.
The change disallows that the data.tar.gz is packed into the ipk/opk before the control.tar.gz.
For details have a look here:
http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=commitdiff;h=547dca4c3ff23df5dfa554f1943b371cd7056ee4

For details which order is correct, see "man 5 deb", but in short it is:
debian-binary, control.tar.gz and data.tar.gz

Signed-off-by: Thilo Cestonaro <thilo@cestona.ro>
---
 opkg-build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/opkg-build b/opkg-build
index 90a7111..e314712 100755
--- a/opkg-build
+++ b/opkg-build
@@ -247,9 +247,9 @@ fi
 
 rm -f $pkg_file
 if [ "$outer" = "ar" ] ; then
-  ( cd $tmp_dir && ar -crf $pkg_file ./debian-binary ./data.tar.gz ./control.tar.gz )
+  ( cd $tmp_dir && ar -crf $pkg_file ./debian-binary ./control.tar.gz ./data.tar.gz )
 else
-  ( cd $tmp_dir && tar -cz --format=gnu -f $pkg_file ./debian-binary ./data.tar.gz ./control.tar.gz )
+  ( cd $tmp_dir && tar -cz --format=gnu -f $pkg_file ./debian-binary ./control.tar.gz ./data.tar.gz )
 fi
 
 rm $tmp_dir/debian-binary $tmp_dir/data.tar.gz $tmp_dir/control.tar.gz
-- 
1.8.3.2

Re: [PATCH] create dpkg-deb compatible ipks/opks again

[Paul Barker]

On 25 February 2014 20:26, Thilo Cestonaro <thilo@cestona.ro> wrote:
> With a change from last august in dpkg-deb, the packages generated by opkg-build will not be accepted by dpkg-deb anymore.
> The change disallows that the data.tar.gz is packed into the ipk/opk before the control.tar.gz.
> For details have a look here:
> http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=commitdiff;h=547dca4c3ff23df5dfa554f1943b371cd7056ee4
>
> For details which order is correct, see "man 5 deb", but in short it is:
> debian-binary, control.tar.gz and data.tar.gz
>
> Signed-off-by: Thilo Cestonaro <thilo@cestona.ro>

I've slightly modified the subject line to "opkg-build: create
dpkg-deb compatible ipks/opks again" so that we can see in the
shortlog that this relates to opkg-build.

And for future reference, yocto@yoctoproject.org gets patches for
several sub-projects. For opkg-utils try to use something like
`--subject-prefix='opkg-utils PATCH'` when creating your patch.

I'm testing the patch now just to ensure opkg can still use the ipk
files created with this patch applied, I don't forsee any problems
though. Once it's been tested I'll merge this to the main opkg-utils
repository and update the recipe in openembedded-core to use the new
commit.

Cheers,

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

Re: [PATCH] create dpkg-deb compatible ipks/opks again

[Paul Barker]

On 1 March 2014 14:29, Paul Barker <paul@paulbarker.me.uk> wrote:
> On 25 February 2014 20:26, Thilo Cestonaro <thilo@cestona.ro> wrote:
>> With a change from last august in dpkg-deb, the packages generated by opkg-build will not be accepted by dpkg-deb anymore.
>> The change disallows that the data.tar.gz is packed into the ipk/opk before the control.tar.gz.
>> For details have a look here:
>> http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=commitdiff;h=547dca4c3ff23df5dfa554f1943b371cd7056ee4
>>
>> For details which order is correct, see "man 5 deb", but in short it is:
>> debian-binary, control.tar.gz and data.tar.gz
>>
>> Signed-off-by: Thilo Cestonaro <thilo@cestona.ro>
>
> I've slightly modified the subject line to "opkg-build: create
> dpkg-deb compatible ipks/opks again" so that we can see in the
> shortlog that this relates to opkg-build.
>

Tested and merged!

The recipe in openembedded-core
(meta/recipes-devtools/opkg-utils/opkg-utils_git.bb) now needs
updating to reference the new commit ID. Would you like to create a
patch for that or shall I do it?

Thanks,

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

Re: [PATCH] create dpkg-deb compatible ipks/opks again

[Paul Barker]

On 3 March 2014 09:02, Paul Barker <paul@paulbarker.me.uk> wrote:
> On 1 March 2014 14:29, Paul Barker <paul@paulbarker.me.uk> wrote:
>> On 25 February 2014 20:26, Thilo Cestonaro <thilo@cestona.ro> wrote:
>>> With a change from last august in dpkg-deb, the packages generated by opkg-build will not be accepted by dpkg-deb anymore.
>>> The change disallows that the data.tar.gz is packed into the ipk/opk before the control.tar.gz.
>>> For details have a look here:
>>> http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=commitdiff;h=547dca4c3ff23df5dfa554f1943b371cd7056ee4
>>>
>>> For details which order is correct, see "man 5 deb", but in short it is:
>>> debian-binary, control.tar.gz and data.tar.gz
>>>
>>> Signed-off-by: Thilo Cestonaro <thilo@cestona.ro>
>>
>> I've slightly modified the subject line to "opkg-build: create
>> dpkg-deb compatible ipks/opks again" so that we can see in the
>> shortlog that this relates to opkg-build.
>>
>
> Tested and merged!
>
> The recipe in openembedded-core
> (meta/recipes-devtools/opkg-utils/opkg-utils_git.bb) now needs
> updating to reference the new commit ID. Would you like to create a
> patch for that or shall I do it?
>

I've just submitted a patch to the oe-core mailing list myself to do this.

Cheers,

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

Re: [PATCH] create dpkg-deb compatible ipks/opks again

[Thilo Cestonaro]

>>
>> Tested and merged!
>>
>> The recipe in openembedded-core
>> (meta/recipes-devtools/opkg-utils/opkg-utils_git.bb) now needs
>> updating to reference the new commit ID. Would you like to create a
>> patch for that or shall I do it?
>>
> 
> I've just submitted a patch to the oe-core mailing list myself to do this.
> 
> Cheers,
> 
Thanks a lot. I was in vacation without access to my mail.

Cheers,
Thilo