* [PATCH 1/2] Input: add KEY_KBD_LAYOUT_NEXT
@ 2019-04-25 16:38 Dmitry Torokhov
2019-04-25 16:38 ` [PATCH 2/2] HID: input: add mapping for KEY_KBD_LAYOUT_NEXT Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2019-04-25 16:38 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-input, linux-kernel, gwink
The HID usage tables define a key to cycle through a set of keyboard
layouts, let's add corresponding keycode.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
include/uapi/linux/input-event-codes.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index 64cee116928e..85387c76c24f 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -606,6 +606,7 @@
#define KEY_SCREENSAVER 0x245 /* AL Screen Saver */
#define KEY_VOICECOMMAND 0x246 /* Listening Voice Command */
#define KEY_ASSISTANT 0x247 /* AL Context-aware desktop assistant */
+#define KEY_KBD_LAYOUT_NEXT 0x248 /* AC Next Keyboard Layout Select */
#define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */
#define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] HID: input: add mapping for KEY_KBD_LAYOUT_NEXT
2019-04-25 16:38 [PATCH 1/2] Input: add KEY_KBD_LAYOUT_NEXT Dmitry Torokhov
@ 2019-04-25 16:38 ` Dmitry Torokhov
2019-04-26 6:38 ` Benjamin Tissoires
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2019-04-25 16:38 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-input, linux-kernel, gwink
HUTRR56 defined a new usage code on consumer page to cycle through
set of keyboard layouts, let's add this mapping.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/hid/hid-input.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index b607286a0bc8..0579b8d3f912 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1051,6 +1051,8 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
case 0x28b: map_key_clear(KEY_FORWARDMAIL); break;
case 0x28c: map_key_clear(KEY_SEND); break;
+ case 0x29d: map_key_clear(KEY_KBD_LAYOUT_NEXT); break;
+
case 0x2c7: map_key_clear(KEY_KBDINPUTASSIST_PREV); break;
case 0x2c8: map_key_clear(KEY_KBDINPUTASSIST_NEXT); break;
case 0x2c9: map_key_clear(KEY_KBDINPUTASSIST_PREVGROUP); break;
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] HID: input: add mapping for KEY_KBD_LAYOUT_NEXT
2019-04-25 16:38 ` [PATCH 2/2] HID: input: add mapping for KEY_KBD_LAYOUT_NEXT Dmitry Torokhov
@ 2019-04-26 6:38 ` Benjamin Tissoires
2019-04-26 23:33 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Tissoires @ 2019-04-26 6:38 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Jiri Kosina, open list:HID CORE LAYER, lkml, gwink
On Thu, Apr 25, 2019 at 6:38 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> HUTRR56 defined a new usage code on consumer page to cycle through
> set of keyboard layouts, let's add this mapping.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
I don't think this will collide with the HID tree, so IMO, you can
take this through yours if you want.
Cheers,
Benjamin
> drivers/hid/hid-input.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index b607286a0bc8..0579b8d3f912 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1051,6 +1051,8 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> case 0x28b: map_key_clear(KEY_FORWARDMAIL); break;
> case 0x28c: map_key_clear(KEY_SEND); break;
>
> + case 0x29d: map_key_clear(KEY_KBD_LAYOUT_NEXT); break;
> +
> case 0x2c7: map_key_clear(KEY_KBDINPUTASSIST_PREV); break;
> case 0x2c8: map_key_clear(KEY_KBDINPUTASSIST_NEXT); break;
> case 0x2c9: map_key_clear(KEY_KBDINPUTASSIST_PREVGROUP); break;
> --
> 2.21.0.593.g511ec345e18-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] HID: input: add mapping for KEY_KBD_LAYOUT_NEXT
2019-04-26 6:38 ` Benjamin Tissoires
@ 2019-04-26 23:33 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2019-04-26 23:33 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Jiri Kosina, open list:HID CORE LAYER, lkml, gwink
On Fri, Apr 26, 2019 at 08:38:29AM +0200, Benjamin Tissoires wrote:
> On Thu, Apr 25, 2019 at 6:38 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > HUTRR56 defined a new usage code on consumer page to cycle through
> > set of keyboard layouts, let's add this mapping.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
>
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> I don't think this will collide with the HID tree, so IMO, you can
> take this through yours if you want.
OK, I will do that, thanks!
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-26 23:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25 16:38 [PATCH 1/2] Input: add KEY_KBD_LAYOUT_NEXT Dmitry Torokhov
2019-04-25 16:38 ` [PATCH 2/2] HID: input: add mapping for KEY_KBD_LAYOUT_NEXT Dmitry Torokhov
2019-04-26 6:38 ` Benjamin Tissoires
2019-04-26 23:33 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.