[PATCH v2 0/3] bockw SD pull-ups

[PATCH v2 0/3] bockw SD pull-ups

[Ulrich Hecht]

Hi!

This series implements pull-up configuration in the r8a7778 PFC driver
and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
replacing the hack that is used in the legacy platforms.

This revision uses bitfields for the pull-up table, reducing its size to 310
bytes, and demotes undefined pull-ups from a bug to a warning.

CU
Uli

Changes since v1:
- use bitfields for pull-up table
- WARN_ON_ONCE instead of BUG_ON on undefined pull-ups


Ulrich Hecht (3):
  pinctrl: sh-pfc: add macros defining GP ports with config flags
  pinctrl: sh-pfc: r8a7778: Add bias (pull-up) pinconf support
  ARM: shmobile: bockw dts: define sdhi0 pins with pull-ups

 arch/arm/boot/dts/r8a7778-bockw.dts  |  10 +-
 drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 259 ++++++++++++++++++++++++++++++++---
 drivers/pinctrl/sh-pfc/sh_pfc.h      |  47 ++++---
 3 files changed, 270 insertions(+), 46 deletions(-)

-- 
2.4.6

Re: [PATCH v2 0/3] bockw SD pull-ups

[Simon Horman]

Hi Ulrich,

On Fri, Jul 24, 2015 at 05:21:54PM +0200, Ulrich Hecht wrote:
> Hi!
> 
> This series implements pull-up configuration in the r8a7778 PFC driver
> and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
> replacing the hack that is used in the legacy platforms.
> 
> This revision uses bitfields for the pull-up table, reducing its size to 310
> bytes, and demotes undefined pull-ups from a bug to a warning.

I am wondering if these patches create any forwards/backwards compatibility
issues if the kernel and DT are not upgraded simultaneously.

Re: [PATCH v2 0/3] bockw SD pull-ups

[Ulrich Hecht]

On Mon, Jul 27, 2015 at 3:09 AM, Simon Horman <horms@verge.net.au> wrote:
> Hi Ulrich,
>
> On Fri, Jul 24, 2015 at 05:21:54PM +0200, Ulrich Hecht wrote:
>> Hi!
>>
>> This series implements pull-up configuration in the r8a7778 PFC driver
>> and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
>> replacing the hack that is used in the legacy platforms.
>>
>> This revision uses bitfields for the pull-up table, reducing its size to 310
>> bytes, and demotes undefined pull-ups from a bug to a warning.
>
> I am wondering if these patches create any forwards/backwards compatibility
> issues if the kernel and DT are not upgraded simultaneously.

I don't think so.  The driver support without the DT changes will not
do anything.  DT changes without driver support will yield an error
message, but other than that it should not have any detrimental
effect.

CU
Uli

Re: [PATCH v2 0/3] bockw SD pull-ups

[Simon Horman]

Hi Ulrich,

On Mon, Jul 27, 2015 at 06:30:39PM +0200, Ulrich Hecht wrote:
> On Mon, Jul 27, 2015 at 3:09 AM, Simon Horman <horms@verge.net.au> wrote:
> > Hi Ulrich,
> >
> > On Fri, Jul 24, 2015 at 05:21:54PM +0200, Ulrich Hecht wrote:
> >> Hi!
> >>
> >> This series implements pull-up configuration in the r8a7778 PFC driver
> >> and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
> >> replacing the hack that is used in the legacy platforms.
> >>
> >> This revision uses bitfields for the pull-up table, reducing its size to 310
> >> bytes, and demotes undefined pull-ups from a bug to a warning.
> >
> > I am wondering if these patches create any forwards/backwards compatibility
> > issues if the kernel and DT are not upgraded simultaneously.
> 
> I don't think so.  The driver support without the DT changes will not
> do anything.  DT changes without driver support will yield an error
> message, but other than that it should not have any detrimental
> effect.

Thanks, in that case I'm happy with these changes from
an integration point of view.

I will defer the shmobile patch (3/3) pending acceptance
of the pinctl patches (1/3, 2/3). Please let me know if/when the
pinctl patches have been accepted as I should be able to queue
up the shmobile patch straight away.

Re: [PATCH v2 0/3] bockw SD pull-ups

[Linus Walleij]

On Fri, Jul 24, 2015 at 5:21 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:

> This series implements pull-up configuration in the r8a7778 PFC driver
> and sets the SD0_WP and SD0_CD pull-ups on the Bock-W board correctly,
> replacing the hack that is used in the legacy platforms.
>
> This revision uses bitfields for the pull-up table, reducing its size to 310
> bytes, and demotes undefined pull-ups from a bug to a warning.

I am waiting for Laurent's review on these. Laurent?

Yours,
Linus Walleij