Re: [Powertop] [PATCH] use pkg-config to find ncurses

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Wout Mertens]

[-- Attachment #1: Type: text/plain, Size: 5906 bytes --]

I'm confused, how does requiring a pkgconfig file break the tool?

If a user somehow finds them in a situation where they need to build a
recent powertop but can't build a recent ncurses, they can manually add the
file... Or use an older version of powertop...
On May 6, 2014 1:20 AM, "Alexandra Yates" <alexandra.yates(a)linux.intel.com>
wrote:

>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 04/25/2014 07:58 PM, Alexandra Yates wrote:
> >> Hi Zero,
> >>
> >> Based on Sergey's feedback can you send a revision for your patches?
> >>
> >> thank you,
> >> Alex
> >> On 04/16/2014 03:54 PM, Sergey Senozhatsky wrote:
> >>>>> On (04/16/14 12:41), Kok, Auke-jan H wrote:
> >>>>>> ncurses by itself does not provide a pkgconfig check, it is however
> >>>>>> manually added by various distributions, but not all of them.
> >>>>>>
> >>>>>> So, the patch below breaks building powertop for those
> >>>>>> distributions.
> >>>>>>
> >>>>>
> >>>>> yes. good point. apparently ncurses provides pkg-config files these
> >>>>> days.
> >>>>> but there still may be distributions that use older ncurses versions.
> >>
> >>
> >> pkgconfig support was added on 20090103 according to the changelog here:
> >> http://invisible-island.net/ncurses/NEWS.html.
> >>
> >> Is is really a major concern to to require a version of ncurses released
> >> within the last 5 years?
> >
> > I believe these comments stand for themselves.  If a user isn't on a
> > modern ncurses I fail to see why they would be on a modern powertop
> > either.  Supporting things >5 years old building against modern things
> > is past my point of caring.  If someone else would like to amend the
> > patch to fall back to hardcoded libs that's fine, but I'm not going to
> > invest my time in this.  Sadly, my autotools skills are unimpressive and
> > there is no justification for the amount of time this would take me.
> >
> > Accept the patch, don't accept the patch, modify the patch as you see
> > fit, whatever you like.
> >
> > Thanks,
> > Zero
>
> Hi Zero,
>
> Unfortunately, at the moment I don't have the bandwidth to fix your patch.
>
> Additionally, PowerTOP doesn't accept patches that break the tool, even if
> that is in older technologies.  Therefore, I'm simply rejecting your
> submission.
>
> Thank you,
> Alexandra.
>
>
> >>
> >> -Zero
> >>>>>
> >>>>>   -ss
> >>>>>
> >>>>>> I suggest that if you really want to make it use pkg-config, you
> >>>>>> write
> >>>>>> it in such a way that if pkg-config checking fails, it will still
> >>>>>> attempt to search for the appropriate libs instead.
> >>>>>>
> >>>>>> Auke
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Wed, Apr 16, 2014 at 8:20 AM, Rick "Zero_Chaos" Farina
> >>>>>> <zerochaos(a)gentoo.org> wrote:
> >>>>> Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124
> >>>>>
> >>>>> Depending on how ncurses is built, it may require different
> >>>>> information
> >>>>> passed to the linker.  Use pkg-config to detect the correct
> >>>>> information:
> >>>>>
> >>>>> --- a/configure.ac
> >>>>> +++ b/configure.ac
> >>>>> @@ -46,7 +46,7 @@
> >>>>>  AC_FUNC_STRTOD
> >>>>>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset
> >>>>> mkdir
> >>>>> munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
> >>>>> strchr strdup strerror strncasecmp strstr strtoul strtoull])
> >>>>>
> >>>>> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [],
> >>>>> AC_MSG_ERROR([ncurses
> >>>>> is required but was not found]), [])
> >>>>> +PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
> >>>>> AC_MSG_ERROR([ncurses is required but was not found]))
> >>>>>
> >>>>>  has_libpci=0
> >>>>>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
> >>>>>
> >>>>>
> >>>>> Original patch:
> >>>>>
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup
> >>>>>
> >>>>> Please include this fix.
> >>>>>
> >>>>> thanks,
> >>>>> Zero
> >>>>>>> _______________________________________________
> >>>>>>> PowerTop mailing list
> >>>>>>> PowerTop(a)lists.01.org
> >>>>>>> https://lists.01.org/mailman/listinfo/powertop
> >>>>>> _______________________________________________
> >>>>>> PowerTop mailing list
> >>>>>> PowerTop(a)lists.01.org
> >>>>>> https://lists.01.org/mailman/listinfo/powertop
> >>>>>>
> >>>>>
> >>
> >>> _______________________________________________
> >>> PowerTop mailing list
> >>> PowerTop(a)lists.01.org
> >>> https://lists.01.org/mailman/listinfo/powertop
> >>>
> >>
> >>
> >> Thank you,
> >> Alexandra.
> >>
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2.0.22 (GNU/Linux)
> > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> >
> > iQIcBAEBAgAGBQJTX7T7AAoJEKXdFCfdEflKMpwP/A3ajGdX9nzIN9qelCT6B1Zh
> > EfwGI+aNQ+ae9GP7BMYx9Dzirrg7g///cTv3oXxnSpX4XiQIj7oozwLOF1DgEcs8
> > XdmoTSONx6gEiGlYU60jrMKokml+bJoABxM4R6tBMYM2XUD+Zx28TdM76SCx2cGq
> > CiWI6dvK7x5afyLbrjRtNvkBQ2k5qMej4s/4fDC/yr1XNvaLxEq4RQyohF+5dAk8
> > T9rD6Yq0B8EvyrXT09TD03cNm/GH+I4Fzuo/h7Ivun10TM40nsXHuNq67LPhYgVa
> > ox28MsyRcaRnHyoPzuuMOhz+/QIeUgDHOu1lTFBDNcJgCuox+OPf1O9flw/HTEZ/
> > +YQewdYIgjIiv9tVjwdvXlkr/JSgCl0CdjaJT6MN+VhXz2aMdyQh9TV5Ph8+KBIH
> > 3+R3pUGKh+mTEyJ5mwBXMsL9jqQa8TTwFp9OGRjmnqyvyqRJ7z4CRQrnLRfS+D99
> > 5FaZkS2NL/5XDnLAZcNqrRkV4w+UFjuJK5yrZxiYWXgX1n6IqX8eY8Q66SMfBRMG
> > 6XKtGD53ku7DV6H+/dlfzOZTD8B+emOJQXprT5O9/QPX1R1bbpC3DSEzMTadtRPi
> > CVhMEPfdY/UllH+pIAVNP3ORo4vgRJwOfZNhcqLke7sDrSjqTa5KnAbjb+4Qb5nK
> > nBQKYIQfN92Mb7fxF3ve
> > =dGdt
> > -----END PGP SIGNATURE-----
> >
>
>
> Thank you,
> Alexandra.
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 8798 bytes --]

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Kok, Auke-jan H]

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

On Mon, May 5, 2014 at 9:57 PM, Wout Mertens <wout.mertens(a)gmail.com> wrote:
> I'm confused, how does requiring a pkgconfig file break the tool?

I'm sure Alexandra means "breaks people's builds".

> If a user somehow finds them in a situation where they need to build a
> recent powertop but can't build a recent ncurses, they can manually add the
> file... Or use an older version of powertop...

The problem is that someone found a simple problem, and made a
somewhat simplified fix that creates a regression for others.
Introducing regressions, especially in something as simple as the
autotools code shouldn't be needed.

Someone just has to come up with a clean way to make both the old
ncurses (that does not have pkgconfig) and the new version work at the
same time, that's all.

BTW, I'm not sure where the 2009 number comes from, but there are
plenty of people still building against ncurses-5.9, and that has no
pkgconfig file, so the proposed patch actually fixes _my_ build of
powertop. (sure, you can complain I run ancient code, I certainly
concede that).

Asking people to create a pkgconfig file out of thin air is... not
appropriate ;^)

I'll send a tentative patch in a second that I think should solve the
problem correctly.

Auke

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 5098 bytes --]


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 04/25/2014 07:58 PM, Alexandra Yates wrote:
>> Hi Zero,
>>
>> Based on Sergey's feedback can you send a revision for your patches?
>>
>> thank you,
>> Alex
>> On 04/16/2014 03:54 PM, Sergey Senozhatsky wrote:
>>>>> On (04/16/14 12:41), Kok, Auke-jan H wrote:
>>>>>> ncurses by itself does not provide a pkgconfig check, it is however
>>>>>> manually added by various distributions, but not all of them.
>>>>>>
>>>>>> So, the patch below breaks building powertop for those
>>>>>> distributions.
>>>>>>
>>>>>
>>>>> yes. good point. apparently ncurses provides pkg-config files these
>>>>> days.
>>>>> but there still may be distributions that use older ncurses versions.
>>
>>
>> pkgconfig support was added on 20090103 according to the changelog here:
>> http://invisible-island.net/ncurses/NEWS.html.
>>
>> Is is really a major concern to to require a version of ncurses released
>> within the last 5 years?
>
> I believe these comments stand for themselves.  If a user isn't on a
> modern ncurses I fail to see why they would be on a modern powertop
> either.  Supporting things >5 years old building against modern things
> is past my point of caring.  If someone else would like to amend the
> patch to fall back to hardcoded libs that's fine, but I'm not going to
> invest my time in this.  Sadly, my autotools skills are unimpressive and
> there is no justification for the amount of time this would take me.
>
> Accept the patch, don't accept the patch, modify the patch as you see
> fit, whatever you like.
>
> Thanks,
> Zero

Hi Zero,

Unfortunately, at the moment I don't have the bandwidth to fix your patch.

Additionally, PowerTOP doesn't accept patches that break the tool, even if
that is in older technologies.  Therefore, I'm simply rejecting your
submission.

Thank you,
Alexandra.


>>
>> -Zero
>>>>>
>>>>> 	-ss
>>>>>
>>>>>> I suggest that if you really want to make it use pkg-config, you
>>>>>> write
>>>>>> it in such a way that if pkg-config checking fails, it will still
>>>>>> attempt to search for the appropriate libs instead.
>>>>>>
>>>>>> Auke
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Apr 16, 2014 at 8:20 AM, Rick "Zero_Chaos" Farina
>>>>>> <zerochaos(a)gentoo.org> wrote:
>>>>> Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124
>>>>>
>>>>> Depending on how ncurses is built, it may require different
>>>>> information
>>>>> passed to the linker.  Use pkg-config to detect the correct
>>>>> information:
>>>>>
>>>>> --- a/configure.ac
>>>>> +++ b/configure.ac
>>>>> @@ -46,7 +46,7 @@
>>>>>  AC_FUNC_STRTOD
>>>>>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset
>>>>> mkdir
>>>>> munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
>>>>> strchr strdup strerror strncasecmp strstr strtoul strtoull])
>>>>>
>>>>> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [],
>>>>> AC_MSG_ERROR([ncurses
>>>>> is required but was not found]), [])
>>>>> +PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
>>>>> AC_MSG_ERROR([ncurses is required but was not found]))
>>>>>
>>>>>  has_libpci=0
>>>>>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
>>>>>
>>>>>
>>>>> Original patch:
>>>>> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup
>>>>>
>>>>> Please include this fix.
>>>>>
>>>>> thanks,
>>>>> Zero
>>>>>>> _______________________________________________
>>>>>>> PowerTop mailing list
>>>>>>> PowerTop(a)lists.01.org
>>>>>>> https://lists.01.org/mailman/listinfo/powertop
>>>>>> _______________________________________________
>>>>>> PowerTop mailing list
>>>>>> PowerTop(a)lists.01.org
>>>>>> https://lists.01.org/mailman/listinfo/powertop
>>>>>>
>>>>>
>>
>>> _______________________________________________
>>> PowerTop mailing list
>>> PowerTop(a)lists.01.org
>>> https://lists.01.org/mailman/listinfo/powertop
>>>
>>
>>
>> Thank you,
>> Alexandra.
>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJTX7T7AAoJEKXdFCfdEflKMpwP/A3ajGdX9nzIN9qelCT6B1Zh
> EfwGI+aNQ+ae9GP7BMYx9Dzirrg7g///cTv3oXxnSpX4XiQIj7oozwLOF1DgEcs8
> XdmoTSONx6gEiGlYU60jrMKokml+bJoABxM4R6tBMYM2XUD+Zx28TdM76SCx2cGq
> CiWI6dvK7x5afyLbrjRtNvkBQ2k5qMej4s/4fDC/yr1XNvaLxEq4RQyohF+5dAk8
> T9rD6Yq0B8EvyrXT09TD03cNm/GH+I4Fzuo/h7Ivun10TM40nsXHuNq67LPhYgVa
> ox28MsyRcaRnHyoPzuuMOhz+/QIeUgDHOu1lTFBDNcJgCuox+OPf1O9flw/HTEZ/
> +YQewdYIgjIiv9tVjwdvXlkr/JSgCl0CdjaJT6MN+VhXz2aMdyQh9TV5Ph8+KBIH
> 3+R3pUGKh+mTEyJ5mwBXMsL9jqQa8TTwFp9OGRjmnqyvyqRJ7z4CRQrnLRfS+D99
> 5FaZkS2NL/5XDnLAZcNqrRkV4w+UFjuJK5yrZxiYWXgX1n6IqX8eY8Q66SMfBRMG
> 6XKtGD53ku7DV6H+/dlfzOZTD8B+emOJQXprT5O9/QPX1R1bbpC3DSEzMTadtRPi
> CVhMEPfdY/UllH+pIAVNP3ORo4vgRJwOfZNhcqLke7sDrSjqTa5KnAbjb+4Qb5nK
> nBQKYIQfN92Mb7fxF3ve
> =dGdt
> -----END PGP SIGNATURE-----
>


Thank you,
Alexandra.

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Rick Zero_Chaos Farina]

[-- Attachment #1: Type: text/plain, Size: 4593 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/25/2014 07:58 PM, Alexandra Yates wrote:
> Hi Zero,
> 
> Based on Sergey's feedback can you send a revision for your patches?
> 
> thank you,
> Alex
> On 04/16/2014 03:54 PM, Sergey Senozhatsky wrote:
>>>> On (04/16/14 12:41), Kok, Auke-jan H wrote:
>>>>> ncurses by itself does not provide a pkgconfig check, it is however
>>>>> manually added by various distributions, but not all of them.
>>>>>
>>>>> So, the patch below breaks building powertop for those distributions.
>>>>>
>>>>
>>>> yes. good point. apparently ncurses provides pkg-config files these
>>>> days.
>>>> but there still may be distributions that use older ncurses versions.
> 
> 
> pkgconfig support was added on 20090103 according to the changelog here:
> http://invisible-island.net/ncurses/NEWS.html.
> 
> Is is really a major concern to to require a version of ncurses released
> within the last 5 years?

I believe these comments stand for themselves.  If a user isn't on a
modern ncurses I fail to see why they would be on a modern powertop
either.  Supporting things >5 years old building against modern things
is past my point of caring.  If someone else would like to amend the
patch to fall back to hardcoded libs that's fine, but I'm not going to
invest my time in this.  Sadly, my autotools skills are unimpressive and
there is no justification for the amount of time this would take me.

Accept the patch, don't accept the patch, modify the patch as you see
fit, whatever you like.

Thanks,
Zero
> 
> -Zero
>>>>
>>>> 	-ss
>>>>
>>>>> I suggest that if you really want to make it use pkg-config, you write
>>>>> it in such a way that if pkg-config checking fails, it will still
>>>>> attempt to search for the appropriate libs instead.
>>>>>
>>>>> Auke
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Apr 16, 2014 at 8:20 AM, Rick "Zero_Chaos" Farina
>>>>> <zerochaos(a)gentoo.org> wrote:
>>>> Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124
>>>>
>>>> Depending on how ncurses is built, it may require different information
>>>> passed to the linker.  Use pkg-config to detect the correct information:
>>>>
>>>> --- a/configure.ac
>>>> +++ b/configure.ac
>>>> @@ -46,7 +46,7 @@
>>>>  AC_FUNC_STRTOD
>>>>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir
>>>> munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
>>>> strchr strdup strerror strncasecmp strstr strtoul strtoull])
>>>>
>>>> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses
>>>> is required but was not found]), [])
>>>> +PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
>>>> AC_MSG_ERROR([ncurses is required but was not found]))
>>>>
>>>>  has_libpci=0
>>>>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
>>>>
>>>>
>>>> Original patch:
>>>> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup
>>>>
>>>> Please include this fix.
>>>>
>>>> thanks,
>>>> Zero
>>>>>> _______________________________________________
>>>>>> PowerTop mailing list
>>>>>> PowerTop(a)lists.01.org
>>>>>> https://lists.01.org/mailman/listinfo/powertop
>>>>> _______________________________________________
>>>>> PowerTop mailing list
>>>>> PowerTop(a)lists.01.org
>>>>> https://lists.01.org/mailman/listinfo/powertop
>>>>>
>>>>
> 
>> _______________________________________________
>> PowerTop mailing list
>> PowerTop(a)lists.01.org
>> https://lists.01.org/mailman/listinfo/powertop
>>
> 
> 
> Thank you,
> Alexandra.
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTX7T7AAoJEKXdFCfdEflKMpwP/A3ajGdX9nzIN9qelCT6B1Zh
EfwGI+aNQ+ae9GP7BMYx9Dzirrg7g///cTv3oXxnSpX4XiQIj7oozwLOF1DgEcs8
XdmoTSONx6gEiGlYU60jrMKokml+bJoABxM4R6tBMYM2XUD+Zx28TdM76SCx2cGq
CiWI6dvK7x5afyLbrjRtNvkBQ2k5qMej4s/4fDC/yr1XNvaLxEq4RQyohF+5dAk8
T9rD6Yq0B8EvyrXT09TD03cNm/GH+I4Fzuo/h7Ivun10TM40nsXHuNq67LPhYgVa
ox28MsyRcaRnHyoPzuuMOhz+/QIeUgDHOu1lTFBDNcJgCuox+OPf1O9flw/HTEZ/
+YQewdYIgjIiv9tVjwdvXlkr/JSgCl0CdjaJT6MN+VhXz2aMdyQh9TV5Ph8+KBIH
3+R3pUGKh+mTEyJ5mwBXMsL9jqQa8TTwFp9OGRjmnqyvyqRJ7z4CRQrnLRfS+D99
5FaZkS2NL/5XDnLAZcNqrRkV4w+UFjuJK5yrZxiYWXgX1n6IqX8eY8Q66SMfBRMG
6XKtGD53ku7DV6H+/dlfzOZTD8B+emOJQXprT5O9/QPX1R1bbpC3DSEzMTadtRPi
CVhMEPfdY/UllH+pIAVNP3ORo4vgRJwOfZNhcqLke7sDrSjqTa5KnAbjb+4Qb5nK
nBQKYIQfN92Mb7fxF3ve
=dGdt
-----END PGP SIGNATURE-----

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Alexandra Yates]

[-- Attachment #1: Type: text/plain, Size: 3813 bytes --]

Hi Zero,

Based on Sergey's feedback can you send a revision for your patches?

thank you,
Alex
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 04/16/2014 03:54 PM, Sergey Senozhatsky wrote:
>> On (04/16/14 12:41), Kok, Auke-jan H wrote:
>>> ncurses by itself does not provide a pkgconfig check, it is however
>>> manually added by various distributions, but not all of them.
>>>
>>> So, the patch below breaks building powertop for those distributions.
>>>
>>
>> yes. good point. apparently ncurses provides pkg-config files these
>> days.
>> but there still may be distributions that use older ncurses versions.
>
>
> pkgconfig support was added on 20090103 according to the changelog here:
> http://invisible-island.net/ncurses/NEWS.html.
>
> Is is really a major concern to to require a version of ncurses released
> within the last 5 years?
>
> - -Zero
>>
>> 	-ss
>>
>>> I suggest that if you really want to make it use pkg-config, you write
>>> it in such a way that if pkg-config checking fails, it will still
>>> attempt to search for the appropriate libs instead.
>>>
>>> Auke
>>>
>>>
>>>
>>> On Wed, Apr 16, 2014 at 8:20 AM, Rick "Zero_Chaos" Farina
>>> <zerochaos(a)gentoo.org> wrote:
>> Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124
>>
>> Depending on how ncurses is built, it may require different information
>> passed to the linker.  Use pkg-config to detect the correct information:
>>
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -46,7 +46,7 @@
>>  AC_FUNC_STRTOD
>>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir
>> munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
>> strchr strdup strerror strncasecmp strstr strtoul strtoull])
>>
>> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses
>> is required but was not found]), [])
>> +PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
>> AC_MSG_ERROR([ncurses is required but was not found]))
>>
>>  has_libpci=0
>>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
>>
>>
>> Original patch:
>> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup
>>
>> Please include this fix.
>>
>> thanks,
>> Zero
>>>> _______________________________________________
>>>> PowerTop mailing list
>>>> PowerTop(a)lists.01.org
>>>> https://lists.01.org/mailman/listinfo/powertop
>>> _______________________________________________
>>> PowerTop mailing list
>>> PowerTop(a)lists.01.org
>>> https://lists.01.org/mailman/listinfo/powertop
>>>
>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJTTvA1AAoJEKXdFCfdEflK/VYP/2D9II4S6BMw/1flPtHfj5Yn
> 2L+iy9KpIbRAaV0n6XI4/0ppGM+21xXbw372z56ne/MBKqJD0TCOF2AyHhD/178U
> oNkTjAt0aJuToO/IDZAR5Q4oD8KXQAO67lsH+VHkuV3R93hpxQ49COaGnPW62TvR
> I3nBRJMiqN6sixQa5M5wT2OlQz9mzs7GxEt2VeRXNHtoLAvPScJYM6p1v1An/Vcz
> a6YvLmKB0S5t5m3a8Nc7EAvcqJNgnKKtMBgfv8d6zi5ueFtdn4TxAKxqXZeNpgiV
> uY/lKa1Ycz924ftd+iLTAf6q3H6PVY7GJnYbRXZ7niz0PqXtExgOmZ6JonZIhdBC
> +TX161fjRQYjTf6JjwMYzKTc4Vx9lUjX4f/0jsPDmC/Wu0NcDL8GbBqP45AYIktX
> I1uo6vDqglxg6vQDL3OrL+6oolDITfJaSTFFZ7QezdyA9uflCR9uQaCbnJ7zKCF/
> acD1Vh9gabRQw2Mq1n9ATB9mpuFUESclVz6Xs/PCiWCTLM5XyIhfUU/RCeOEjG2j
> ooEx999sAlrdjK5WH+chL1A/yQyamcfuH8cQmOO2p7o70Z6++/u18OdwbCRkgioe
> 87LaoT2VRwNAcQhR9X7XVYqGC8CbCtCISDPzEmH+AcCy8rPBNb3i9S7SNDiaVOAo
> vc7kO3EajD6QYFp6aH2K
> =o+vQ
> -----END PGP SIGNATURE-----
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>


Thank you,
Alexandra.

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Rick Zero_Chaos Farina]

[-- Attachment #1: Type: text/plain, Size: 3417 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/16/2014 03:54 PM, Sergey Senozhatsky wrote:
> On (04/16/14 12:41), Kok, Auke-jan H wrote:
>> ncurses by itself does not provide a pkgconfig check, it is however
>> manually added by various distributions, but not all of them.
>>
>> So, the patch below breaks building powertop for those distributions.
>>
> 
> yes. good point. apparently ncurses provides pkg-config files these days.
> but there still may be distributions that use older ncurses versions.


pkgconfig support was added on 20090103 according to the changelog here:
http://invisible-island.net/ncurses/NEWS.html.

Is is really a major concern to to require a version of ncurses released
within the last 5 years?

- -Zero
> 
> 	-ss
> 
>> I suggest that if you really want to make it use pkg-config, you write
>> it in such a way that if pkg-config checking fails, it will still
>> attempt to search for the appropriate libs instead.
>>
>> Auke
>>
>>
>>
>> On Wed, Apr 16, 2014 at 8:20 AM, Rick "Zero_Chaos" Farina
>> <zerochaos(a)gentoo.org> wrote:
> Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124
> 
> Depending on how ncurses is built, it may require different information
> passed to the linker.  Use pkg-config to detect the correct information:
> 
> --- a/configure.ac
> +++ b/configure.ac
> @@ -46,7 +46,7 @@
>  AC_FUNC_STRTOD
>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir
> munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
> strchr strdup strerror strncasecmp strstr strtoul strtoull])
> 
> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses
> is required but was not found]), [])
> +PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
> AC_MSG_ERROR([ncurses is required but was not found]))
> 
>  has_libpci=0
>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
> 
> 
> Original patch:
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup
> 
> Please include this fix.
> 
> thanks,
> Zero
>>> _______________________________________________
>>> PowerTop mailing list
>>> PowerTop(a)lists.01.org
>>> https://lists.01.org/mailman/listinfo/powertop
>> _______________________________________________
>> PowerTop mailing list
>> PowerTop(a)lists.01.org
>> https://lists.01.org/mailman/listinfo/powertop
>>
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTTvA1AAoJEKXdFCfdEflK/VYP/2D9II4S6BMw/1flPtHfj5Yn
2L+iy9KpIbRAaV0n6XI4/0ppGM+21xXbw372z56ne/MBKqJD0TCOF2AyHhD/178U
oNkTjAt0aJuToO/IDZAR5Q4oD8KXQAO67lsH+VHkuV3R93hpxQ49COaGnPW62TvR
I3nBRJMiqN6sixQa5M5wT2OlQz9mzs7GxEt2VeRXNHtoLAvPScJYM6p1v1An/Vcz
a6YvLmKB0S5t5m3a8Nc7EAvcqJNgnKKtMBgfv8d6zi5ueFtdn4TxAKxqXZeNpgiV
uY/lKa1Ycz924ftd+iLTAf6q3H6PVY7GJnYbRXZ7niz0PqXtExgOmZ6JonZIhdBC
+TX161fjRQYjTf6JjwMYzKTc4Vx9lUjX4f/0jsPDmC/Wu0NcDL8GbBqP45AYIktX
I1uo6vDqglxg6vQDL3OrL+6oolDITfJaSTFFZ7QezdyA9uflCR9uQaCbnJ7zKCF/
acD1Vh9gabRQw2Mq1n9ATB9mpuFUESclVz6Xs/PCiWCTLM5XyIhfUU/RCeOEjG2j
ooEx999sAlrdjK5WH+chL1A/yQyamcfuH8cQmOO2p7o70Z6++/u18OdwbCRkgioe
87LaoT2VRwNAcQhR9X7XVYqGC8CbCtCISDPzEmH+AcCy8rPBNb3i9S7SNDiaVOAo
vc7kO3EajD6QYFp6aH2K
=o+vQ
-----END PGP SIGNATURE-----

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 3230 bytes --]

On (04/16/14 12:41), Kok, Auke-jan H wrote:
> ncurses by itself does not provide a pkgconfig check, it is however
> manually added by various distributions, but not all of them.
> 
> So, the patch below breaks building powertop for those distributions.
> 

yes. good point. apparently ncurses provides pkg-config files these days.
but there still may be distributions that use older ncurses versions.

	-ss

> I suggest that if you really want to make it use pkg-config, you write
> it in such a way that if pkg-config checking fails, it will still
> attempt to search for the appropriate libs instead.
> 
> Auke
> 
> 
> 
> On Wed, Apr 16, 2014 at 8:20 AM, Rick "Zero_Chaos" Farina
> <zerochaos(a)gentoo.org> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124
> >
> > Depending on how ncurses is built, it may require different information
> > passed to the linker.  Use pkg-config to detect the correct information:
> >
> > - --- a/configure.ac
> > +++ b/configure.ac
> > @@ -46,7 +46,7 @@
> >  AC_FUNC_STRTOD
> >  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir
> > munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
> > strchr strdup strerror strncasecmp strstr strtoul strtoull])
> >
> > - -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses
> > is required but was not found]), [])
> > +PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
> > AC_MSG_ERROR([ncurses is required but was not found]))
> >
> >  has_libpci=0
> >  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
> >
> >
> > Original patch:
> > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup
> >
> > Please include this fix.
> >
> > thanks,
> > Zero
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2.0.22 (GNU/Linux)
> > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
> >
> > iQIcBAEBAgAGBQJTTp+2AAoJEKXdFCfdEflKJVkP/19iu4BWlFZ5TV0XVKvi0lm9
> > DsIK9gkN+Kpa5F3QjTgDOCA7K72VdTGCv8os3A0KHPocrQ55tNb0lyILJYs6/rdL
> > YSCMrd1TjacVhZujwTjia99BA/EwkPGpeogKdKuzHfRI6EYk6QFDaeljG11Jjds+
> > VQ/sW3Fbe63/Sw6jvvHYTi0wE2hu30ot9Y+GQXkaNfJMpvk16S2GevKr+PG6wAqF
> > gL1hLG7b5NNTgZxNLZJMDMIFZcUA/VMBUPZta5KyGpzjrMcVcZkNZ3YegwkwIJQ/
> > Dq0xA/HhXUSgCIcp2cTuBF2YZrKE/linFmFHyKJ0NEvbaEpAsPLkhzpz3E8d+b++
> > t8ceoTAYYRGpJU9fGNLcHCaHmREtzQMJn7hTT85Rbz0+duohaj6xqkKTemlPykTu
> > ZDM+48oUXEe+iwcfp4ctbJILwZaw+IIzA2GhtR3QATjfQZe4lXczHHt2VW50toIb
> > hFaKrg/uYqHe7KpHq/+rdtjNhOsP7Ckaq+USTQ7/AmoFLB6Bt+3NM9sIHdyeWUfG
> > XXnOKPPpPSOZXFE/mKodqI0tOP0cngbMuLr60axELZi0gxiUiDVxKuRAOlukVRSY
> > RQFKRIucrEeR/uwDH/sbq1xQ0dnE0JdJs4VO8K40KkSskE7eHOoBIJ8c3kL02Sfm
> > c6KasduRgzZfWUo4plC1
> > =yt9+
> > -----END PGP SIGNATURE-----
> > _______________________________________________
> > PowerTop mailing list
> > PowerTop(a)lists.01.org
> > https://lists.01.org/mailman/listinfo/powertop
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

Re: [Powertop] [PATCH] use pkg-config to find ncurses

[Kok, Auke-jan H]

[-- Attachment #1: Type: text/plain, Size: 2732 bytes --]

ncurses by itself does not provide a pkgconfig check, it is however
manually added by various distributions, but not all of them.

So, the patch below breaks building powertop for those distributions.

I suggest that if you really want to make it use pkg-config, you write
it in such a way that if pkg-config checking fails, it will still
attempt to search for the appropriate libs instead.

Auke



On Wed, Apr 16, 2014 at 8:20 AM, Rick "Zero_Chaos" Farina
<zerochaos(a)gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124
>
> Depending on how ncurses is built, it may require different information
> passed to the linker.  Use pkg-config to detect the correct information:
>
> - --- a/configure.ac
> +++ b/configure.ac
> @@ -46,7 +46,7 @@
>  AC_FUNC_STRTOD
>  AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir
> munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
> strchr strdup strerror strncasecmp strstr strtoul strtoull])
>
> - -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses
> is required but was not found]), [])
> +PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
> AC_MSG_ERROR([ncurses is required but was not found]))
>
>  has_libpci=0
>  PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[
>
>
> Original patch:
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup
>
> Please include this fix.
>
> thanks,
> Zero
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJTTp+2AAoJEKXdFCfdEflKJVkP/19iu4BWlFZ5TV0XVKvi0lm9
> DsIK9gkN+Kpa5F3QjTgDOCA7K72VdTGCv8os3A0KHPocrQ55tNb0lyILJYs6/rdL
> YSCMrd1TjacVhZujwTjia99BA/EwkPGpeogKdKuzHfRI6EYk6QFDaeljG11Jjds+
> VQ/sW3Fbe63/Sw6jvvHYTi0wE2hu30ot9Y+GQXkaNfJMpvk16S2GevKr+PG6wAqF
> gL1hLG7b5NNTgZxNLZJMDMIFZcUA/VMBUPZta5KyGpzjrMcVcZkNZ3YegwkwIJQ/
> Dq0xA/HhXUSgCIcp2cTuBF2YZrKE/linFmFHyKJ0NEvbaEpAsPLkhzpz3E8d+b++
> t8ceoTAYYRGpJU9fGNLcHCaHmREtzQMJn7hTT85Rbz0+duohaj6xqkKTemlPykTu
> ZDM+48oUXEe+iwcfp4ctbJILwZaw+IIzA2GhtR3QATjfQZe4lXczHHt2VW50toIb
> hFaKrg/uYqHe7KpHq/+rdtjNhOsP7Ckaq+USTQ7/AmoFLB6Bt+3NM9sIHdyeWUfG
> XXnOKPPpPSOZXFE/mKodqI0tOP0cngbMuLr60axELZi0gxiUiDVxKuRAOlukVRSY
> RQFKRIucrEeR/uwDH/sbq1xQ0dnE0JdJs4VO8K40KkSskE7eHOoBIJ8c3kL02Sfm
> c6KasduRgzZfWUo4plC1
> =yt9+
> -----END PGP SIGNATURE-----
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop

[Powertop] [PATCH] use pkg-config to find ncurses

[Rick Zero_Chaos Farina]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Original bug report: https://bugs.gentoo.org/show_bug.cgi?id=486124

Depending on how ncurses is built, it may require different information
passed to the linker.  Use pkg-config to detect the correct information:

- --- a/configure.ac
+++ b/configure.ac
@@ -46,7 +46,7 @@
 AC_FUNC_STRTOD
 AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir
munmap pow realpath regcomp select setlocale socket sqrt strcasecmp
strchr strdup strerror strncasecmp strstr strtoul strtoull])

- -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses
is required but was not found]), [])
+PKG_CHECK_MODULES(ncurses, ncurses, [LIBS="$LIBS $ncurses_LIBS"],
AC_MSG_ERROR([ncurses is required but was not found]))

 has_libpci=0
 PKG_CHECK_MODULES([PCIUTILS], [libpci],[has_libpci=1],[


Original patch:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-power/powertop/files/powertop-2.4-tinfo.patch?revision=1.1&view=markup

Please include this fix.

thanks,
Zero
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTTp+2AAoJEKXdFCfdEflKJVkP/19iu4BWlFZ5TV0XVKvi0lm9
DsIK9gkN+Kpa5F3QjTgDOCA7K72VdTGCv8os3A0KHPocrQ55tNb0lyILJYs6/rdL
YSCMrd1TjacVhZujwTjia99BA/EwkPGpeogKdKuzHfRI6EYk6QFDaeljG11Jjds+
VQ/sW3Fbe63/Sw6jvvHYTi0wE2hu30ot9Y+GQXkaNfJMpvk16S2GevKr+PG6wAqF
gL1hLG7b5NNTgZxNLZJMDMIFZcUA/VMBUPZta5KyGpzjrMcVcZkNZ3YegwkwIJQ/
Dq0xA/HhXUSgCIcp2cTuBF2YZrKE/linFmFHyKJ0NEvbaEpAsPLkhzpz3E8d+b++
t8ceoTAYYRGpJU9fGNLcHCaHmREtzQMJn7hTT85Rbz0+duohaj6xqkKTemlPykTu
ZDM+48oUXEe+iwcfp4ctbJILwZaw+IIzA2GhtR3QATjfQZe4lXczHHt2VW50toIb
hFaKrg/uYqHe7KpHq/+rdtjNhOsP7Ckaq+USTQ7/AmoFLB6Bt+3NM9sIHdyeWUfG
XXnOKPPpPSOZXFE/mKodqI0tOP0cngbMuLr60axELZi0gxiUiDVxKuRAOlukVRSY
RQFKRIucrEeR/uwDH/sbq1xQ0dnE0JdJs4VO8K40KkSskE7eHOoBIJ8c3kL02Sfm
c6KasduRgzZfWUo4plC1
=yt9+
-----END PGP SIGNATURE-----