All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Kiernan <alex.kiernan@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] tools: fit_image: Add the loadable property to configs
Date: Fri, 12 Apr 2019 14:03:59 +0100	[thread overview]
Message-ID: <CAO5Uq5ROYrfFJq_5cSJqTCnzVVGpF24hjn7-R_AS0e-u1L7i6w@mail.gmail.com> (raw)
In-Reply-To: <1552379663-13984-2-git-send-email-abel.vesa@nxp.com>

On Tue, Mar 12, 2019 at 8:34 AM Abel Vesa <abel.vesa@nxp.com> wrote:
>
> When running mkimage with "-f auto", the loadable property
> needs to be set in order to allow SPL FIT support to boot.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

I've just bisected out to this commit breaking Y-Modem booting of FIT
U-Boot on am335x. Right now I'm at a bit of a loss as to why, as I
can't find a code path where FIT_LOADABLE_PROP would be treated
differently between UART and MMC booting (which still works).

That said the loadables stuff with this patch doesn't seem to match up
with what doc/uImage.FIT/howto.txt has to say about loadables:

/ {
    timestamp = <0x5cb08987>;
    description = "Firmware image with one or more FDT blobs";
    creator = "U-Boot mkimage 2019.04-00217-g38927694f48a-dirty";
    #address-cells = <0x00000001>;
    images {
        firmware-1 {
            data-size = <0x0005e204>;
            data-offset = <0x00000000>;
            description = "U-Boot 2019.04-00217-g38927694f48a-dirty
for A335XHUB board";
            type = "firmware";
            arch = "arm";
            os = "u-boot";
            compression = "none";
            load = <0x80800000>;
            entry = <0x00000000>;
        };
        fdt-1 {
            data-size = <0x000080c4>;
            data-offset = <0x0005e204>;
            description = "A335XHUB-0001";
            type = "firmware";
            arch = "arm";
            compression = "none";
        };
        fdt-2 {
            data-size = <0x000088f4>;
            data-offset = <0x000662c8>;
            description = "A335XHUB-0003";
            type = "firmware";
            arch = "arm";
            compression = "none";
        };
    };
    configurations {
        default = "conf-1";
        conf-1 {
            description = "A335XHUB-0001";
            firmware = "firmware-1";
            loadables = "firmware-1";
            fdt = "fdt-1";
        };
        conf-2 {
            description = "A335XHUB-0003";
            firmware = "firmware-1";
            loadables = "firmware-1";
            fdt = "fdt-2";
        };
    };
};

Still digging...

-- 
Alex Kiernan

  parent reply	other threads:[~2019-04-12 13:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12  8:34 [U-Boot] [PATCH v2 1/2] common: spl_fit: Default to IH_OS_U_BOOT if FIT_IMAGE_TINY enabled Abel Vesa
2019-03-12  8:34 ` [U-Boot] [PATCH v2 2/2] tools: fit_image: Add the loadable property to configs Abel Vesa
2019-03-20 13:16   ` Fabio Estevam
2019-03-20 13:38     ` Stefano Babic
2019-03-22 23:17   ` [U-Boot] [U-Boot, v2, " Tom Rini
2019-04-12 13:03   ` Alex Kiernan [this message]
2019-03-20 13:14 ` [U-Boot] [PATCH v2 1/2] common: spl_fit: Default to IH_OS_U_BOOT if FIT_IMAGE_TINY enabled Fabio Estevam
2019-03-22 23:17 ` [U-Boot] [U-Boot, v2, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO5Uq5ROYrfFJq_5cSJqTCnzVVGpF24hjn7-R_AS0e-u1L7i6w@mail.gmail.com \
    --to=alex.kiernan@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.