* phosphor-host-ipmid sensor SDRs on dbus
@ 2019-07-23 20:40 Patrick Venture
2019-07-23 21:48 ` James Feist
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Venture @ 2019-07-23 20:40 UTC (permalink / raw)
To: OpenBMC Maillist, tomjoseph, Vernon Mauery, Emily Shaffer,
James Feist, Tanous, Ed, Ofer Yehielli, Kun Yi
I sent out an email indicating that we need to make sensors somewhat
dynamic in phosphor-host-ipmid, and either using json or dbus was a
reasonable approach. I think json would be easier, but, for those
using entity-manager, perhaps having the SDR information supported in
some way associated with the dbus output might be useful.
Idea: Given a sensor, read the SDR from dbus.
Problem: association of a sensor id with a sensor on dbus -- maybe
some search step is run once that caches everything and listens for
change (similar to what James did with phosphor-pid-control)...
I'm just throwing out ideas without full design changes because I want
to get a sense of where the preferences lie before really digging into
what changes are required.
It would support both types (like dbus configuration in phosphor-pid-control).
Patrick
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: phosphor-host-ipmid sensor SDRs on dbus
2019-07-23 20:40 phosphor-host-ipmid sensor SDRs on dbus Patrick Venture
@ 2019-07-23 21:48 ` James Feist
0 siblings, 0 replies; 2+ messages in thread
From: James Feist @ 2019-07-23 21:48 UTC (permalink / raw)
To: Patrick Venture, OpenBMC Maillist, tomjoseph, Vernon Mauery,
Emily Shaffer, Tanous, Ed, Ofer Yehielli, Kun Yi
On 7/23/2019 1:40 PM, Patrick Venture wrote:
> I sent out an email indicating that we need to make sensors somewhat
> dynamic in phosphor-host-ipmid, and either using json or dbus was a
> reasonable approach. I think json would be easier, but, for those
> using entity-manager, perhaps having the SDR information supported in
> some way associated with the dbus output might be useful.
In intel-ipmi-oem we were able to use the max / min values to generate
an SDR. The only real hold ups for global adoption I believe were:
1. static sensor numbers were needed.
2. it was implemented using doubles for sensor numbers
If you had some configuration so that you could make these things
non-generated if you wished, this might be useful to you.
https://github.com/openbmc/intel-ipmi-oem/blob/edf25e614919d0b379b885384bcdac987580b844/src/sensorcommands.cpp#L1259
-James
>
> Idea: Given a sensor, read the SDR from dbus.
> Problem: association of a sensor id with a sensor on dbus -- maybe
> some search step is run once that caches everything and listens for
> change (similar to what James did with phosphor-pid-control)...
>
> I'm just throwing out ideas without full design changes because I want
> to get a sense of where the preferences lie before really digging into
> what changes are required.
>
> It would support both types (like dbus configuration in phosphor-pid-control).
>
> Patrick
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-23 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 20:40 phosphor-host-ipmid sensor SDRs on dbus Patrick Venture
2019-07-23 21:48 ` James Feist
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.