ssl fips self check fails with 7.2.0 on x86 TCG

ssl fips self check fails with 7.2.0 on x86 TCG

[Patrick Venture]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hi,

I just finished rebasing my team onto 7.2.0 and now I'm seeing
https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/self_check/self_check.c#361
fail.

I applied
https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00260.html and
it's still failing.

Is anyone else seeing this issue or have suggestions on how to debug it?

I haven't yet tried with 8.0.0 but that's my next step, although it also
needs the float32_exp3 patch.

Patrick

[-- Attachment #2: Type: text/html, Size: 820 bytes --]

Re: ssl fips self check fails with 7.2.0 on x86 TCG

[Patrick Venture]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Verified it was https://gitlab.com/qemu-project/qemu/-/issues/1471

On Thu, May 4, 2023 at 12:03 PM Patrick Venture <venture@google.com> wrote:

> Hi,
>
> I just finished rebasing my team onto 7.2.0 and now I'm seeing
> https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/self_check/self_check.c#361
> fail.
>
> I applied
> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00260.html and
> it's still failing.
>
> Is anyone else seeing this issue or have suggestions on how to debug it?
>
> I haven't yet tried with 8.0.0 but that's my next step, although it also
> needs the float32_exp3 patch.
>
> Patrick
>

[-- Attachment #2: Type: text/html, Size: 1343 bytes --]

Re: ssl fips self check fails with 7.2.0 on x86 TCG

[Philippe Mathieu-Daudé]

Hi,

On 9/5/23 04:08, Patrick Venture wrote:
> Verified it was https://gitlab.com/qemu-project/qemu/-/issues/1471 
> <https://gitlab.com/qemu-project/qemu/-/issues/1471>
> 
> On Thu, May 4, 2023 at 12:03 PM Patrick Venture <venture@google.com 
> <mailto:venture@google.com>> wrote:
> 
>     Hi,
> 
>     I just finished rebasing my team onto 7.2.0 and now I'm seeing
>     https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/self_check/self_check.c#361 <https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/self_check/self_check.c#361> fail.

Should be fixed in v7.2-stable:

$ git log --oneline --grep=1d0b9261 v7.2.2
c45d10f655 target/i386: fix ADOX followed by ADCX
6809dbc5c5 target/i386: Fix C flag for BLSI, BLSMSK, BLSR
8d3c9fc439 target/i386: Fix BEXTR instruction

> 
>     I applied
>     https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00260.html
>     <https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00260.html> and it's still failing.
> 
>     Is anyone else seeing this issue or have suggestions on how to debug it?
> 
>     I haven't yet tried with 8.0.0 but that's my next step, although it

Should be fixed in 8.0.0:

$ git log --oneline --grep=1d0b9261 v8.0.0
60c7dd22e1 target/i386: fix ADOX followed by ADCX
99282098dc target/i386: Fix C flag for BLSI, BLSMSK, BLSR
b14c009897 target/i386: Fix BEXTR instruction

Re: ssl fips self check fails with 7.2.0 on x86 TCG

[Michael Tokarev]

09.05.2023 17:39, Philippe Mathieu-Daudé пишет:
..> Should be fixed in v7.2-stable:
> 
> $ git log --oneline --grep=1d0b9261 v7.2.2
> c45d10f655 target/i386: fix ADOX followed by ADCX
> 6809dbc5c5 target/i386: Fix C flag for BLSI, BLSMSK, BLSR
> 8d3c9fc439 target/i386: Fix BEXTR instruction

Unfortunately it is still not released, -
I haven't heard anything from Michael Roth since Apr-22 (when 7.2.2 planned).

/mjt

Re: ssl fips self check fails with 7.2.0 on x86 TCG

[Patrick Venture]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On Tue, May 9, 2023 at 9:51 AM Michael Tokarev <mjt@tls.msk.ru> wrote:

> 09.05.2023 17:39, Philippe Mathieu-Daudé пишет:
> ..> Should be fixed in v7.2-stable:
> >
> > $ git log --oneline --grep=1d0b9261 v7.2.2
> > c45d10f655 target/i386: fix ADOX followed by ADCX
> > 6809dbc5c5 target/i386: Fix C flag for BLSI, BLSMSK, BLSR
> > 8d3c9fc439 target/i386: Fix BEXTR instruction
>
> Unfortunately it is still not released, -
> I haven't heard anything from Michael Roth since Apr-22 (when 7.2.2
> planned).
>

Thanks, I have it cherry-picked into our repo. :)


>
> /mjt
>

[-- Attachment #2: Type: text/html, Size: 1104 bytes --]