All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julius Werner <jwerner@chromium.org>
To: Xingyu Chen <xingyu.chen@amlogic.com>
Cc: Julius Werner <jwerner@chromium.org>,
	Evan Benn <evanbenn@chromium.org>,
	Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-watchdog@vger.kernel.org,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Yonghui Yu <yonghui.yu@amlogic.com>
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible
Date: Mon, 24 Feb 2020 17:23:46 -0800	[thread overview]
Message-ID: <CAODwPW8WwntWb_=dg2J3AMy-gHw2QvNj_g98SufN13+AuGnUSg@mail.gmail.com> (raw)
In-Reply-To: <1326f594-3cfd-c03d-4f2c-50eeb75724b2@amlogic.com>

> The SMC function ID may be solved by the DTS, but the wdt indexs(Eg:
> SMCWD_INFO) are also different
> for each vendor. The imx_sc_wdt.c is also use the SMC to operate the
> WDT, but the wdt indexs(Eg: IMX_SIP_TIMER_START_WDOG)
> are different from ours. IMO, If the ATF can implement a common hal
> interface and index for watchdog, then writing a
> common smc wdt driver will be easier to compatible with all vendors.

The MediaTek driver is still in flux (e.g. still being reviewed in
Trusted Firmware here:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405),
we can still change it. So if we can now decide on making this a
"standard" driver, we can change the MediaTek interface to match IMX
and standardize on that. (There are existing Chromebooks shipped with
a different interface, but we could handle those separately with
downstream patches. I think having a unified interface that will
prevent this problem in the future would be worth some extra
complication right now.)

  parent reply	other threads:[~2020-02-25  1:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  6:26 [PATCH 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-02-14  6:26 ` Evan Benn
2020-02-14  6:26 ` [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Evan Benn
2020-02-19 22:30   ` Rob Herring
2020-02-19 23:04     ` Julius Werner
2020-02-19 23:20       ` Guenter Roeck
2020-02-20  6:41         ` Evan Benn
2020-02-20 15:43           ` Guenter Roeck
2020-02-21 15:36           ` Xingyu Chen
2020-02-21 19:41             ` Julius Werner
2020-02-21 20:46               ` Guenter Roeck
2020-02-22  4:01               ` Xingyu Chen
2020-02-24  1:10                 ` Evan Benn
2020-02-25  1:23                 ` Julius Werner [this message]
2020-02-25  7:44                   ` Xingyu Chen
2020-02-25  7:44                     ` Xingyu Chen
2020-03-10  1:00                     ` Evan Benn
2020-03-10  1:00                       ` Evan Benn
     [not found]                       ` <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com>
2020-03-11 19:24                         ` Julius Werner
2020-03-11 19:24                           ` Julius Werner
2020-03-13 16:13                           ` Xingyu Chen
2020-03-13 16:13                             ` Xingyu Chen
2020-02-14  6:26 ` [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn
2020-02-14  6:26   ` Evan Benn
2020-02-14  9:35   ` Enric Balletbo Serra
2020-02-14  9:35     ` Enric Balletbo Serra
2020-02-14 14:10   ` Guenter Roeck
2020-02-14 14:10     ` Guenter Roeck
2020-02-14 21:32     ` Julius Werner
2020-02-14 21:32       ` Julius Werner
2020-02-15  1:39       ` Evan Benn
2020-02-15  1:39         ` Evan Benn
2020-02-20  6:50     ` Evan Benn
2020-02-20  6:50       ` Evan Benn
2020-02-20 15:52       ` Guenter Roeck
2020-02-20 15:52         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAODwPW8WwntWb_=dg2J3AMy-gHw2QvNj_g98SufN13+AuGnUSg@mail.gmail.com' \
    --to=jwerner@chromium.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=evanbenn@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jianxin.pan@amlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=xingyu.chen@amlogic.com \
    --cc=yonghui.yu@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.