From: Julius Werner <jwerner@chromium.org> To: Xingyu Chen <xingyu.chen@amlogic.com> Cc: Evan Benn <evanbenn@chromium.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>, Jianxin Pan <jianxin.pan@amlogic.com>, Rob Herring <robh@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, LKML <linux-kernel@vger.kernel.org>, Yonghui Yu <yonghui.yu@amlogic.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Julius Werner <jwerner@chromium.org>, "open list:ARM/Amlogic Meson..." <linux-amlogic@lists.infradead.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, "David S. Miller" <davem@davemloft.net>, Guenter Roeck <linux@roeck-us.net> Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Date: Wed, 11 Mar 2020 12:24:01 -0700 [thread overview] Message-ID: <CAODwPW9oxx33hkO3kv2_G8YyLWvigVHkfJU7xUHLVgB7QU2i3Q@mail.gmail.com> (raw) In-Reply-To: <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com> > - *_INIT and *GETTIMEOUT. Although your driver does not need them, could you take them as options in your driver ? The driver already has SMCWD_INFO which is used during probe to retrieve the minimum and maximum timeout values supported by the hardware at probe time. Maybe it would make sense to rename that to INIT (which would still return those values, but can also do whatever initialization needs to be done in TF)? GETTIMELEFT I agree we can implement optionally, and other platforms would just return a PSCI_RET_NOT_SUPPORTED for that. > - *_RESETNOW. It is used to reset the system right now, similar to your SOFT RESET. could you reserve an operation index in ATF ? Just curious, why do you need this? Shouldn't you use the PSCI standard SYSTEM_RESET SMC for that? (If you want to control exactly how the platform is reset, you could also use SYSTEM_RESET2 with a vendor-defined reset_type.)
WARNING: multiple messages have this Message-ID (diff)
From: Julius Werner <jwerner@chromium.org> To: Xingyu Chen <xingyu.chen@amlogic.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>, Jianxin Pan <jianxin.pan@amlogic.com>, Rob Herring <robh@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, LKML <linux-kernel@vger.kernel.org>, Mauro Carvalho Chehab <mchehab+samsung@kernel.org>, Evan Benn <evanbenn@chromium.org>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Yonghui Yu <yonghui.yu@amlogic.com>, Julius Werner <jwerner@chromium.org>, "open list:ARM/Amlogic Meson..." <linux-amlogic@lists.infradead.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, "David S. Miller" <davem@davemloft.net>, Guenter Roeck <linux@roeck-us.net> Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Date: Wed, 11 Mar 2020 12:24:01 -0700 [thread overview] Message-ID: <CAODwPW9oxx33hkO3kv2_G8YyLWvigVHkfJU7xUHLVgB7QU2i3Q@mail.gmail.com> (raw) In-Reply-To: <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com> > - *_INIT and *GETTIMEOUT. Although your driver does not need them, could you take them as options in your driver ? The driver already has SMCWD_INFO which is used during probe to retrieve the minimum and maximum timeout values supported by the hardware at probe time. Maybe it would make sense to rename that to INIT (which would still return those values, but can also do whatever initialization needs to be done in TF)? GETTIMELEFT I agree we can implement optionally, and other platforms would just return a PSCI_RET_NOT_SUPPORTED for that. > - *_RESETNOW. It is used to reset the system right now, similar to your SOFT RESET. could you reserve an operation index in ATF ? Just curious, why do you need this? Shouldn't you use the PSCI standard SYSTEM_RESET SMC for that? (If you want to control exactly how the platform is reset, you could also use SYSTEM_RESET2 with a vendor-defined reset_type.) _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-03-11 19:24 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-14 6:26 [PATCH 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn 2020-02-14 6:26 ` Evan Benn 2020-02-14 6:26 ` [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Evan Benn 2020-02-19 22:30 ` Rob Herring 2020-02-19 23:04 ` Julius Werner 2020-02-19 23:20 ` Guenter Roeck 2020-02-20 6:41 ` Evan Benn 2020-02-20 15:43 ` Guenter Roeck 2020-02-21 15:36 ` Xingyu Chen 2020-02-21 19:41 ` Julius Werner 2020-02-21 20:46 ` Guenter Roeck 2020-02-22 4:01 ` Xingyu Chen 2020-02-24 1:10 ` Evan Benn 2020-02-25 1:23 ` Julius Werner 2020-02-25 7:44 ` Xingyu Chen 2020-02-25 7:44 ` Xingyu Chen 2020-03-10 1:00 ` Evan Benn 2020-03-10 1:00 ` Evan Benn [not found] ` <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com> 2020-03-11 19:24 ` Julius Werner [this message] 2020-03-11 19:24 ` Julius Werner 2020-03-13 16:13 ` Xingyu Chen 2020-03-13 16:13 ` Xingyu Chen 2020-02-14 6:26 ` [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn 2020-02-14 6:26 ` Evan Benn 2020-02-14 9:35 ` Enric Balletbo Serra 2020-02-14 9:35 ` Enric Balletbo Serra 2020-02-14 14:10 ` Guenter Roeck 2020-02-14 14:10 ` Guenter Roeck 2020-02-14 21:32 ` Julius Werner 2020-02-14 21:32 ` Julius Werner 2020-02-15 1:39 ` Evan Benn 2020-02-15 1:39 ` Evan Benn 2020-02-20 6:50 ` Evan Benn 2020-02-20 6:50 ` Evan Benn 2020-02-20 15:52 ` Guenter Roeck 2020-02-20 15:52 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAODwPW9oxx33hkO3kv2_G8YyLWvigVHkfJU7xUHLVgB7QU2i3Q@mail.gmail.com \ --to=jwerner@chromium.org \ --cc=Jonathan.Cameron@huawei.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=evanbenn@chromium.org \ --cc=gregkh@linuxfoundation.org \ --cc=jianxin.pan@amlogic.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mark.rutland@arm.com \ --cc=mchehab+samsung@kernel.org \ --cc=robh@kernel.org \ --cc=wim@linux-watchdog.org \ --cc=xingyu.chen@amlogic.com \ --cc=yonghui.yu@amlogic.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.