From: Roman Stratiienko <roman.stratiienko@globallogic.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Jernej Škrabec" <jernej.skrabec@siol.net>
Subject: Re: [PATCH v3 2/2] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame.
Date: Thu, 2 Jan 2020 18:32:07 +0200 [thread overview]
Message-ID: <CAODwZ7uqf4v8XjOLCn=SoUQchst_b96VCNdaunzn9Q21zPcQ7w@mail.gmail.com> (raw)
In-Reply-To: <20200102100832.c5fc4imjdmr7otam@gilmour.lan>
чт, 2 янв. 2020 г., 12:08 Maxime Ripard <mripard@kernel.org>:
>
> Hi,
>
> On Wed, Jan 01, 2020 at 10:47:50PM +0200, roman.stratiienko@globallogic.com wrote:
> > From: Roman Stratiienko <roman.stratiienko@globallogic.com>
> >
> > According to DRM documentation the only difference between PRIMARY
> > and OVERLAY plane is that each CRTC must have PRIMARY plane and
> > OVERLAY are optional.
> >
> > Allow PRIMARY plane to have dimension different from full-screen.
> >
> > Fixes: 5bb5f5dafa1a ("drm/sun4i: Reorganize UI layer code in DE2")
> > Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> So it applies to all the 4 patches you've sent, but this lacks some
> context.
>
> There's a few questions that should be answered here:
> - Which situation is it fixing?
Setting primary plane size less than crtc breaks composition. Also
shifting top left corner also breaks it.
> - What tool / userspace stack is it fixing?
I am using Android userspace and drm_hwcomposer HAL.
@Jernej, you've said that you observed similar issue. Could you share
what userspace have you used?
> - What happens with your fix? Do you set the plane at coordinates
> 0,0 (meaning you'll crop the top-lef corner), do you center it? If
> the plane is smaller than the CTRC size, what is set on the edges?
You can put primary plane to any part of the screen and make it as
small as 8x8 (according to the datasheet) . Background would be filled
with black color, that is default, but it also could be overridden by
setting corresponding registers.
>
>
> Thanks!
> Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: "Jernej Škrabec" <jernej.skrabec@siol.net>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame.
Date: Thu, 2 Jan 2020 18:32:07 +0200 [thread overview]
Message-ID: <CAODwZ7uqf4v8XjOLCn=SoUQchst_b96VCNdaunzn9Q21zPcQ7w@mail.gmail.com> (raw)
In-Reply-To: <20200102100832.c5fc4imjdmr7otam@gilmour.lan>
чт, 2 янв. 2020 г., 12:08 Maxime Ripard <mripard@kernel.org>:
>
> Hi,
>
> On Wed, Jan 01, 2020 at 10:47:50PM +0200, roman.stratiienko@globallogic.com wrote:
> > From: Roman Stratiienko <roman.stratiienko@globallogic.com>
> >
> > According to DRM documentation the only difference between PRIMARY
> > and OVERLAY plane is that each CRTC must have PRIMARY plane and
> > OVERLAY are optional.
> >
> > Allow PRIMARY plane to have dimension different from full-screen.
> >
> > Fixes: 5bb5f5dafa1a ("drm/sun4i: Reorganize UI layer code in DE2")
> > Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> So it applies to all the 4 patches you've sent, but this lacks some
> context.
>
> There's a few questions that should be answered here:
> - Which situation is it fixing?
Setting primary plane size less than crtc breaks composition. Also
shifting top left corner also breaks it.
> - What tool / userspace stack is it fixing?
I am using Android userspace and drm_hwcomposer HAL.
@Jernej, you've said that you observed similar issue. Could you share
what userspace have you used?
> - What happens with your fix? Do you set the plane at coordinates
> 0,0 (meaning you'll crop the top-lef corner), do you center it? If
> the plane is smaller than the CTRC size, what is set on the edges?
You can put primary plane to any part of the screen and make it as
small as 8x8 (according to the datasheet) . Background would be filled
with black color, that is default, but it also could be overridden by
setting corresponding registers.
>
>
> Thanks!
> Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: "Jernej Škrabec" <jernej.skrabec@siol.net>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame.
Date: Thu, 2 Jan 2020 18:32:07 +0200 [thread overview]
Message-ID: <CAODwZ7uqf4v8XjOLCn=SoUQchst_b96VCNdaunzn9Q21zPcQ7w@mail.gmail.com> (raw)
In-Reply-To: <20200102100832.c5fc4imjdmr7otam@gilmour.lan>
чт, 2 янв. 2020 г., 12:08 Maxime Ripard <mripard@kernel.org>:
>
> Hi,
>
> On Wed, Jan 01, 2020 at 10:47:50PM +0200, roman.stratiienko@globallogic.com wrote:
> > From: Roman Stratiienko <roman.stratiienko@globallogic.com>
> >
> > According to DRM documentation the only difference between PRIMARY
> > and OVERLAY plane is that each CRTC must have PRIMARY plane and
> > OVERLAY are optional.
> >
> > Allow PRIMARY plane to have dimension different from full-screen.
> >
> > Fixes: 5bb5f5dafa1a ("drm/sun4i: Reorganize UI layer code in DE2")
> > Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> So it applies to all the 4 patches you've sent, but this lacks some
> context.
>
> There's a few questions that should be answered here:
> - Which situation is it fixing?
Setting primary plane size less than crtc breaks composition. Also
shifting top left corner also breaks it.
> - What tool / userspace stack is it fixing?
I am using Android userspace and drm_hwcomposer HAL.
@Jernej, you've said that you observed similar issue. Could you share
what userspace have you used?
> - What happens with your fix? Do you set the plane at coordinates
> 0,0 (meaning you'll crop the top-lef corner), do you center it? If
> the plane is smaller than the CTRC size, what is set on the edges?
You can put primary plane to any part of the screen and make it as
small as 8x8 (according to the datasheet) . Background would be filled
with black color, that is default, but it also could be overridden by
setting corresponding registers.
>
>
> Thanks!
> Maxime
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-02 16:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 20:47 [PATCH v3 1/2] drm/sun4i: Add mode_set callback to the engine roman.stratiienko
2020-01-01 20:47 ` roman.stratiienko
2020-01-01 20:47 ` roman.stratiienko
2020-01-01 20:47 ` [PATCH v3 2/2] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame roman.stratiienko
2020-01-01 20:47 ` roman.stratiienko
2020-01-01 20:47 ` roman.stratiienko
2020-01-02 7:42 ` Jernej Škrabec
2020-01-02 7:42 ` Jernej Škrabec
2020-01-02 7:42 ` Jernej Škrabec
2020-01-02 7:57 ` Chen-Yu Tsai
2020-01-02 7:57 ` Chen-Yu Tsai
2020-01-02 7:57 ` Chen-Yu Tsai
2020-01-02 16:36 ` Roman Stratiienko
2020-01-02 16:36 ` Roman Stratiienko
2020-01-02 16:36 ` Roman Stratiienko
2020-01-02 10:08 ` Maxime Ripard
2020-01-02 10:08 ` Maxime Ripard
2020-01-02 10:08 ` Maxime Ripard
2020-01-02 16:32 ` Roman Stratiienko [this message]
2020-01-02 16:32 ` Roman Stratiienko
2020-01-02 16:32 ` Roman Stratiienko
2020-01-02 17:25 ` Jernej Škrabec
2020-01-02 17:25 ` Jernej Škrabec
2020-01-02 17:25 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAODwZ7uqf4v8XjOLCn=SoUQchst_b96VCNdaunzn9Q21zPcQ7w@mail.gmail.com' \
--to=roman.stratiienko@globallogic.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.