All of lore.kernel.org
 help / color / mirror / Atom feed
* Checkpatch errors
@ 2019-04-05 14:05 Roman Stratiienko
  2019-04-05 14:24 ` Jan Kiszka
  0 siblings, 1 reply; 2+ messages in thread
From: Roman Stratiienko @ 2019-04-05 14:05 UTC (permalink / raw)
  To: Jan Kiszka, xenomai

Hello Jan,

Let me share some of checkpatch findings after recent update:

--------------------------------------------------------------------
Commit 67549038b677 ("rtnet: e1000e: Account for timer API changes")
--------------------------------------------------------------------
WARNING: LINUX_VERSION_CODE should be avoided, code should be for the
version to which it is merged
#21: FILE: kernel/drivers/net/drivers/e1000e/netdev.c:2882:
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,14,0)
ERROR: space required after that ',' (ctx:VxV)
#21: FILE: kernel/drivers/net/drivers/e1000e/netdev.c:2882:
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,14,0)
---

Best regards,
Roman Stratiienko
Global Logic

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: Checkpatch errors
  2019-04-05 14:05 Checkpatch errors Roman Stratiienko
@ 2019-04-05 14:24 ` Jan Kiszka
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2019-04-05 14:24 UTC (permalink / raw)
  To: Roman Stratiienko, xenomai

On 05.04.19 16:05, Roman Stratiienko wrote:
> Hello Jan,
> 
> Let me share some of checkpatch findings after recent update:
> 
> --------------------------------------------------------------------
> Commit 67549038b677 ("rtnet: e1000e: Account for timer API changes")
> --------------------------------------------------------------------
> WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to
> which it is merged
> #21: FILE: kernel/drivers/net/drivers/e1000e/netdev.c:2882:
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,14,0)
> ERROR: space required after that ',' (ctx:VxV)
> #21: FILE: kernel/drivers/net/drivers/e1000e/netdev.c:2882:
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,14,0)

Thanks, but these are false positives. Upstream (in the few cases it has) does
the same.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-05 14:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-05 14:05 Checkpatch errors Roman Stratiienko
2019-04-05 14:24 ` Jan Kiszka

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.