* [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings
[not found] <201501211941.NPuKVMjL%fengguang.wu@intel.com>
@ 2015-01-21 11:19 ` kbuild test robot
2015-01-21 11:37 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2015-01-21 11:19 UTC (permalink / raw)
To: Vincent Yang
Cc: kbuild-all, Ulf Hansson, Andy Green, Tetsuya Takinishi,
Chris Ball, linux-mmc, linux-kernel
drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
sdhci_f_sdh30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mmc/host/sdhci_f_sdh30.c
+++ b/drivers/mmc/host/sdhci_f_sdh30.c
@@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host->ioaddr = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(host->ioaddr)) {
- ret = PTR_ERR(host);
+ ret = PTR_ERR(host->ioaddr);
goto err;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings
2015-01-21 11:19 ` [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings kbuild test robot
@ 2015-01-21 11:37 ` Ulf Hansson
2015-01-21 11:45 ` Vincent Yang
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Hansson @ 2015-01-21 11:37 UTC (permalink / raw)
To: kbuild test robot
Cc: Vincent Yang, kbuild-all, Andy Green, Tetsuya Takinishi,
Chris Ball, linux-mmc, linux-kernel
On 21 January 2015 at 12:19, kbuild test robot <fengguang.wu@intel.com> wrote:
> drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144
>
> PTR_ERR should access the value just tested by IS_ERR
>
> Semantic patch information:
> There can be false positives in the patch case, where it is the call
> IS_ERR that is wrong.
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Cool script. :-)
>
> CC: Vincent Yang <vincent.yang.fujitsu@gmail.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks! Applied for next.
Kind regards
Uffe
> ---
>
> sdhci_f_sdh30.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/mmc/host/sdhci_f_sdh30.c
> +++ b/drivers/mmc/host/sdhci_f_sdh30.c
> @@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> host->ioaddr = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(host->ioaddr)) {
> - ret = PTR_ERR(host);
> + ret = PTR_ERR(host->ioaddr);
> goto err;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings
2015-01-21 11:37 ` Ulf Hansson
@ 2015-01-21 11:45 ` Vincent Yang
0 siblings, 0 replies; 3+ messages in thread
From: Vincent Yang @ 2015-01-21 11:45 UTC (permalink / raw)
To: Ulf Hansson
Cc: kbuild test robot, kbuild-all, Andy Green, Tetsuya Takinishi,
Chris Ball, linux-mmc, linux-kernel
2015-01-21 19:37 GMT+08:00 Ulf Hansson <ulf.hansson@linaro.org>:
> On 21 January 2015 at 12:19, kbuild test robot <fengguang.wu@intel.com> wrote:
>> drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144
>>
>> PTR_ERR should access the value just tested by IS_ERR
>>
>> Semantic patch information:
>> There can be false positives in the patch case, where it is the call
>> IS_ERR that is wrong.
>>
>> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> Cool script. :-)
>
>>
>> CC: Vincent Yang <vincent.yang.fujitsu@gmail.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
> Thanks! Applied for next.
>
> Kind regards
> Uffe
Thanks a lot!
Kind regards
Vincent
>
>> ---
>>
>> sdhci_f_sdh30.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/mmc/host/sdhci_f_sdh30.c
>> +++ b/drivers/mmc/host/sdhci_f_sdh30.c
>> @@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> host->ioaddr = devm_ioremap_resource(&pdev->dev, res);
>> if (IS_ERR(host->ioaddr)) {
>> - ret = PTR_ERR(host);
>> + ret = PTR_ERR(host->ioaddr);
>> goto err;
>> }
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-21 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201501211941.NPuKVMjL%fengguang.wu@intel.com>
2015-01-21 11:19 ` [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings kbuild test robot
2015-01-21 11:37 ` Ulf Hansson
2015-01-21 11:45 ` Vincent Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.