From: Philippe Ombredanne <pombredanne@nexb.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>
Subject: Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/
Date: Sun, 5 Nov 2017 13:53:54 +0100 [thread overview]
Message-ID: <CAOFm3uHiBsqkf8NPCyujiSO74UmMapPWMGuQmqdCEOk_c86qgw@mail.gmail.com> (raw)
In-Reply-To: <20171104104010.GA27490@kroah.com>
On Sat, Nov 4, 2017 at 11:40 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Nov 03, 2017 at 05:53:01PM +0100, Johan Hovold wrote:
>> On Fri, Nov 03, 2017 at 11:28:30AM +0100, Greg Kroah-Hartman wrote:
>> > It's good to have SPDX identifiers in all files to make it easier to
>> > audit the kernel tree for correct licenses.
>> >
>> > Update the drivers/usb/ and include/linux/usb* files with the correct
>> > SPDX license identifier based on the license text in the file itself.
>> > The SPDX identifier is a legally binding shorthand, which can be used
>> > instead of the full boiler plate text.
>> >
>> > This work is based on a script and data from Thomas Gleixner, Philippe
>> > Ombredanne, and Kate Stewart.
>> >
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Cc: Kate Stewart <kstewart@linuxfoundation.org>
>> > Cc: Philippe Ombredanne <pombredanne@nexb.com>
>> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> I noticed several MODULE_LICENSE macros which did not match the headers
>> (e.g. "GPL" being used for version 2 only modules) for which I'll send a
>> follow-up patch.
>>
>> Someone should probably write a script for that once the SPDX
>> identifiers are in.
>
> Yes, I think that someone might have a script for that, it will be much
> easier to detect these things now. The issue is that the "v2" marking
> came after the original "GPL" marking for MODULE_LICENSE() from what I
> remember, so many of those will be wrong.
If this can help my [1] tool can detect both header-level licenses-in-comments
as well as MODULE_LICENSE macros. Based on that we could reasonably
easily craft a script that scans a file and report discrepancies
between the two.
FWIW this is the same tool that has been used to provide some input to Greg to
clean things up here.
[1] https://github.com/nexB/scancode-toolkit
--
Cordially
Philippe Ombredanne
next prev parent reply other threads:[~2017-11-05 12:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 8:38 [PATCH] USB: add SPDX identifiers to all files in drivers/usb/ Greg Kroah-Hartman
2017-10-19 8:49 ` Geert Uytterhoeven
2017-10-19 8:52 ` Greg Kroah-Hartman
2017-10-19 9:10 ` Geert Uytterhoeven
2017-10-19 9:15 ` Thomas Gleixner
2017-10-19 9:27 ` Felipe Balbi
2017-10-19 8:50 ` Thomas Gleixner
2017-10-19 8:57 ` Greg Kroah-Hartman
2017-10-19 8:59 ` Greg Kroah-Hartman
2017-10-19 9:01 ` Thomas Gleixner
2017-10-19 9:10 ` Greg Kroah-Hartman
2017-10-19 10:55 ` Philippe Ombredanne
2017-10-20 17:49 ` Alan Cox
2017-10-21 7:46 ` Greg Kroah-Hartman
2017-10-20 15:26 ` Rob Herring
2017-10-21 7:48 ` Greg Kroah-Hartman
2017-10-24 10:36 ` Philippe Ombredanne
2017-11-03 10:28 ` [PATCH v2] USB: add SPDX identifiers to all remaining " Greg Kroah-Hartman
2017-11-03 10:29 ` Greg Kroah-Hartman
2017-11-03 10:50 ` Felipe Balbi
2017-11-03 12:08 ` Greg Kroah-Hartman
2017-11-03 16:53 ` Johan Hovold
2017-11-04 10:40 ` Greg Kroah-Hartman
2017-11-05 12:53 ` Philippe Ombredanne [this message]
2017-11-05 13:51 ` Greg Kroah-Hartman
2017-11-05 15:39 ` Philippe Ombredanne
2017-11-06 8:17 ` Greg Kroah-Hartman
2017-11-09 9:51 ` Pavel Machek
2017-11-09 10:40 ` Greg Kroah-Hartman
2017-11-09 10:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOFm3uHiBsqkf8NPCyujiSO74UmMapPWMGuQmqdCEOk_c86qgw@mail.gmail.com \
--to=pombredanne@nexb.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.