* [PATCH v2 0/2] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller. @ 2015-03-30 14:46 ` Suman Tripathi 0 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-03-30 14:46 UTC (permalink / raw) To: chris, anton, arnd Cc: linux-mmc, linuxppc-dev, devicetree, linux-arm-kernel, ddutile, jcm, mlangsdo, patches, Suman Tripathi This patch adds the SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller. v1 change: * Use the CONFIG_ARM64_DMA_HAS_IOMMU for dma-mapping. v2 change: * Drop the IOMMU support and switching to PIO mode for arasan controller integrated inside APM X-Gene SoC. Signed-off-by: Suman Tripathi <stripathi@apm.com> Suman Tripathi (2): arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c arch/arm64/boot/dts/apm-storm.dtsi | 44 ++++++++++++++++++++++++++++++++++++++ drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++ 2 files changed, 59 insertions(+) -- 1.8.2.1 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 0/2] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller. @ 2015-03-30 14:46 ` Suman Tripathi 0 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-03-30 14:46 UTC (permalink / raw) To: chris, anton, arnd Cc: devicetree, mlangsdo, Suman Tripathi, jcm, linux-mmc, patches, ddutile, linuxppc-dev, linux-arm-kernel This patch adds the SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller. v1 change: * Use the CONFIG_ARM64_DMA_HAS_IOMMU for dma-mapping. v2 change: * Drop the IOMMU support and switching to PIO mode for arasan controller integrated inside APM X-Gene SoC. Signed-off-by: Suman Tripathi <stripathi@apm.com> Suman Tripathi (2): arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c arch/arm64/boot/dts/apm-storm.dtsi | 44 ++++++++++++++++++++++++++++++++++++++ drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++ 2 files changed, 59 insertions(+) -- 1.8.2.1 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. 2015-03-30 14:46 ` Suman Tripathi @ 2015-03-30 14:46 ` Suman Tripathi -1 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-03-30 14:46 UTC (permalink / raw) To: chris, anton, arnd Cc: linux-mmc, linuxppc-dev, devicetree, linux-arm-kernel, ddutile, jcm, mlangsdo, patches, Suman Tripathi This patch adds the arasan sdhc nodes to reuse the of-arasan driver for APM X-Gene SoC. Signed-off-by: Suman Tripathi <stripathi@apm.com> --- arch/arm64/boot/dts/apm-storm.dtsi | 44 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi index c5f0a47..fd1c142 100644 --- a/arch/arm64/boot/dts/apm-storm.dtsi +++ b/arch/arm64/boot/dts/apm-storm.dtsi @@ -144,6 +144,40 @@ clock-output-names = "socplldiv2"; }; + ahbclk: ahbclk@1f2ac000 { + compatible = "apm,xgene-device-clock"; + #clock-cells = <1>; + clocks = <&socplldiv2 0>; + reg = <0x0 0x1f2ac000 0x0 0x1000 + 0x0 0x17000000 0x0 0x2000>; + reg-names = "csr-reg", "div-reg"; + csr-offset = <0x0>; + csr-mask = <0x1>; + enable-offset = <0x8>; + enable-mask = <0x1>; + divider-offset = <0x164>; + divider-width = <0x5>; + divider-shift = <0x0>; + clock-output-names = "ahbclk"; + }; + + sdioclk: sdioclk@1f2ac000 { + compatible = "apm,xgene-device-clock"; + #clock-cells = <1>; + clocks = <&socplldiv2 0>; + reg = <0x0 0x1f2ac000 0x0 0x1000 + 0x0 0x17000000 0x0 0x2000>; + reg-names = "csr-reg", "div-reg"; + csr-offset = <0x0>; + csr-mask = <0x2>; + enable-offset = <0x8>; + enable-mask = <0x2>; + divider-offset = <0x178>; + divider-width = <0x8>; + divider-shift = <0x0>; + clock-output-names = "sdioclk"; + }; + qmlclk: qmlclk { compatible = "apm,xgene-device-clock"; #clock-cells = <1>; @@ -282,6 +316,16 @@ interrupts = <0x0 0x4c 0x4>; }; + sdhc0: sdhc@1c000000 { + device_type = "sdhc"; + compatible = "arasan,sdhci-8.9a"; + reg = <0x0 0x1c000000 0x0 0x100>; + interrupts = <0x0 0x49 0x4>; + dma-coherent; + clock-names = "clk_xin", "clk_ahb"; + clocks = <&sdioclk 0>, <&ahbclk 0>; + }; + phy1: phy@1f21a000 { compatible = "apm,xgene-phy"; reg = <0x0 0x1f21a000 0x0 0x100>; -- 1.8.2.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. @ 2015-03-30 14:46 ` Suman Tripathi 0 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-03-30 14:46 UTC (permalink / raw) To: chris, anton, arnd Cc: devicetree, mlangsdo, Suman Tripathi, jcm, linux-mmc, patches, ddutile, linuxppc-dev, linux-arm-kernel This patch adds the arasan sdhc nodes to reuse the of-arasan driver for APM X-Gene SoC. Signed-off-by: Suman Tripathi <stripathi@apm.com> --- arch/arm64/boot/dts/apm-storm.dtsi | 44 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi index c5f0a47..fd1c142 100644 --- a/arch/arm64/boot/dts/apm-storm.dtsi +++ b/arch/arm64/boot/dts/apm-storm.dtsi @@ -144,6 +144,40 @@ clock-output-names = "socplldiv2"; }; + ahbclk: ahbclk@1f2ac000 { + compatible = "apm,xgene-device-clock"; + #clock-cells = <1>; + clocks = <&socplldiv2 0>; + reg = <0x0 0x1f2ac000 0x0 0x1000 + 0x0 0x17000000 0x0 0x2000>; + reg-names = "csr-reg", "div-reg"; + csr-offset = <0x0>; + csr-mask = <0x1>; + enable-offset = <0x8>; + enable-mask = <0x1>; + divider-offset = <0x164>; + divider-width = <0x5>; + divider-shift = <0x0>; + clock-output-names = "ahbclk"; + }; + + sdioclk: sdioclk@1f2ac000 { + compatible = "apm,xgene-device-clock"; + #clock-cells = <1>; + clocks = <&socplldiv2 0>; + reg = <0x0 0x1f2ac000 0x0 0x1000 + 0x0 0x17000000 0x0 0x2000>; + reg-names = "csr-reg", "div-reg"; + csr-offset = <0x0>; + csr-mask = <0x2>; + enable-offset = <0x8>; + enable-mask = <0x2>; + divider-offset = <0x178>; + divider-width = <0x8>; + divider-shift = <0x0>; + clock-output-names = "sdioclk"; + }; + qmlclk: qmlclk { compatible = "apm,xgene-device-clock"; #clock-cells = <1>; @@ -282,6 +316,16 @@ interrupts = <0x0 0x4c 0x4>; }; + sdhc0: sdhc@1c000000 { + device_type = "sdhc"; + compatible = "arasan,sdhci-8.9a"; + reg = <0x0 0x1c000000 0x0 0x100>; + interrupts = <0x0 0x49 0x4>; + dma-coherent; + clock-names = "clk_xin", "clk_ahb"; + clocks = <&sdioclk 0>, <&ahbclk 0>; + }; + phy1: phy@1f21a000 { compatible = "apm,xgene-phy"; reg = <0x0 0x1f21a000 0x0 0x100>; -- 1.8.2.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c 2015-03-30 14:46 ` Suman Tripathi @ 2015-03-30 14:46 ` Suman Tripathi -1 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-03-30 14:46 UTC (permalink / raw) To: chris, anton, arnd Cc: linux-mmc, linuxppc-dev, devicetree, linux-arm-kernel, ddutile, jcm, mlangsdo, patches, Suman Tripathi This patch adds some quirks support to be read from fdt. Signed-off-by: Suman Tripathi <stripathi@apm.com> --- drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index bef250e..9f6a4b9 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) if (of_get_property(np, "broken-cd", NULL)) host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; + + if (of_get_property(np, "delay-after-power", NULL)) + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; + + if (of_get_property(np, "no-hispd", NULL)) + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; + + if (of_get_property(np, "broken-adma", NULL)) + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; + + if (of_get_property(np, "broken-dma", NULL)) + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; + + if (of_get_property(np, "no-cmd23", NULL)) + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; if (of_get_property(np, "no-1-8-v", NULL)) host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; -- 1.8.2.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c @ 2015-03-30 14:46 ` Suman Tripathi 0 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-03-30 14:46 UTC (permalink / raw) To: chris, anton, arnd Cc: devicetree, mlangsdo, Suman Tripathi, jcm, linux-mmc, patches, ddutile, linuxppc-dev, linux-arm-kernel This patch adds some quirks support to be read from fdt. Signed-off-by: Suman Tripathi <stripathi@apm.com> --- drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index bef250e..9f6a4b9 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) if (of_get_property(np, "broken-cd", NULL)) host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; + + if (of_get_property(np, "delay-after-power", NULL)) + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; + + if (of_get_property(np, "no-hispd", NULL)) + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; + + if (of_get_property(np, "broken-adma", NULL)) + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; + + if (of_get_property(np, "broken-dma", NULL)) + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; + + if (of_get_property(np, "no-cmd23", NULL)) + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; if (of_get_property(np, "no-1-8-v", NULL)) host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; -- 1.8.2.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c 2015-03-30 14:46 ` Suman Tripathi (?) @ 2015-04-08 9:40 ` Ulf Hansson -1 siblings, 0 replies; 14+ messages in thread From: Ulf Hansson @ 2015-04-08 9:40 UTC (permalink / raw) To: Suman Tripathi Cc: Chris Ball, Anton Vorontsov, Arnd Bergmann, linux-mmc, linuxppc-dev, devicetree, linux-arm-kernel, ddutile, jcm, mlangsdo, patches On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... Kind regards Uffe > > if (of_get_property(np, "no-1-8-v", NULL)) > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; > -- > 1.8.2.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c @ 2015-04-08 9:40 ` Ulf Hansson 0 siblings, 0 replies; 14+ messages in thread From: Ulf Hansson @ 2015-04-08 9:40 UTC (permalink / raw) To: linux-arm-kernel On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... Kind regards Uffe > > if (of_get_property(np, "no-1-8-v", NULL)) > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; > -- > 1.8.2.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c @ 2015-04-08 9:40 ` Ulf Hansson 0 siblings, 0 replies; 14+ messages in thread From: Ulf Hansson @ 2015-04-08 9:40 UTC (permalink / raw) To: Suman Tripathi Cc: devicetree, mlangsdo, Arnd Bergmann, jcm, Anton Vorontsov, linux-mmc, Chris Ball, patches, ddutile, linuxppc-dev, linux-arm-kernel On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... Kind regards Uffe > > if (of_get_property(np, "no-1-8-v", NULL)) > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; > -- > 1.8.2.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c 2015-04-08 9:40 ` Ulf Hansson @ 2015-04-09 16:10 ` Suman Tripathi -1 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-04-09 16:10 UTC (permalink / raw) To: Ulf Hansson Cc: devicetree, Mark Langsdorf, Arnd Bergmann, Jon Masters, Anton Vorontsov, linux-mmc, Chris Ball, patches, Don Dutile, linuxppc-dev, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 3803 bytes --] On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... We are using arasan controller in our SOC. So reusing a the existing sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us only option left to pass the info is DTS or ACPI table. Kind regards Uffe On Wed, Apr 8, 2015 at 3:10 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > > This patch adds some quirks support to be read from fdt. > > > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > > --- > > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-pltfm.c > b/drivers/mmc/host/sdhci-pltfm.c > > index bef250e..9f6a4b9 100644 > > --- a/drivers/mmc/host/sdhci-pltfm.c > > +++ b/drivers/mmc/host/sdhci-pltfm.c > > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device > *pdev) > > > > if (of_get_property(np, "broken-cd", NULL)) > > host->quirks |= > SDHCI_QUIRK_BROKEN_CARD_DETECTION; > > + > > + if (of_get_property(np, "delay-after-power", NULL)) > > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > > + > > + if (of_get_property(np, "no-hispd", NULL)) > > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > > + > > + if (of_get_property(np, "broken-adma", NULL)) > > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > > + > > + if (of_get_property(np, "broken-dma", NULL)) > > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > > + > > + if (of_get_property(np, "no-cmd23", NULL)) > > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; > > Can't at least some of these be distinguished from what sdhci variant > that is being used? Instead of having them in DT... > > Kind regards > Uffe > > > > > if (of_get_property(np, "no-1-8-v", NULL)) > > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; > > -- > > 1.8.2.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Thanks, with regards, Suman Tripathi [-- Attachment #1.2: Type: text/html, Size: 6211 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c @ 2015-04-09 16:10 ` Suman Tripathi 0 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-04-09 16:10 UTC (permalink / raw) To: Ulf Hansson Cc: devicetree, Mark Langsdorf, Arnd Bergmann, Jon Masters, Anton Vorontsov, linux-mmc, Chris Ball, patches, Don Dutile, linuxppc-dev, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 3803 bytes --] On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... We are using arasan controller in our SOC. So reusing a the existing sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us only option left to pass the info is DTS or ACPI table. Kind regards Uffe On Wed, Apr 8, 2015 at 3:10 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > > This patch adds some quirks support to be read from fdt. > > > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > > --- > > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-pltfm.c > b/drivers/mmc/host/sdhci-pltfm.c > > index bef250e..9f6a4b9 100644 > > --- a/drivers/mmc/host/sdhci-pltfm.c > > +++ b/drivers/mmc/host/sdhci-pltfm.c > > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device > *pdev) > > > > if (of_get_property(np, "broken-cd", NULL)) > > host->quirks |= > SDHCI_QUIRK_BROKEN_CARD_DETECTION; > > + > > + if (of_get_property(np, "delay-after-power", NULL)) > > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > > + > > + if (of_get_property(np, "no-hispd", NULL)) > > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > > + > > + if (of_get_property(np, "broken-adma", NULL)) > > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > > + > > + if (of_get_property(np, "broken-dma", NULL)) > > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > > + > > + if (of_get_property(np, "no-cmd23", NULL)) > > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; > > Can't at least some of these be distinguished from what sdhci variant > that is being used? Instead of having them in DT... > > Kind regards > Uffe > > > > > if (of_get_property(np, "no-1-8-v", NULL)) > > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; > > -- > > 1.8.2.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Thanks, with regards, Suman Tripathi [-- Attachment #2: Type: text/html, Size: 6211 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CAOHikRArf+Fqv0JbQ1jM19zWGj-fBDcPie6apgkydgBLOm=x0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c 2015-04-09 16:10 ` Suman Tripathi (?) @ 2015-04-09 16:11 ` Suman Tripathi -1 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-04-09 16:11 UTC (permalink / raw) To: Ulf Hansson Cc: Chris Ball, Anton Vorontsov, Arnd Bergmann, linux-mmc, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Don Dutile, Jon Masters, Mark Langsdorf, patches On 30 March 2015 at 16:46, Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... We are using arasan controller in our SOC. So reusing a the existing sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us only option left to pass the info is DTS or ACPI table. Kind regards Uffe On Thu, Apr 9, 2015 at 9:40 PM, Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> wrote: > On 30 March 2015 at 16:46, Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> wrote: >> This patch adds some quirks support to be read from fdt. >> >> Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> >> --- >> drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-pltfm.c >> b/drivers/mmc/host/sdhci-pltfm.c >> index bef250e..9f6a4b9 100644 >> --- a/drivers/mmc/host/sdhci-pltfm.c >> +++ b/drivers/mmc/host/sdhci-pltfm.c >> @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> *pdev) >> >> if (of_get_property(np, "broken-cd", NULL)) >> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> + >> + if (of_get_property(np, "delay-after-power", NULL)) >> + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> + >> + if (of_get_property(np, "no-hispd", NULL)) >> + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> + >> + if (of_get_property(np, "broken-adma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> + >> + if (of_get_property(np, "broken-dma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> + >> + if (of_get_property(np, "no-cmd23", NULL)) >> + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; > > Can't at least some of these be distinguished from what sdhci variant > that is being used? Instead of having them in DT... > > We are using arasan controller in our SOC. So reusing a the existing > sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us > only option left to pass the info is DTS or ACPI table. > > Kind regards > Uffe > > On Wed, Apr 8, 2015 at 3:10 PM, Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: >> >> On 30 March 2015 at 16:46, Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> wrote: >> > This patch adds some quirks support to be read from fdt. >> > >> > Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org> >> > --- >> > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/drivers/mmc/host/sdhci-pltfm.c >> > b/drivers/mmc/host/sdhci-pltfm.c >> > index bef250e..9f6a4b9 100644 >> > --- a/drivers/mmc/host/sdhci-pltfm.c >> > +++ b/drivers/mmc/host/sdhci-pltfm.c >> > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> > *pdev) >> > >> > if (of_get_property(np, "broken-cd", NULL)) >> > host->quirks |= >> > SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> > + >> > + if (of_get_property(np, "delay-after-power", NULL)) >> > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> > + >> > + if (of_get_property(np, "no-hispd", NULL)) >> > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> > + >> > + if (of_get_property(np, "broken-adma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> > + >> > + if (of_get_property(np, "broken-dma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> > + >> > + if (of_get_property(np, "no-cmd23", NULL)) >> > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; >> >> Can't at least some of these be distinguished from what sdhci variant >> that is being used? Instead of having them in DT... >> >> Kind regards >> Uffe >> >> > >> > if (of_get_property(np, "no-1-8-v", NULL)) >> > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; >> > -- >> > 1.8.2.1 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > Thanks, > with regards, > Suman Tripathi -- Thanks, with regards, Suman Tripathi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c @ 2015-04-09 16:11 ` Suman Tripathi 0 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-04-09 16:11 UTC (permalink / raw) To: linux-arm-kernel On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... We are using arasan controller in our SOC. So reusing a the existing sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us only option left to pass the info is DTS or ACPI table. Kind regards Uffe On Thu, Apr 9, 2015 at 9:40 PM, Suman Tripathi <stripathi@apm.com> wrote: > On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: >> This patch adds some quirks support to be read from fdt. >> >> Signed-off-by: Suman Tripathi <stripathi@apm.com> >> --- >> drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-pltfm.c >> b/drivers/mmc/host/sdhci-pltfm.c >> index bef250e..9f6a4b9 100644 >> --- a/drivers/mmc/host/sdhci-pltfm.c >> +++ b/drivers/mmc/host/sdhci-pltfm.c >> @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> *pdev) >> >> if (of_get_property(np, "broken-cd", NULL)) >> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> + >> + if (of_get_property(np, "delay-after-power", NULL)) >> + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> + >> + if (of_get_property(np, "no-hispd", NULL)) >> + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> + >> + if (of_get_property(np, "broken-adma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> + >> + if (of_get_property(np, "broken-dma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> + >> + if (of_get_property(np, "no-cmd23", NULL)) >> + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; > > Can't at least some of these be distinguished from what sdhci variant > that is being used? Instead of having them in DT... > > We are using arasan controller in our SOC. So reusing a the existing > sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us > only option left to pass the info is DTS or ACPI table. > > Kind regards > Uffe > > On Wed, Apr 8, 2015 at 3:10 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: >> >> On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: >> > This patch adds some quirks support to be read from fdt. >> > >> > Signed-off-by: Suman Tripathi <stripathi@apm.com> >> > --- >> > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/drivers/mmc/host/sdhci-pltfm.c >> > b/drivers/mmc/host/sdhci-pltfm.c >> > index bef250e..9f6a4b9 100644 >> > --- a/drivers/mmc/host/sdhci-pltfm.c >> > +++ b/drivers/mmc/host/sdhci-pltfm.c >> > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> > *pdev) >> > >> > if (of_get_property(np, "broken-cd", NULL)) >> > host->quirks |= >> > SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> > + >> > + if (of_get_property(np, "delay-after-power", NULL)) >> > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> > + >> > + if (of_get_property(np, "no-hispd", NULL)) >> > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> > + >> > + if (of_get_property(np, "broken-adma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> > + >> > + if (of_get_property(np, "broken-dma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> > + >> > + if (of_get_property(np, "no-cmd23", NULL)) >> > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; >> >> Can't at least some of these be distinguished from what sdhci variant >> that is being used? Instead of having them in DT... >> >> Kind regards >> Uffe >> >> > >> > if (of_get_property(np, "no-1-8-v", NULL)) >> > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; >> > -- >> > 1.8.2.1 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> > the body of a message to majordomo at vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > Thanks, > with regards, > Suman Tripathi -- Thanks, with regards, Suman Tripathi ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c @ 2015-04-09 16:11 ` Suman Tripathi 0 siblings, 0 replies; 14+ messages in thread From: Suman Tripathi @ 2015-04-09 16:11 UTC (permalink / raw) To: Ulf Hansson Cc: devicetree, Mark Langsdorf, Arnd Bergmann, Jon Masters, Anton Vorontsov, linux-mmc, Chris Ball, patches, Don Dutile, linuxppc-dev, linux-arm-kernel On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index bef250e..9f6a4b9 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_get_property(np, "broken-cd", NULL)) > host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; > + > + if (of_get_property(np, "delay-after-power", NULL)) > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; > + > + if (of_get_property(np, "no-hispd", NULL)) > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; > + > + if (of_get_property(np, "broken-adma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; > + > + if (of_get_property(np, "broken-dma", NULL)) > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; > + > + if (of_get_property(np, "no-cmd23", NULL)) > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; Can't at least some of these be distinguished from what sdhci variant that is being used? Instead of having them in DT... We are using arasan controller in our SOC. So reusing a the existing sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us only option left to pass the info is DTS or ACPI table. Kind regards Uffe On Thu, Apr 9, 2015 at 9:40 PM, Suman Tripathi <stripathi@apm.com> wrote: > On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: >> This patch adds some quirks support to be read from fdt. >> >> Signed-off-by: Suman Tripathi <stripathi@apm.com> >> --- >> drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-pltfm.c >> b/drivers/mmc/host/sdhci-pltfm.c >> index bef250e..9f6a4b9 100644 >> --- a/drivers/mmc/host/sdhci-pltfm.c >> +++ b/drivers/mmc/host/sdhci-pltfm.c >> @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> *pdev) >> >> if (of_get_property(np, "broken-cd", NULL)) >> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> + >> + if (of_get_property(np, "delay-after-power", NULL)) >> + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> + >> + if (of_get_property(np, "no-hispd", NULL)) >> + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> + >> + if (of_get_property(np, "broken-adma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> + >> + if (of_get_property(np, "broken-dma", NULL)) >> + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> + >> + if (of_get_property(np, "no-cmd23", NULL)) >> + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; > > Can't at least some of these be distinguished from what sdhci variant > that is being used? Instead of having them in DT... > > We are using arasan controller in our SOC. So reusing a the existing > sdhci-of-arasan driver. Due to H/W issues we require this quirks. So for us > only option left to pass the info is DTS or ACPI table. > > Kind regards > Uffe > > On Wed, Apr 8, 2015 at 3:10 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: >> >> On 30 March 2015 at 16:46, Suman Tripathi <stripathi@apm.com> wrote: >> > This patch adds some quirks support to be read from fdt. >> > >> > Signed-off-by: Suman Tripathi <stripathi@apm.com> >> > --- >> > drivers/mmc/host/sdhci-pltfm.c | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/drivers/mmc/host/sdhci-pltfm.c >> > b/drivers/mmc/host/sdhci-pltfm.c >> > index bef250e..9f6a4b9 100644 >> > --- a/drivers/mmc/host/sdhci-pltfm.c >> > +++ b/drivers/mmc/host/sdhci-pltfm.c >> > @@ -85,6 +85,21 @@ void sdhci_get_of_property(struct platform_device >> > *pdev) >> > >> > if (of_get_property(np, "broken-cd", NULL)) >> > host->quirks |= >> > SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> > + >> > + if (of_get_property(np, "delay-after-power", NULL)) >> > + host->quirks |= SDHCI_QUIRK_DELAY_AFTER_POWER; >> > + >> > + if (of_get_property(np, "no-hispd", NULL)) >> > + host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT; >> > + >> > + if (of_get_property(np, "broken-adma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_ADMA; >> > + >> > + if (of_get_property(np, "broken-dma", NULL)) >> > + host->quirks |= SDHCI_QUIRK_BROKEN_DMA; >> > + >> > + if (of_get_property(np, "no-cmd23", NULL)) >> > + host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; >> >> Can't at least some of these be distinguished from what sdhci variant >> that is being used? Instead of having them in DT... >> >> Kind regards >> Uffe >> >> > >> > if (of_get_property(np, "no-1-8-v", NULL)) >> > host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V; >> > -- >> > 1.8.2.1 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> > the body of a message to majordomo@vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > Thanks, > with regards, > Suman Tripathi -- Thanks, with regards, Suman Tripathi ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-04-09 16:17 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-30 14:46 [PATCH v2 0/2] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller Suman Tripathi
2015-03-30 14:46 ` Suman Tripathi
2015-03-30 14:46 ` [PATCH v2 1/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi Suman Tripathi
2015-03-30 14:46 ` Suman Tripathi
2015-03-30 14:46 ` [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c Suman Tripathi
2015-03-30 14:46 ` Suman Tripathi
2015-04-08 9:40 ` Ulf Hansson
2015-04-08 9:40 ` Ulf Hansson
2015-04-08 9:40 ` Ulf Hansson
2015-04-09 16:10 ` Suman Tripathi
2015-04-09 16:10 ` Suman Tripathi
[not found] ` <CAOHikRArf+Fqv0JbQ1jM19zWGj-fBDcPie6apgkydgBLOm=x0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-09 16:11 ` Suman Tripathi
2015-04-09 16:11 ` Suman Tripathi
2015-04-09 16:11 ` Suman Tripathi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.