All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@gmail.com>
To: Zong Li <zong.li@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	David Abdurachmanov <david.abdurachmanov@sifive.com>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] riscv: Set more data to cacheinfo
Date: Mon, 31 Aug 2020 10:00:17 +0300	[thread overview]
Message-ID: <CAOJsxLF_+0eg6zU=CFwnN+pc75jF4aqvUqog5z18wfG4WOKoDQ@mail.gmail.com> (raw)
In-Reply-To: <CANXhq0r2jg_fVZJE0shquGc25QNgenL+Qq6HRUBXEYPSf=QcFQ@mail.gmail.com>

Hi,

On Mon, Aug 31, 2020 at 9:15 AM Zong Li <zong.li@sifive.com> wrote:
> If the sets is one, it means that the cache is fully associative, then
> we don't need to fill the ways number, just keep way number as zero,
> so here we want to find the fully associative case first and make the
> if expression fail at the beginning. We might also rewrite it as
> follow:

[snip]

Thanks for the explanation! The rewritten version is much easier to
read, at least to me.

- Pekka

WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@gmail.com>
To: Zong Li <zong.li@sifive.com>
Cc: David Abdurachmanov <david.abdurachmanov@sifive.com>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v3 1/3] riscv: Set more data to cacheinfo
Date: Mon, 31 Aug 2020 10:00:17 +0300	[thread overview]
Message-ID: <CAOJsxLF_+0eg6zU=CFwnN+pc75jF4aqvUqog5z18wfG4WOKoDQ@mail.gmail.com> (raw)
In-Reply-To: <CANXhq0r2jg_fVZJE0shquGc25QNgenL+Qq6HRUBXEYPSf=QcFQ@mail.gmail.com>

Hi,

On Mon, Aug 31, 2020 at 9:15 AM Zong Li <zong.li@sifive.com> wrote:
> If the sets is one, it means that the cache is fully associative, then
> we don't need to fill the ways number, just keep way number as zero,
> so here we want to find the fully associative case first and make the
> if expression fail at the beginning. We might also rewrite it as
> follow:

[snip]

Thanks for the explanation! The rewritten version is much easier to
read, at least to me.

- Pekka

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2020-08-31  7:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28  7:09 [PATCH v3 0/3] Get cache information from userland Zong Li
2020-08-28  7:09 ` Zong Li
2020-08-28  7:09 ` [PATCH v3 1/3] riscv: Set more data to cacheinfo Zong Li
2020-08-28  7:09   ` Zong Li
2020-08-30  7:53   ` Pekka Enberg
2020-08-30  7:53     ` Pekka Enberg
2020-08-31  6:15     ` Zong Li
2020-08-31  6:15       ` Zong Li
2020-08-31  7:00       ` Pekka Enberg [this message]
2020-08-31  7:00         ` Pekka Enberg
2020-08-31  7:13         ` Zong Li
2020-08-31  7:13           ` Zong Li
2020-08-28  7:09 ` [PATCH v3 2/3] riscv: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Zong Li
2020-08-28  7:09   ` Zong Li
2020-08-28  7:09 ` [PATCH v3 3/3] riscv: Add cache information in AUX vector Zong Li
2020-08-28  7:09   ` Zong Li
2020-08-30  8:01   ` Pekka Enberg
2020-08-30  8:01     ` Pekka Enberg
2020-08-31  6:23     ` Zong Li
2020-08-31  6:23       ` Zong Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOJsxLF_+0eg6zU=CFwnN+pc75jF4aqvUqog5z18wfG4WOKoDQ@mail.gmail.com' \
    --to=penberg@gmail.com \
    --cc=david.abdurachmanov@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.