All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
	gorcunov@gmail.com, prasadjoshi124@gmail.com
Subject: Re: [PATCH 4/4] kvm tools: Implement MSI-X for virtio-rng
Date: Thu, 28 Jul 2011 12:33:17 +0300	[thread overview]
Message-ID: <CAOJsxLGQE+H1M1S3iJNyWX6=s7EyWxogxXO+OuGB-pkuGYZ1XQ@mail.gmail.com> (raw)
In-Reply-To: <1311843715-5464-4-git-send-email-levinsasha928@gmail.com>

On Thu, Jul 28, 2011 at 12:01 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> @@ -163,8 +167,21 @@ static bool virtio_rng_pci_io_out(struct ioport *ioport, struct kvm *kvm, u16 po
>                rdev->status            = ioport__read8(data);
>                break;
>        case VIRTIO_MSI_CONFIG_VECTOR:
> -               rdev->config_vector     = VIRTIO_MSI_NO_VECTOR;
> +               rdev->config_vector     = ioport__read16(data);
>                break;
> +       case VIRTIO_MSI_QUEUE_VECTOR:
> +       {

Nit: the curly brace should be on the same line as 'case' keyword.

> +               u32 gsi;
> +               u32 vec;
> +

  reply	other threads:[~2011-07-28  9:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28  9:01 [PATCH 1/4] kvm tools: Use GSI routing Sasha Levin
2011-07-28  9:01 ` [PATCH 2/4] kvm tools: Fix PCI probing Sasha Levin
2011-07-28  9:31   ` Pekka Enberg
2011-07-28  9:38     ` Cyrill Gorcunov
2011-07-28  9:43       ` Pekka Enberg
2011-07-28  9:01 ` [PATCH 3/4] kvm tools: Add a void ptr to be passed to mmio callback Sasha Levin
2011-07-28  9:42   ` Cyrill Gorcunov
2011-07-28  9:43     ` Pekka Enberg
2011-07-28  9:01 ` [PATCH 4/4] kvm tools: Implement MSI-X for virtio-rng Sasha Levin
2011-07-28  9:33   ` Pekka Enberg [this message]
2011-07-28  9:27 ` [PATCH 1/4] kvm tools: Use GSI routing Pekka Enberg
2011-07-28  9:43 ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOJsxLGQE+H1M1S3iJNyWX6=s7EyWxogxXO+OuGB-pkuGYZ1XQ@mail.gmail.com' \
    --to=penberg@kernel.org \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.