Re: [meta-oe][PATCH v2] changed gnuplot recipe license to gnuplot

Re: [meta-oe][PATCH v2] changed gnuplot recipe license to gnuplot

[Stephen Arnold]

Was working with Martin on this one; the "original" patch referred to is
Tim's gnuplot upgrade patch.  The patch being superseded is my earlier
patch from today that included Tim's changes plus the license change.
*And* the license file patch was just resent as a patch to meta-oe, so
hopefully we're good on this one...

Steve


On Tue, Apr 1, 2014 at 4:14 PM, Paul Barker <paul@paulbarker.me.uk> wrote:

> On 1 April 2014 23:36, Stephen Arnold <stephen.arnold42@gmail.com> wrote:
> > Also sent license file patch for oe-core.  This supercedes previous
> gnuplot
> > patch that incorrectly included the original gnuplot patch changes as
> well.
>
> Just got a few bits of general advice on submitting patches to
> OpenEmbedded:
>
> Each patch subject should be of the form "thing: change", where thing
> is usually the recipe name. So this would be "gnuplot: Use gnuplot
> license" or something similar.
>
> The "[PATCH]" tag should be "[PATCH v2]" if you're superseding a
> previously sent but not yet merged patch. In this case, it's unclear
> which patch your mean. Please email in reply to the patch you want to
> cancel so that the maintainers know not to merge it.
>
> There's a lot of further detailed advice and guidelines at
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
>
> Thanks,
>
> --
> Paul Barker
>
> Email: paul@paulbarker.me.uk
> http://www.paulbarker.me.uk
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-oe][PATCH v2] changed gnuplot recipe license to gnuplot

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]

On Tue, Apr 01, 2014 at 05:09:02PM -0700, Stephen Arnold wrote:
> Was working with Martin on this one; the "original" patch referred to is
> Tim's gnuplot upgrade patch.  The patch being superseded is my earlier
> patch from today that included Tim's changes plus the license change.
> *And* the license file patch was just resent as a patch to meta-oe, so
> hopefully we're good on this one...

The commit message should still be improved as Paul says, it also
mentions oe-core patch which isn't true anymore.

It would be even better if you add gnuplot license file in this commit
and in the other one just add the license text for gd. That way we'll
have related changes in the same commit.

> On Tue, Apr 1, 2014 at 4:14 PM, Paul Barker <paul@paulbarker.me.uk> wrote:
> 
> > On 1 April 2014 23:36, Stephen Arnold <stephen.arnold42@gmail.com> wrote:
> > > Also sent license file patch for oe-core.  This supercedes previous
> > gnuplot
> > > patch that incorrectly included the original gnuplot patch changes as
> > well.
> >
> > Just got a few bits of general advice on submitting patches to
> > OpenEmbedded:
> >
> > Each patch subject should be of the form "thing: change", where thing
> > is usually the recipe name. So this would be "gnuplot: Use gnuplot
> > license" or something similar.
> >
> > The "[PATCH]" tag should be "[PATCH v2]" if you're superseding a
> > previously sent but not yet merged patch. In this case, it's unclear
> > which patch your mean. Please email in reply to the patch you want to
> > cancel so that the maintainers know not to merge it.
> >
> > There's a lot of further detailed advice and guidelines at
> > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> >
> > Thanks,
> >
> > --
> > Paul Barker
> >
> > Email: paul@paulbarker.me.uk
> > http://www.paulbarker.me.uk
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [meta-oe][PATCH v2] changed gnuplot recipe license to gnuplot

[Stephen Arnold]

Okay, restructured and resent as requested.

Steve


On Tue, Apr 1, 2014 at 5:41 PM, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Tue, Apr 01, 2014 at 05:09:02PM -0700, Stephen Arnold wrote:
> > Was working with Martin on this one; the "original" patch referred to is
> > Tim's gnuplot upgrade patch.  The patch being superseded is my earlier
> > patch from today that included Tim's changes plus the license change.
> > *And* the license file patch was just resent as a patch to meta-oe, so
> > hopefully we're good on this one...
>
> The commit message should still be improved as Paul says, it also
> mentions oe-core patch which isn't true anymore.
>
> It would be even better if you add gnuplot license file in this commit
> and in the other one just add the license text for gd. That way we'll
> have related changes in the same commit.
>
> > On Tue, Apr 1, 2014 at 4:14 PM, Paul Barker <paul@paulbarker.me.uk>
> wrote:
> >
> > > On 1 April 2014 23:36, Stephen Arnold <stephen.arnold42@gmail.com>
> wrote:
> > > > Also sent license file patch for oe-core.  This supercedes previous
> > > gnuplot
> > > > patch that incorrectly included the original gnuplot patch changes as
> > > well.
> > >
> > > Just got a few bits of general advice on submitting patches to
> > > OpenEmbedded:
> > >
> > > Each patch subject should be of the form "thing: change", where thing
> > > is usually the recipe name. So this would be "gnuplot: Use gnuplot
> > > license" or something similar.
> > >
> > > The "[PATCH]" tag should be "[PATCH v2]" if you're superseding a
> > > previously sent but not yet merged patch. In this case, it's unclear
> > > which patch your mean. Please email in reply to the patch you want to
> > > cancel so that the maintainers know not to merge it.
> > >
> > > There's a lot of further detailed advice and guidelines at
> > > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> > >
> > > Thanks,
> > >
> > > --
> > > Paul Barker
> > >
> > > Email: paul@paulbarker.me.uk
> > > http://www.paulbarker.me.uk
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>