[PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Bhagyashri Dighole]

Remove unused #defines detected by checkpatch.pl.

Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
---
Changes in v3:
  -- Change the subject line according to log messages.
  -- Remove extra spaces.

Changes in v2:
  - Remove unused macro.

 drivers/staging/fbtft/fb_watterott.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
index 0a5206d..502d67f 100644
--- a/drivers/staging/fbtft/fb_watterott.c
+++ b/drivers/staging/fbtft/fb_watterott.c
@@ -90,15 +90,9 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 	return 0;
 }
 
-#define RGB565toRGB323(c) ((((c) & 0xE000) >> 8) |\
-			   (((c) & 000600) >> 6) |\
-			   (((c) & 0x001C) >> 2))
 #define RGB565toRGB332(c) ((((c) & 0xE000) >> 8) |\
 			   (((c) & 000700) >> 6) |\
 			   (((c) & 0x0018) >> 3))
-#define RGB565toRGB233(c) ((((c) & 0xC000) >> 8) |\
-			   (((c) & 000700) >> 5) |\
-			   (((c) & 0x001C) >> 2))
 
 static int write_vmem_8bit(struct fbtft_par *par, size_t offset, size_t len)
 {
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Julia Lawall]

On Wed, 6 Mar 2019, Bhagyashri Dighole wrote:

> Remove unused #defines detected by checkpatch.pl.

Does checkpatch detect unused defines?  I thought it highlighted this code
because of the came case issue.  Checkpatch uses regular expressions.  It
seems that it can now look at a series of lines, but I don't think it can
hunt around for things at arbitrary places in one or more files.

julia

>
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
> Changes in v3:
>   -- Change the subject line according to log messages.
>   -- Remove extra spaces.
>
> Changes in v2:
>   - Remove unused macro.
>
>  drivers/staging/fbtft/fb_watterott.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
> index 0a5206d..502d67f 100644
> --- a/drivers/staging/fbtft/fb_watterott.c
> +++ b/drivers/staging/fbtft/fb_watterott.c
> @@ -90,15 +90,9 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
>  	return 0;
>  }
>
> -#define RGB565toRGB323(c) ((((c) & 0xE000) >> 8) |\
> -			   (((c) & 000600) >> 6) |\
> -			   (((c) & 0x001C) >> 2))
>  #define RGB565toRGB332(c) ((((c) & 0xE000) >> 8) |\
>  			   (((c) & 000700) >> 6) |\
>  			   (((c) & 0x0018) >> 3))
> -#define RGB565toRGB233(c) ((((c) & 0xC000) >> 8) |\
> -			   (((c) & 000700) >> 5) |\
> -			   (((c) & 0x001C) >> 2))
>
>  static int write_vmem_8bit(struct fbtft_par *par, size_t offset, size_t len)
>  {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306052313.GA3924%40bhagyashri-Lenovo-G570.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Julia Lawall]

It would be good to have a cover letter (0/2) for this patch series as
well.

julia

On Wed, 6 Mar 2019, Bhagyashri Dighole wrote:

> Remove unused #defines detected by checkpatch.pl.
>
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
> Changes in v3:
>   -- Change the subject line according to log messages.
>   -- Remove extra spaces.
>
> Changes in v2:
>   - Remove unused macro.
>
>  drivers/staging/fbtft/fb_watterott.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
> index 0a5206d..502d67f 100644
> --- a/drivers/staging/fbtft/fb_watterott.c
> +++ b/drivers/staging/fbtft/fb_watterott.c
> @@ -90,15 +90,9 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
>  	return 0;
>  }
>
> -#define RGB565toRGB323(c) ((((c) & 0xE000) >> 8) |\
> -			   (((c) & 000600) >> 6) |\
> -			   (((c) & 0x001C) >> 2))
>  #define RGB565toRGB332(c) ((((c) & 0xE000) >> 8) |\
>  			   (((c) & 000700) >> 6) |\
>  			   (((c) & 0x0018) >> 3))
> -#define RGB565toRGB233(c) ((((c) & 0xC000) >> 8) |\
> -			   (((c) & 000700) >> 5) |\
> -			   (((c) & 0x001C) >> 2))
>
>  static int write_vmem_8bit(struct fbtft_par *par, size_t offset, size_t len)
>  {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306052313.GA3924%40bhagyashri-Lenovo-G570.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Bhagyashri Dighole]

On Wed, Mar 6, 2019 at 1:29 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>
> It would be good to have a cover letter (0/2) for this patch series as
> well.
>

I used -n flag for generating cover letter because there is two patch series.

> julia
>
> On Wed, 6 Mar 2019, Bhagyashri Dighole wrote:
>
> > Remove unused #defines detected by checkpatch.pl.
> >
> > Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> > ---
> > Changes in v3:
> >   -- Change the subject line according to log messages.
> >   -- Remove extra spaces.
> >
> > Changes in v2:
> >   - Remove unused macro.
> >
> >  drivers/staging/fbtft/fb_watterott.c | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c
> > index 0a5206d..502d67f 100644
> > --- a/drivers/staging/fbtft/fb_watterott.c
> > +++ b/drivers/staging/fbtft/fb_watterott.c
> > @@ -90,15 +90,9 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
> >       return 0;
> >  }
> >
> > -#define RGB565toRGB323(c) ((((c) & 0xE000) >> 8) |\
> > -                        (((c) & 000600) >> 6) |\
> > -                        (((c) & 0x001C) >> 2))
> >  #define RGB565toRGB332(c) ((((c) & 0xE000) >> 8) |\
> >                          (((c) & 000700) >> 6) |\
> >                          (((c) & 0x0018) >> 3))
> > -#define RGB565toRGB233(c) ((((c) & 0xC000) >> 8) |\
> > -                        (((c) & 000700) >> 5) |\
> > -                        (((c) & 0x001C) >> 2))
> >
> >  static int write_vmem_8bit(struct fbtft_par *par, size_t offset, size_t len)
> >  {
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190306052313.GA3924%40bhagyashri-Lenovo-G570.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903060859150.2706%40hadrien.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] [PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Julia Lawall]

On Wed, 6 Mar 2019, Bhagyashri Dighole wrote:

> On Wed, Mar 6, 2019 at 1:29 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> > It would be good to have a cover letter (0/2) for this patch series as
> > well.
> >
>
> I used -n flag for generating cover letter because there is two patch series.

But it seems that there is no cover letter, or at least I did not receive
one.

The documentation for git format-patch says:

When multiple patches are output, the subject prefix will instead be
"[PATCH n/m] ". To force 1/1 to be added for a single patch, use -n. To
omit patch numbers from the subject, use -N.

So that doesn't seem like the right way to get a cover letter.  (Indeed, I
have noticed some patches with 1/1, which also seems unnecessary).  I
think you want the option --cover-letter.  This is discussed in the
"Versioning patchsets" section of the tutorial.

julia

Re: [Outreachy kernel] [PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Bhagyashri Dighole]

On Wed, Mar 6, 2019 at 3:14 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Wed, 6 Mar 2019, Bhagyashri Dighole wrote:
>
> > On Wed, Mar 6, 2019 at 1:29 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
> > >
> > > It would be good to have a cover letter (0/2) for this patch series as
> > > well.
> > >
> >
> > I used -n flag for generating cover letter because there is two patch series.
>
> But it seems that there is no cover letter, or at least I did not receive
> one.
>
> The documentation for git format-patch says:
>
> When multiple patches are output, the subject prefix will instead be
> "[PATCH n/m] ". To force 1/1 to be added for a single patch, use -n. To
> omit patch numbers from the subject, use -N.

I will modify it accordingly.
>
> So that doesn't seem like the right way to get a cover letter.  (Indeed, I
> have noticed some patches with 1/1, which also seems unnecessary).  I
> think you want the option --cover-letter.  This is discussed in the
> "Versioning patchsets" section of the tutorial.
>

> julia
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1903061039180.3557%40hadrien.
> For more options, visit https://groups.google.com/d/optout.

Re: [PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Greg Kroah-Hartman]

On Wed, Mar 06, 2019 at 10:53:13AM +0530, Bhagyashri Dighole wrote:
> Remove unused #defines detected by checkpatch.pl.

As Julie said, checkpatch.pl did not detect these :(

Also when you send multiple patches, please properly "thread" them by
sending them using 'git send-email' all at once which will do this for
you automatically.

thanks,

greg k-h

Re: [PATCH v3 1/2] staging: fbtft: Remove unused #defines.

[Bhagyashri Dighole]

On Wed, Mar 6, 2019 at 2:41 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Mar 06, 2019 at 10:53:13AM +0530, Bhagyashri Dighole wrote:
> > Remove unused #defines detected by checkpatch.pl.
> As Julie said, checkpatch.pl did not detect these :(

I will modify subject line.

> Also when you send multiple patches, please properly "thread" them by
> sending them using 'git send-email' all at once which will do this for
> you automatically.

Sure, I will do this using above way.

> thanks,
>
> greg k-h