ov2680: Fail to probe on imx7s-warp

ov2680: Fail to probe on imx7s-warp

[Fabio Estevam]

Hi,

Currently, the ov2680 fails to probe on a imx7s-warp board:

ov2680 1-0036: error -EINVAL: supported link freq 330000000 not found
ov2680 1-0036: probe with driver ov2680 failed with error -2

Reverting 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint
property verification")
makes it probe again:

ov2680 1-0036: sensor_revision id = 0x2680, rev= 0

Any ideas on how to fix this regression?

Thanks,

Fabio Estevam

Re: ov2680: Fail to probe on imx7s-warp

[Fabio Estevam]

On Wed, Mar 27, 2024 at 11:54 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi,
>
> Currently, the ov2680 fails to probe on a imx7s-warp board:
>
> ov2680 1-0036: error -EINVAL: supported link freq 330000000 not found
> ov2680 1-0036: probe with driver ov2680 failed with error -2
>
> Reverting 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint
> property verification")
> makes it probe again:

I checked that bus_cfg.nr_of_link_frequencies == 0 which causes the
dev_err_probe().

Is there anything that needs to be adapted in
arch/arm/boot/dts/nxp/imx/imx7s-warp.dts ?

Thanks

Re: ov2680: Fail to probe on imx7s-warp

[Fabio Estevam]

On Thu, Mar 28, 2024 at 12:15 AM Fabio Estevam <festevam@gmail.com> wrote:

> I checked that bus_cfg.nr_of_link_frequencies == 0 which causes the
> dev_err_probe().
>
> Is there anything that needs to be adapted in
> arch/arm/boot/dts/nxp/imx/imx7s-warp.dts ?

I had to make the following changes to make ov2680 probe:

diff --git a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
index ba7231b364bb..7bab113ca6da 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
@@ -210,6 +210,7 @@ ov2680_to_mipi: endpoint {
                                remote-endpoint = <&mipi_from_sensor>;
                                clock-lanes = <0>;
                                data-lanes = <1>;
+                               link-frequencies = /bits/ 64 <330000000>;
                        };
                };
        };
diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
index 39d321e2b7f9..cfa77a62b526 100644
--- a/drivers/media/i2c/ov2680.c
+++ b/drivers/media/i2c/ov2680.c
@@ -1125,7 +1125,7 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)

        for (i = 0; i < bus_cfg.nr_of_link_frequencies; i++)
                if (bus_cfg.link_frequencies[i] == sensor->link_freq[0])
-                       break;
+                       return 0;

        if (bus_cfg.nr_of_link_frequencies == 0 ||
            bus_cfg.nr_of_link_frequencies == i) {